X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FHTTPD.pm;h=3319396996301b3262e89c0b074168ed3004e779;hb=95bdac7f09c69036efed537a4d03d5bdd2ae4eb6;hp=fb476624dbbb8b42837958e7e211daadbd145563;hpb=15e14f11af0b9919f11e0c186b365ae0154e7e77;p=public-inbox.git

diff --git a/lib/PublicInbox/HTTPD.pm b/lib/PublicInbox/HTTPD.pm
index fb476624..33193969 100644
--- a/lib/PublicInbox/HTTPD.pm
+++ b/lib/PublicInbox/HTTPD.pm
@@ -1,12 +1,14 @@
-# Copyright (C) 2016 all contributors <meta@public-inbox.org>
+# Copyright (C) 2016-2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
+# wraps a listen socket for HTTP and links it to the PSGI app in
+# public-inbox-httpd
 package PublicInbox::HTTPD;
 use strict;
 use warnings;
 use Plack::Util;
-require PublicInbox::HTTPD::Async;
-require PublicInbox::Daemon;
+use PublicInbox::HTTPD::Async;
+use PublicInbox::Daemon;
 
 sub pi_httpd_async { PublicInbox::HTTPD::Async->new(@_) }
 
@@ -27,14 +29,17 @@ sub new {
 		'psgi.run_once'	 => Plack::Util::FALSE,
 		'psgi.multithread' => Plack::Util::FALSE,
 		'psgi.multiprocess' => Plack::Util::TRUE,
-		'psgix.harakiri'=> Plack::Util::FALSE,
+
+		# We don't use this anywhere, but we can support
+		# other PSGI apps which might use it:
 		'psgix.input.buffered' => Plack::Util::TRUE,
 
-		# XXX unstable API!
-		'pi-httpd.async' => do {
-			no warnings 'once';
-			*pi_httpd_async
-		},
+		# XXX unstable API!, only GitHTTPBackend needs
+		# this to limit git-http-backend(1) parallelism.
+		# The rest of our PSGI code is generic, relying
+		# on "pull" model using "getline" to prevent
+		# over-buffering.
+		'pi-httpd.async' => \&pi_httpd_async
 	);
 	bless {
 		app => $app,