X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FIdxStack.pm;h=54d480bdd3710fe8ffa2418c665313d609688d27;hb=b46de4da83d797281af9603f350e5b7105845eed;hp=e7e10de94da8cc3a9aa97322e052c9834a944146;hpb=58a964c3c8a2f1699065358e4041b529d3ee531c;p=public-inbox.git
diff --git a/lib/PublicInbox/IdxStack.pm b/lib/PublicInbox/IdxStack.pm
index e7e10de9..54d480bd 100644
--- a/lib/PublicInbox/IdxStack.pm
+++ b/lib/PublicInbox/IdxStack.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2020 all contributors
+# Copyright (C) 2020-2021 all contributors
# License: AGPL-3.0+
# temporary stack for public-inbox-index
@@ -11,6 +11,8 @@ use constant PACK_FMT => eval { pack('Q', 1) } ? 'A1QQH*H*' : 'A1IIH*H*';
# start off in write-only mode
sub new {
open(my $io, '+>', undef) or die "open: $!";
+ # latest_cmt is still useful when the newest revision is a `d'(elete),
+ # otherwise we favor $sync->{latest_cmt} for checkpoints and {quit}
bless { wr => $io, latest_cmt => $_[1] }, __PACKAGE__
}
@@ -18,12 +20,12 @@ sub new {
sub push_rec {
my ($self, $file_char, $at, $ct, $blob_oid, $cmt_oid) = @_;
my $rec = pack(PACK_FMT, $file_char, $at, $ct, $blob_oid, $cmt_oid);
- $self->{unpack_fmt} //= do {
+ $self->{unpack_fmt} // do {
my $len = length($cmt_oid);
my $fmt = PACK_FMT;
$fmt =~ s/H\*/H$len/g;
$self->{rec_size} = length($rec);
- $fmt;
+ $self->{unpack_fmt} = $fmt;
};
print { $self->{wr} } $rec or die "print: $!";
$self->{tot_size} += length($rec);