X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FInboxIdle.pm;h=f0d8a972ed03226074bba2317180a8e9dcf6ffa5;hb=HEAD;hp=2781b3e15bb96c290be28169009705a941662d08;hpb=0f8cfbace2ab68aabfdfb6e9a06023043e943a67;p=public-inbox.git diff --git a/lib/PublicInbox/InboxIdle.pm b/lib/PublicInbox/InboxIdle.pm index 2781b3e1..f0d8a972 100644 --- a/lib/PublicInbox/InboxIdle.pm +++ b/lib/PublicInbox/InboxIdle.pm @@ -1,11 +1,11 @@ -# Copyright (C) 2020-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ # fields: # inot: Linux::Inotify2-like object # pathmap => { inboxdir => [ ibx, watch1, watch2, watch3... ] } mapping package PublicInbox::InboxIdle; -use strict; +use v5.12; use parent qw(PublicInbox::DS); use PublicInbox::Syscall qw(EPOLLIN); my $IN_MODIFY = 0x02; # match Linux inotify @@ -30,9 +30,9 @@ sub in2_arm ($$) { # PublicInbox::Config::each_inbox callback my $old_ibx = $cur->[0]; $cur->[0] = $ibx; if ($old_ibx) { - $ibx->{unlock_subs} and - die "BUG: $dir->{unlock_subs} should not exist"; + my $u = $ibx->{unlock_subs}; $ibx->{unlock_subs} = $old_ibx->{unlock_subs}; + %{$ibx->{unlock_subs}} = (%$u, %{$ibx->{unlock_subs}}) if $u; # Linux::Inotify2::Watch::name matches if watches are the # same, no point in replacing a watch of the same name @@ -48,11 +48,9 @@ sub in2_arm ($$) { # PublicInbox::Config::each_inbox callback $self->{on_unlock}->{$w->name} = $ibx; } else { warn "E: ".ref($inot)."->watch($lock, IN_MODIFY) failed: $!\n"; - if ($!{ENOSPC} && $^O eq 'linux') { - warn <<""; -I: consider increasing /proc/sys/fs/inotify/max_user_watches + warn <<"" if $!{ENOSPC} && $^O eq 'linux'; +# consider increasing /proc/sys/fs/inotify/max_user_watches - } } # TODO: detect deleted packs (and possibly other files)