X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FLEI.pm;h=b5bdda215008ebd95ba0bb49418e865112f1f44e;hb=3104d7492aa4aee07455dcad7449f786188afdf5;hp=6be6d10b541dcf44d48656e082d625a9ebb8c7ad;hpb=1a8441c1e5e468441e67bc7eec6771770e62af78;p=public-inbox.git diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 6be6d10b..b5bdda21 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -12,22 +12,22 @@ use parent qw(PublicInbox::DS PublicInbox::LeiExternal PublicInbox::LeiQuery); use Getopt::Long (); use Socket qw(AF_UNIX SOCK_SEQPACKET MSG_EOR pack_sockaddr_un); -use Errno qw(EAGAIN EINTR ECONNREFUSED ENOENT ECONNRESET); -use POSIX (); +use Errno qw(EPIPE EAGAIN EINTR ECONNREFUSED ENOENT ECONNRESET); +use Cwd qw(getcwd); +use POSIX qw(strftime); use IO::Handle (); use Fcntl qw(SEEK_SET); -use Sys::Syslog qw(syslog openlog); use PublicInbox::Config; use PublicInbox::Syscall qw(SFD_NONBLOCK EPOLLIN EPOLLET); use PublicInbox::Sigfd; use PublicInbox::DS qw(now dwaitpid); -use PublicInbox::Spawn qw(spawn run_die popen_rd); -use PublicInbox::OnDestroy; -use Text::Wrap qw(wrap); +use PublicInbox::Spawn qw(spawn popen_rd); +use PublicInbox::Lock; +use Time::HiRes qw(stat); # ctime comparisons for config cache use File::Path qw(mkpath); use File::Spec; our $quit = \&CORE::exit; -our ($current_lei, $errors_log); +our ($current_lei, $errors_log, $listener, $oldset); my ($recv_cmd, $send_cmd); my $GLP = Getopt::Long::Parser->new; $GLP->configure(qw(gnu_getopt no_ignore_case auto_abbrev)); @@ -35,7 +35,6 @@ my $GLP_PASS = Getopt::Long::Parser->new; $GLP_PASS->configure(qw(gnu_getopt no_ignore_case auto_abbrev pass_through)); our %PATH2CFG; # persistent for socket daemon -our @TO_CLOSE_ATFORK_CHILD; # TBD: this is a documentation mechanism to show a subcommand # (may) pass options through to another command: @@ -65,92 +64,130 @@ sub opt_dash ($$) { ($spec, '<>' => $cb, $GLP_PASS) # for Getopt::Long } +sub rel2abs ($$) { + my ($self, $p) = @_; + return $p if index($p, '/') == 0; # already absolute + my $pwd = $self->{env}->{PWD}; + if (defined $pwd) { + my $cwd = $self->{3} // getcwd() // die "getcwd(PWD=$pwd): $!"; + if (my @st_pwd = stat($pwd)) { + my @st_cwd = stat($cwd) or die "stat($cwd): $!"; + "@st_pwd[1,0]" eq "@st_cwd[1,0]" or + $self->{env}->{PWD} = $pwd = $cwd; + } else { # PWD was invalid + delete $self->{env}->{PWD}; + undef $pwd; + } + } + $pwd //= $self->{env}->{PWD} = getcwd() // die "getcwd(PWD=$pwd): $!"; + File::Spec->rel2abs($p, $pwd); +} + sub _store_path ($) { - my ($env) = @_; - File::Spec->rel2abs(($env->{XDG_DATA_HOME} // - ($env->{HOME} // '/nonexistent').'/.local/share') - .'/lei/store', $env->{PWD}); + my ($self) = @_; + rel2abs($self, ($self->{env}->{XDG_DATA_HOME} // + ($self->{env}->{HOME} // '/nonexistent').'/.local/share') + .'/lei/store'); } sub _config_path ($) { - my ($env) = @_; - File::Spec->rel2abs(($env->{XDG_CONFIG_HOME} // - ($env->{HOME} // '/nonexistent').'/.config') - .'/lei/config', $env->{PWD}); + my ($self) = @_; + rel2abs($self, ($self->{env}->{XDG_CONFIG_HOME} // + ($self->{env}->{HOME} // '/nonexistent').'/.config') + .'/lei/config'); +} + +sub index_opt { + # TODO: drop underscore variants everywhere, they're undocumented + qw(fsync|sync! jobs|j=i indexlevel|L=s compact + max_size|max-size=s sequential_shard|sequential-shard + batch_size|batch-size=s skip-docdata) } -# TODO: generate shell completion + help using %CMD and %OPTDESC +# we generate shell completion + help using %CMD and %OPTDESC, +# see lei__complete() and PublicInbox::LeiHelp # command => [ positional_args, 1-line description, Getopt::Long option spec ] our %CMD = ( # sorted in order of importance/use: -'q' => [ 'SEARCH_TERMS...', 'search for messages matching terms', qw( - save-as=s output|mfolder|o=s format|f=s dedupe|d=s thread|t augment|a - sort|s=s reverse|r offset=i remote local! external! pretty mua-cmd=s - since|after=s until|before=s), opt_dash('limit|n=i', '[0-9]+') ], +'q' => [ '--stdin|SEARCH_TERMS...', 'search for messages matching terms', qw( + save-as=s output|mfolder|o=s format|f=s dedupe|d=s threads|t+ augment|a + sort|s=s reverse|r offset=i remote! local! external! pretty + include|I=s@ exclude=s@ only=s@ jobs|j=s globoff|g stdin| + import-remote! lock=s@ + alert=s@ mua=s no-torsocks torsocks=s verbose|v+ quiet|q C=s@), + PublicInbox::LeiQuery::curl_opt(), opt_dash('limit|n=i', '[0-9]+') ], 'show' => [ 'MID|OID', 'show a given object (Message-ID or object ID)', - qw(type=s solve! format|f=s dedupe|d=s thread|t remote local!), + qw(type=s solve! format|f=s dedupe|d=s threads|t remote local! C=s@), pass_through('git show') ], -'add-external' => [ 'URL_OR_PATHNAME', +'add-external' => [ 'LOCATION', 'add/set priority of a publicinbox|extindex for extra matches', - qw(boost=i quiet|q) ], -'ls-external' => [ '[FILTER...]', 'list publicinbox|extindex locations', - qw(format|f=s z|0 local remote quiet|q) ], -'forget-external' => [ '{URL_OR_PATHNAME|--prune}', + qw(boost=i c=s@ mirror=s no-torsocks torsocks=s inbox-version=i), + qw(quiet|q verbose|v+ C=s@), + index_opt(), PublicInbox::LeiQuery::curl_opt() ], +'ls-external' => [ '[FILTER]', 'list publicinbox|extindex locations', + qw(format|f=s z|0 globoff|g invert-match|v local remote C=s@) ], +'forget-external' => [ 'LOCATION...|--prune', 'exclude further results from a publicinbox|extindex', - qw(prune quiet|q) ], + qw(prune quiet|q C=s@) ], 'ls-query' => [ '[FILTER...]', 'list saved search queries', - qw(name-only format|f=s z) ], -'rm-query' => [ 'QUERY_NAME', 'remove a saved search' ], -'mv-query' => [ qw(OLD_NAME NEW_NAME), 'rename a saved search' ], + qw(name-only format|f=s z C=s@) ], +'rm-query' => [ 'QUERY_NAME', 'remove a saved search', qw(C=s@) ], +'mv-query' => [ qw(OLD_NAME NEW_NAME), 'rename a saved search', qw(C=s@) ], -'plonk' => [ '--thread|--from=IDENT', - 'exclude mail matching From: or thread from non-Message-ID searches', - qw(stdin| thread|t from|f=s mid=s oid=s) ], +'plonk' => [ '--threads|--from=IDENT', + 'exclude mail matching From: or threads from non-Message-ID searches', + qw(stdin| threads|t from|f=s mid=s oid=s C=s@) ], 'mark' => [ 'MESSAGE_FLAGS...', - 'set/unset flags on message(s) from stdin', - qw(stdin| oid=s exact by-mid|mid:s) ], + 'set/unset keywords on message(s) from stdin', + qw(stdin| oid=s exact by-mid|mid:s C=s@) ], 'forget' => [ '[--stdin|--oid=OID|--by-mid=MID]', "exclude message(s) on stdin from `q' search results", - qw(stdin| oid=s exact by-mid|mid:s quiet|q) ], + qw(stdin| oid=s exact by-mid|mid:s quiet|q C=s@) ], -'purge-mailsource' => [ '{URL_OR_PATHNAME|--all}', +'purge-mailsource' => [ 'LOCATION|--all', 'remove imported messages from IMAP, Maildirs, and MH', - qw(exact! all jobs:i indexed) ], + qw(exact! all jobs:i indexed C=s@) ], # code repos are used for `show' to solve blobs from patch mails -'add-coderepo' => [ 'PATHNAME', 'add or set priority of a git code repo', - qw(boost=i) ], +'add-coderepo' => [ 'DIRNAME', 'add or set priority of a git code repo', + qw(boost=i C=s@) ], 'ls-coderepo' => [ '[FILTER_TERMS...]', - 'list known code repos', qw(format|f=s z) ], -'forget-coderepo' => [ 'PATHNAME', + 'list known code repos', qw(format|f=s z C=s@) ], +'forget-coderepo' => [ 'DIRNAME', 'stop using repo to solve blobs from patches', - qw(prune) ], + qw(prune C=s@) ], -'add-watch' => [ '[URL_OR_PATHNAME]', - 'watch for new messages and flag changes', - qw(import! flags! interval=s recursive|r exclude=s include=s) ], +'add-watch' => [ 'LOCATION', 'watch for new messages and flag changes', + qw(import! kw|keywords|flags! interval=s recursive|r + exclude=s include=s C=s@) ], 'ls-watch' => [ '[FILTER...]', 'list active watches with numbers and status', - qw(format|f=s z) ], -'pause-watch' => [ '[WATCH_NUMBER_OR_FILTER]', qw(all local remote) ], -'resume-watch' => [ '[WATCH_NUMBER_OR_FILTER]', qw(all local remote) ], + qw(format|f=s z C=s@) ], +'pause-watch' => [ '[WATCH_NUMBER_OR_FILTER]', qw(all local remote C=s@) ], +'resume-watch' => [ '[WATCH_NUMBER_OR_FILTER]', qw(all local remote C=s@) ], 'forget-watch' => [ '{WATCH_NUMBER|--prune}', 'stop and forget a watch', - qw(prune) ], + qw(prune C=s@) ], -'import' => [ '{URL_OR_PATHNAME|--stdin}', - 'one-shot import/update from URL or filesystem', - qw(stdin| offset=i recursive|r exclude=s include=s !flags), +'import' => [ 'LOCATION...|--stdin', + 'one-time import/update from URL or filesystem', + qw(stdin| offset=i recursive|r exclude=s include|I=s + in-format|F=s kw|keywords|flags! C=s@), + ], +'convert' => [ 'LOCATION...|--stdin', + 'one-time conversion from URL or filesystem to another format', + qw(stdin| in-format|F=s out-format|f=s output|mfolder|o=s quiet|q + kw|keywords|flags! C=s@), ], - 'config' => [ '[...]', sub { 'git-config(1) wrapper for '._config_path($_[0]); }, qw(config-file|system|global|file|f=s), # for conflict detection - pass_through('git config') ], -'init' => [ '[PATHNAME]', sub { - 'initialize storage, default: '._store_path($_[0]); - }, qw(quiet|q) ], + qw(C=s@), pass_through('git config') ], +'init' => [ '[DIRNAME]', sub { + "initialize storage, default: "._store_path($_[0]); + }, qw(quiet|q C=s@) ], 'daemon-kill' => [ '[-SIGNAL]', 'signal the lei-daemon', + # "-C DIR" conflicts with -CHLD, here, and chdir makes no sense, here opt_dash('signal|s=s', '[0-9]+|(?:[A-Z][A-Z0-9]+)') ], 'daemon-pid' => [ '', 'show the PID of the lei-daemon' ], 'help' => [ '[SUBCOMMAND]', 'show help' ], @@ -160,7 +197,7 @@ our %CMD = ( # sorted in order of importance/use: 'reorder-local-store-and-break-history' => [ '[REFNAME]', 'rewrite git history in an attempt to improve compression', - 'gc!' ], + qw(gc! C=s@) ], # internal commands are prefixed with '_' '_complete' => [ '[...]', 'internal shell completion helper', @@ -172,45 +209,93 @@ our %CMD = ( # sorted in order of importance/use: # $spec => [@ALLOWED_VALUES (default is first), $description], # $spec => $description # "$SUB_COMMAND TAB $spec" => as above -my $stdin_formats = [ 'IN|auto|raw|mboxrd|mboxcl2|mboxcl|mboxo', - 'specify message input format' ]; +my $stdin_formats = [ 'MAIL_FORMAT|eml|mboxrd|mboxcl2|mboxcl|mboxo', + 'specify message input format' ]; my $ls_format = [ 'OUT|plain|json|null', 'listing output format' ]; +# we use \x{a0} (non-breaking SP) to avoid wrapping in PublicInbox::LeiHelp my %OPTDESC = ( 'help|h' => 'show this built-in help', +'C=s@' => [ 'DIR', 'chdir to specify to directory' ], 'quiet|q' => 'be quiet', +'globoff|g' => "do not match locations using '*?' wildcards ". + "and\xa0'[]'\x{a0}ranges", +'verbose|v+' => 'be more verbose', 'solve!' => 'do not attempt to reconstruct blobs from emails', +'torsocks=s' => ['VAL|auto|no|yes', + 'whether or not to wrap git and curl commands with torsocks'], +'no-torsocks' => 'alias for --torsocks=no', 'save-as=s' => ['NAME', 'save a search terms by given name'], +'import-remote!' => 'do not memoize remote messages into local store', 'type=s' => [ 'any|mid|git', 'disambiguate type' ], -'dedupe|d=s' => ['STRAT|content|oid|mid|none', +'dedupe|d=s' => ['STRATEGY|content|oid|mid|none', 'deduplication strategy'], -'show thread|t' => 'display entire thread a message belongs to', -'q thread|t' => - 'return all messages in the same thread as the actual match(es)', +'show threads|t' => 'display entire thread a message belongs to', +'q threads|t+' => + 'return all messages in the same threads as the actual match(es)', +'alert=s@' => ['CMD,:WINCH,:bell,', + 'run command(s) or perform ops when done writing to output ' . + '(default: ":WINCH,:bell" with --mua and Maildir/IMAP output, ' . + 'nothing otherwise)' ], + 'augment|a' => 'augment --output destination instead of clobbering', -'output|o=s' => [ 'DEST', - "destination (e.g. `/path/to/Maildir', or `-' for stdout)" ], -'mua-cmd|mua=s' => [ 'COMMAND', - "MUA to run on --output Maildir or mbox (e.g. `mutt -f %f'" ], +'output|mfolder|o=s' => [ 'MFOLDER', + "destination (e.g.\xa0`/path/to/Maildir', ". + "or\xa0`-'\x{a0}for\x{a0}stdout)" ], +'mua=s' => [ 'CMD', + "MUA to run on --output Maildir or mbox (e.g.\xa0`mutt\xa0-f\xa0%f')" ], 'show format|f=s' => [ 'OUT|plain|raw|html|mboxrd|mboxcl2|mboxcl', 'message/object output format' ], 'mark format|f=s' => $stdin_formats, 'forget format|f=s' => $stdin_formats, -'q format|f=s' => [ 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|oid|json', + +'add-external inbox-version=i' => [ 'NUM|1|2', + 'force a public-inbox version with --mirror'], +'add-external mirror=s' => [ 'URL', 'mirror a public-inbox'], + +# public-inbox-index options +'add-external jobs|j=i' => 'set parallelism when indexing after --mirror', +'fsync!' => 'speed up indexing after --mirror, risk index corruption', +'compact' => 'run compact index after mirroring', +'indexlevel|L=s' => [ 'LEVEL|full|medium|basic', + "indexlevel with --mirror (default: full)" ], +'max_size|max-size=s' => [ 'SIZE', + 'do not index messages larger than SIZE (default: infinity)' ], +'batch_size|batch-size=s' => [ 'SIZE', + 'flush changes to OS after given number of bytes (default: 1m)' ], +'sequential_shard|sequential-shard' => + 'index Xapian shards sequentially for slow storage', +'skip-docdata' => + 'drop compatibility w/ public-inbox <1.6 to save ~1.5% space', + +'q format|f=s' => [ + 'OUT|maildir|mboxrd|mboxcl2|mboxcl|mboxo|html|json|jsonl|concatjson', 'specify output format, default depends on --output'], +'q exclude=s@' => [ 'LOCATION', + 'exclude specified external(s) from search' ], +'q include|I=s@' => [ 'LOCATION', + 'include specified external(s) in search' ], +'q only=s@' => [ 'LOCATION', + 'only use specified external(s) for search' ], + +'q jobs=s' => [ '[SEARCH_JOBS][,WRITER_JOBS]', + 'control number of search and writer jobs' ], + +'import format|f=s' => $stdin_formats, + 'ls-query format|f=s' => $ls_format, 'ls-external format|f=s' => $ls_format, 'limit|n=i@' => ['NUM', 'limit on number of matches (default: 10000)' ], 'offset=i' => ['OFF', 'search result offset (default: 0)'], -'sort|s=s' => [ 'VAL|received,relevance,docid', - "order of results `--output'-dependent"], -'reverse|r' => [ 'reverse search results' ], # like sort(1) +'sort|s=s' => [ 'VAL|received|relevance|docid', + "order of results is `--output'-dependent"], +'reverse|r' => 'reverse search results', # like sort(1) 'boost=i' => 'increase/decrease priority of results (default: 0)', @@ -230,7 +315,8 @@ my %OPTDESC = ( 'exact!' => 'rely on content match instead of exact header matches', 'by-mid|mid:s' => [ 'MID', 'match only by Message-ID, ignoring contents' ], -'jobs:i' => 'set parallelism level', + +'kw|keywords|flags!' => 'disable/enable importing flags', # xargs, env, use "-0", git(1) uses "-z". We support z|0 everywhere 'z|0' => 'use NUL \\0 instead of newline (CR) to delimit lines', @@ -242,186 +328,180 @@ my %CONFIG_KEYS = ( 'leistore.dir' => 'top-level storage location', ); +my @WQ_KEYS = qw(lxs l2m imp mrr cnv); # internal workers + # pronounced "exit": x_it(1 << 8) => exit(1); x_it(13) => SIGPIPE sub x_it ($$) { my ($self, $code) = @_; # make sure client sees stdout before exit $self->{1}->autoflush(1) if $self->{1}; dump_and_clear_log(); - if (my $sock = $self->{sock}) { - send($sock, "x_it $code", MSG_EOR); - } elsif (!($code & 127)) { # oneshot, ignore signals + if (my $s = $self->{pkt_op_p} // $self->{sock}) { + send($s, "x_it $code", MSG_EOR); + } elsif ($self->{oneshot}) { # don't want to end up using $? from child processes - for my $f (qw(lxs l2m)) { + for my $f (@WQ_KEYS) { my $wq = delete $self->{$f} or next; $wq->DESTROY; } - $quit->($code >> 8); - } + # cleanup anything that has tempfiles or open file handles + %PATH2CFG = (); + delete @$self{qw(ovv dedupe sto cfg)}; + if (my $signum = ($code & 127)) { # usually SIGPIPE (13) + $SIG{PIPE} = 'DEFAULT'; # $SIG{$signum} doesn't work + kill $signum, $$; + sleep(1) while 1; # wait for signal + } else { + $quit->($code >> 8); + } + } # else ignore if client disconnected } -sub puts ($;@) { print { shift->{1} } map { "$_\n" } @_ } - -sub out ($;@) { print { shift->{1} } @_ } - sub err ($;@) { my $self = shift; - my $err = $self->{2} // ($self->{pgr} // [])->[2] // *STDERR{IO}; - print $err @_, (substr($_[-1], -1, 1) eq "\n" ? () : "\n"); + my $err = $self->{2} // ($self->{pgr} // [])->[2] // *STDERR{GLOB}; + my @eor = (substr($_[-1]//'', -1, 1) eq "\n" ? () : ("\n")); + print $err @_, @eor and return; + my $old_err = delete $self->{2}; + close($old_err) if $! == EPIPE && $old_err; + $err = $self->{2} = ($self->{pgr} // [])->[2] // *STDERR{GLOB}; + print $err @_, @eor or print STDERR @_, @eor; } sub qerr ($;@) { $_[0]->{opt}->{quiet} or err(shift, @_) } +sub fail_handler ($;$$) { + my ($lei, $code, $io) = @_; + for my $f (@WQ_KEYS) { + my $wq = delete $lei->{$f} or next; + $wq->wq_wait_old(undef, $lei) if $wq->wq_kill_old; # lei-daemon + } + close($io) if $io; # needed to avoid warnings on SIGPIPE + x_it($lei, $code // (1 << 8)); +} + +sub sigpipe_handler { # handles SIGPIPE from @WQ_KEYS workers + fail_handler($_[0], 13, delete $_[0]->{1}); +} + +# PublicInbox::OnDestroy callback for SIGINT to take out the entire pgid +sub sigint_reap { + my ($pgid) = @_; + dwaitpid($pgid) if kill('-INT', $pgid); +} + sub fail ($$;$) { my ($self, $buf, $exit_code) = @_; - err($self, $buf); + err($self, $buf) if defined $buf; + # calls fail_handler: + send($self->{pkt_op_p}, '!', MSG_EOR) if $self->{pkt_op_p}; x_it($self, ($exit_code // 1) << 8); undef; } -sub atfork_prepare_wq { - my ($self, $wq) = @_; - my $tcafc = $wq->{-ipc_atfork_child_close}; - push @$tcafc, @TO_CLOSE_ATFORK_CHILD; - if (my $sock = $self->{sock}) { - push @$tcafc, @$self{qw(0 1 2)}, $sock; - } - for my $f (qw(lxs l2m)) { - my $ipc = $self->{$f} or next; - push @$tcafc, grep { defined } - @$ipc{qw(-wq_s1 -wq_s2 -ipc_req -ipc_res)}; +sub check_input_format ($;$) { + my ($self, $files) = @_; + my $opt_key = 'in-format'; + my $fmt = $self->{opt}->{$opt_key}; + if (!$fmt) { + my $err = $files ? "regular file(s):\n@$files" : '--stdin'; + return fail($self, "--$opt_key unset for $err"); } + return 1 if $fmt eq 'eml'; + # XXX: should this handle {gz,bz2,xz}? that's currently in LeiToMail + require PublicInbox::MboxReader; + PublicInbox::MboxReader->can($fmt) || + fail($self, "--$opt_key=$fmt unrecognized"); +} + +sub out ($;@) { + my $self = shift; + return if print { $self->{1} // return } @_; # likely + return note_sigpipe($self, 1) if $! == EPIPE; + my $err = "error writing to stdout: $!"; + delete $self->{1}; + fail($self, $err); +} + +sub puts ($;@) { out(shift, map { "$_\n" } @_) } + +sub child_error { # passes non-fatal curl exit codes to user + my ($self, $child_error, $msg) = @_; # child_error is $? + $self->err($msg) if $msg; + if (my $s = $self->{pkt_op_p} // $self->{sock}) { + # send to the parent lei-daemon or to lei(1) client + send($s, "child_error $child_error", MSG_EOR); + } elsif (!$PublicInbox::DS::in_loop) { + $self->{child_error} = $child_error; + } # else noop if client disconnected +} + +sub note_sigpipe { # triggers sigpipe_handler + my ($self, $fd) = @_; + close(delete($self->{$fd})); # explicit close silences Perl warning + send($self->{pkt_op_p}, '|', MSG_EOR) if $self->{pkt_op_p}; + x_it($self, 13); } -# usage: my %sig = $lei->atfork_child_wq($wq); -# local @SIG{keys %sig} = values %sig; -sub atfork_child_wq { - my ($self, $wq) = @_; - my ($sock, $l2m_wq_s1); - (@$self{qw(0 1 2)}, $sock, $l2m_wq_s1) = delete(@$wq{0..4}); - $self->{sock} = $sock if -S $sock; - $self->{l2m}->{-wq_s1} = $l2m_wq_s1 if $l2m_wq_s1 && -S $l2m_wq_s1; +sub lei_atfork_child { + my ($self, $persist) = @_; + # we need to explicitly close things which are on stack + if ($persist) { + my @io = delete @$self{qw(0 1 2 sock)}; + unless ($self->{oneshot}) { + close($_) for @io; + } + } else { + delete $self->{0}; + } + delete @$self{qw(cnv)}; + for (delete @$self{qw(3 old_1 au_done)}) { + close($_) if defined($_); + } + if (my $op_c = delete $self->{pkt_op_c}) { + close(delete $op_c->{sock}); + } + if (my $pgr = delete $self->{pgr}) { + close($_) for (@$pgr[1,2]); + } + close $listener if $listener; + undef $listener; %PATH2CFG = (); undef $errors_log; $quit = \&CORE::exit; - @TO_CLOSE_ATFORK_CHILD = (); - (__WARN__ => sub { err($self, @_) }, - PIPE => sub { - $self->x_it(13); # SIGPIPE = 13 - # we need to close explicitly to avoid Perl warning on SIGPIPE - for my $i (1, 2) { - next unless $self->{$i} && (-p $self->{$i} || -S _); - close(delete $self->{$i}); - } - # trigger the LeiXSearch $done OpPipe: - syswrite($self->{0}, '!') if $self->{0} && -p $self->{0}; - $SIG{PIPE} = 'DEFAULT'; - die bless(\"$_[0]", 'PublicInbox::SIGPIPE'), - }); + $current_lei = $persist ? undef : $self; # for SIG{__WARN__} } -# usage: ($lei, @io) = $lei->atfork_parent_wq($wq); -sub atfork_parent_wq { - my ($self, $wq) = @_; - my $env = delete $self->{env}; # env is inherited at fork - my $ret = bless { %$self }, ref($self); - if (my $dedupe = delete $ret->{dedupe}) { - $ret->{dedupe} = $wq->deep_clone($dedupe); - } - $self->{env} = $env; - delete @$ret{qw(-lei_store cfg pgr lxs)}; # keep l2m - my @io = delete @$ret{0..2}; - $io[3] = delete($ret->{sock}) // *STDERR{GLOB}; - my $l2m = $ret->{l2m}; - if ($l2m && $l2m != $wq) { # $wq == lxs - $io[4] = $l2m->{-wq_s1} if $l2m->{-wq_s1}; - if (my @pids = $l2m->wq_close) { - $wq->{l2m_pids} = \@pids; - } - } - ($ret, @io); -} - -sub _help ($;$) { - my ($self, $errmsg) = @_; - my $cmd = $self->{cmd} // 'COMMAND'; - my @info = @{$CMD{$cmd} // [ '...', '...' ]}; - my @top = ($cmd, shift(@info) // ()); - my $cmd_desc = shift(@info); - $cmd_desc = $cmd_desc->($self->{env}) if ref($cmd_desc) eq 'CODE'; - my @opt_desc; - my $lpad = 2; - for my $sw (grep { !ref } @info) { # ("prio=s", "z", $GLP_PASS) - my $desc = $OPTDESC{"$cmd\t$sw"} // $OPTDESC{$sw} // next; - my $arg_vals = ''; - ($arg_vals, $desc) = @$desc if ref($desc) eq 'ARRAY'; - - # lower-case is a keyword (e.g. `content', `oid'), - # ALL_CAPS is a string description (e.g. `PATH') - if ($desc !~ /default/ && $arg_vals =~ /\b([a-z]+)[,\|]/) { - $desc .= "\ndefault: `$1'"; - } - my (@vals, @s, @l); - my $x = $sw; - if ($x =~ s/!\z//) { # solve! => --no-solve - $x = "no-$x"; - } elsif ($x =~ s/:.+//) { # optional args: $x = "mid:s" - @vals = (' [', undef, ']'); - } elsif ($x =~ s/=.+//) { # required arg: $x = "type=s" - @vals = (' ', undef); - } # else: no args $x = 'thread|t' - for (split(/\|/, $x)) { # help|h - length($_) > 1 ? push(@l, "--$_") : push(@s, "-$_"); - } - if (!scalar(@vals)) { # no args 'thread|t' - } elsif ($arg_vals =~ s/\A([A-Z_]+)\b//) { # "NAME" - $vals[1] = $1; - } else { - $vals[1] = uc(substr($l[0], 2)); # "--type" => "TYPE" - } - if ($arg_vals =~ /([,\|])/) { - my $sep = $1; - my @allow = split(/\Q$sep\E/, $arg_vals); - my $must = $sep eq '|' ? 'Must' : 'Can'; - @allow = map { "`$_'" } @allow; - my $last = pop @allow; - $desc .= "\n$must be one of: " . - join(', ', @allow) . " or $last"; - } - my $lhs = join(', ', @s, @l) . join('', @vals); - if ($x =~ /\|\z/) { # "stdin|" or "clear|" - $lhs =~ s/\A--/- , --/; - } else { - $lhs =~ s/\A--/ --/; # pad if no short options - } - $lpad = length($lhs) if length($lhs) > $lpad; - push @opt_desc, $lhs, $desc; - } - my $msg = $errmsg ? "E: $errmsg\n" : ''; - $msg .= <{$errmsg ? 2 : 1} } $msg; - x_it($self, $errmsg ? 1 << 8 : 0); # stderr => failure - undef; +sub workers_start { + my ($lei, $wq, $ident, $jobs, $ops) = @_; + $ops = { + '!' => [ $lei->can('fail_handler'), $lei ], + '|' => [ $lei->can('sigpipe_handler'), $lei ], + 'x_it' => [ $lei->can('x_it'), $lei ], + 'child_error' => [ $lei->can('child_error'), $lei ], + %$ops + }; + require PublicInbox::PktOp; + ($lei->{pkt_op_c}, $lei->{pkt_op_p}) = PublicInbox::PktOp->pair($ops); + $wq->wq_workers_start($ident, $jobs, $lei->oldset, { lei => $lei }); + delete $lei->{pkt_op_p}; + my $op = delete $lei->{pkt_op_c}; + $lei->event_step_init; + # oneshot needs $op, daemon-mode uses DS->EventLoop to handle $op + $lei->{oneshot} ? $op : undef; +} + +sub _help { + require PublicInbox::LeiHelp; + PublicInbox::LeiHelp::call($_[0], $_[1], \%CMD, \%OPTDESC); } sub optparse ($$$) { my ($self, $cmd, $argv) = @_; + # allow _complete --help to complete, not show help + return 1 if substr($cmd, 0, 1) eq '_'; $self->{cmd} = $cmd; - $OPT = $self->{opt} = {}; + $OPT = $self->{opt} //= {}; my $info = $CMD{$cmd} // [ '[...]' ]; my ($proto, undef, @spec) = @$info; my $glp = ref($spec[-1]) eq ref($GLP) ? pop(@spec) : $GLP; @@ -458,18 +538,20 @@ sub optparse ($$$) { } elsif ($var =~ /\A\[-?$POS_ARG\]\z/) { # one optional arg $i++; } elsif ($var =~ /\A.+?\|/) { # required FOO|--stdin + $inf = 1 if index($var, '...') > 0; my @or = split(/\|/, $var); my $ok; for my $o (@or) { if ($o =~ /\A--([a-z0-9\-]+)/) { $ok = defined($OPT->{$1}); - last; + last if $ok; } elsif (defined($argv->[$i])) { $ok = 1; $i++; last; } # else continue looping } + last if $ok; my $last = pop @or; $err = join(', ', @or) . " or $last must be set"; } else { @@ -488,15 +570,25 @@ sub dispatch { local $current_lei = $self; # for __WARN__ dump_and_clear_log("from previous run\n"); return _help($self, 'no command given') unless defined($cmd); + while ($cmd eq '-C') { # do not support Getopt bundling for this + my $d = shift(@argv) // return fail($self, '-C DIRECTORY'); + push @{$self->{opt}->{C}}, $d; + $cmd = shift(@argv) // return _help($self, 'no command given'); + } my $func = "lei_$cmd"; $func =~ tr/-/_/; if (my $cb = __PACKAGE__->can($func)) { optparse($self, $cmd, \@argv) or return; + if (my $chdir = $self->{opt}->{C}) { + for my $d (@$chdir) { + next if $d eq ''; # same as git(1) + chdir $d or return fail($self, "cd $d: $!"); + } + } $cb->($self, @argv); } elsif (grep(/\A-/, $cmd, @argv)) { # --help or -h only - my $opt = {}; - $GLP->getoptionsfromarray([$cmd, @argv], $opt, qw(help|h)) or - return _help($self, 'bad arguments or options'); + $GLP->getoptionsfromarray([$cmd, @argv], {}, qw(help|h C=s@)) + or return _help($self, 'bad arguments or options'); _help($self); } else { fail($self, "`$cmd' is not an lei command"); @@ -505,7 +597,7 @@ sub dispatch { sub _lei_cfg ($;$) { my ($self, $creat) = @_; - my $f = _config_path($self->{env}); + my $f = _config_path($self); my @st = stat($f); my $cur_st = @st ? pack('dd', $st[10], $st[7]) : ''; # 10:ctime, 7:size if (my $cfg = $PATH2CFG{$f}) { # reuse existing object in common case @@ -514,16 +606,17 @@ sub _lei_cfg ($;$) { if (!@st) { unless ($creat) { delete $self->{cfg}; - return; + return bless {}, 'PublicInbox::Config'; } my (undef, $cfg_dir, undef) = File::Spec->splitpath($f); -d $cfg_dir or mkpath($cfg_dir) or die "mkpath($cfg_dir): $!\n"; open my $fh, '>>', $f or die "open($f): $!\n"; @st = stat($fh) or die "fstat($f): $!\n"; $cur_st = pack('dd', $st[10], $st[7]); - qerr($self, "I: $f created") if $self->{cmd} ne 'config'; + qerr($self, "# $f created") if $self->{cmd} ne 'config'; } my $cfg = PublicInbox::Config::git_config_dump($f); + bless $cfg, 'PublicInbox::Config'; $cfg->{-st} = $cur_st; $cfg->{'-f'} = $f; $self->{cfg} = $PATH2CFG{$f} = $cfg; @@ -535,8 +628,7 @@ sub _lei_store ($;$) { $cfg->{-lei_store} //= do { require PublicInbox::LeiStore; my $dir = $cfg->{'leistore.dir'}; - $dir //= _store_path($self->{env}) if $creat; - return unless $dir; + $dir //= $creat ? _store_path($self) : return; PublicInbox::LeiStore->new($dir, { creat => $creat }); }; } @@ -549,29 +641,43 @@ sub lei_mark { my ($self, @argv) = @_; } -sub lei_config { +sub _config { my ($self, @argv) = @_; - $self->{opt}->{'config-file'} and return fail $self, - "config file switches not supported by `lei config'"; - my $env = $self->{env}; - delete local $env->{GIT_CONFIG}; + my %env = (%{$self->{env}}, GIT_CONFIG => undef); my $cfg = _lei_cfg($self, 1); my $cmd = [ qw(git config -f), $cfg->{'-f'}, @argv ]; my %rdr = map { $_ => $self->{$_} } (0..2); - run_die($cmd, $env, \%rdr); + waitpid(spawn($cmd, \%env, \%rdr), 0); +} + +sub lei_config { + my ($self, @argv) = @_; + $self->{opt}->{'config-file'} and return fail $self, + "config file switches not supported by `lei config'"; + _config(@_); + x_it($self, $?) if $?; +} + +sub lei_import { + require PublicInbox::LeiImport; + PublicInbox::LeiImport->call(@_); +} + +sub lei_convert { + require PublicInbox::LeiConvert; + PublicInbox::LeiConvert->call(@_); } sub lei_init { my ($self, $dir) = @_; my $cfg = _lei_cfg($self, 1); my $cur = $cfg->{'leistore.dir'}; - my $env = $self->{env}; - $dir //= _store_path($env); - $dir = File::Spec->rel2abs($dir, $env->{PWD}); # PWD is symlink-aware + $dir //= _store_path($self); + $dir = rel2abs($self, $dir); my @cur = stat($cur) if defined($cur); $cur = File::Spec->canonpath($cur // $dir); my @dir = stat($dir); - my $exists = "I: leistore.dir=$cur already initialized" if @dir; + my $exists = "# leistore.dir=$cur already initialized" if @dir; if (@cur) { if ($cur eq $dir) { _lei_store($self, 1)->done; @@ -579,7 +685,7 @@ sub lei_init { } # some folks like symlinks and bind mounts :P - if (@dir && "$cur[0] $cur[1]" eq "$dir[0] $dir[1]") { + if (@dir && "@cur[1,0]" eq "@dir[1,0]") { lei_config($self, 'leistore.dir', $dir); _lei_store($self, 1)->done; return qerr($self, "$exists (as $cur)"); @@ -590,7 +696,7 @@ E: leistore.dir=$cur already initialized and it is not $dir } lei_config($self, 'leistore.dir', $dir); _lei_store($self, 1)->done; - $exists //= "I: leistore.dir=$dir newly initialized"; + $exists //= "# leistore.dir=$dir newly initialized"; return qerr($self, $exists); } @@ -610,7 +716,7 @@ sub lei_help { _help($_[0]) } sub lei__complete { my ($self, @argv) = @_; # argv = qw(lei and any other args...) shift @argv; # ignore "lei", the entire command is sent - @argv or return puts $self, grep(!/^_/, keys %CMD), qw(--help -h); + @argv or return puts $self, grep(!/^_/, keys %CMD), qw(--help -h -C); my $cmd = shift @argv; my $info = $CMD{$cmd} // do { # filter matching commands @argv or puts $self, grep(/\A\Q$cmd\E/, keys %CMD); @@ -633,38 +739,43 @@ sub lei__complete { get-color-name get-colorbool); # fall-through } - # TODO: arg support - puts $self, grep(/$re/, map { # generate short/long names - my $eq = ''; - if (s/=.+\z//) { # required arg, e.g. output|o=i - $eq = '='; - } elsif (s/:.+\z//) { # optional arg, e.g. mid:s - } else { # negation: solve! => no-solve|solve - s/\A(.+)!\z/no-$1|$1/; + # generate short/long names from Getopt::Long specs + puts $self, grep(/$re/, qw(--help -h -C), map { + if (s/[:=].+\z//) { # req/optional args, e.g output|o=i + } elsif (s/\+\z//) { # verbose|v+ + } elsif (s/!\z//) { + # negation: solve! => no-solve|solve + s/([\w\-]+)/$1|no-$1/g } map { - length > 1 ? "--$_$eq" : "-$_" - } split(/\|/, $_, -1) # help|h + my $x = length > 1 ? "--$_" : "-$_"; + $x eq $cur ? () : $x; + } grep(!/_/, split(/\|/, $_, -1)) # help|h } grep { $OPTDESC{"$cmd\t$_"} || $OPTDESC{$_} } @spec); } elsif ($cmd eq 'config' && !@argv && !$CONFIG_KEYS{$cur}) { puts $self, grep(/$re/, keys %CONFIG_KEYS); } + + # switch args (e.g. lei q -f mbox) + if (($argv[-1] // $cur // '') =~ /\A--?([\w\-]+)\z/) { + my $opt = quotemeta $1; + puts $self, map { + my $v = $OPTDESC{$_}; + my @v = ref($v) ? split(/\|/, $v->[0]) : (); + # get rid of ALL CAPS placeholder (e.g "OUT") + # (TODO: completion for external paths) + shift(@v) if uc($v[0]) eq $v[0]; + @v; + } grep(/\A(?:$cmd\t|)(?:[\w-]+\|)*$opt\b/, keys %OPTDESC); + } + $cmd =~ tr/-/_/; + if (my $sub = $self->can("_complete_$cmd")) { + puts $self, $sub->($self, @argv, $cur); + } # TODO: URLs, pathnames, OIDs, MIDs, etc... See optparse() for # proto parsing. } -sub reap_exec { # dwaitpid callback - my ($self, $pid) = @_; - x_it($self, $?); -} - -sub lei_git { # support passing through random git commands - my ($self, @argv) = @_; - my %rdr = map { $_ => $self->{$_} } (0..2); - my $pid = spawn(['git', @argv], $self->{env}, \%rdr); - dwaitpid($pid, \&reap_exec, $self); -} - sub exec_buf ($$) { my ($argv, $env) = @_; my $argc = scalar @$argv; @@ -674,43 +785,91 @@ sub exec_buf ($$) { } sub start_mua { - my ($self, $sock) = @_; - my $mua = $self->{opt}->{'mua-cmd'} // return; + my ($self) = @_; + my $mua = $self->{opt}->{mua} // return; my $mfolder = $self->{ovv}->{dst}; - require Text::ParseWords; - my $replaced; - my @cmd = Text::ParseWords::shellwords($mua); - # mutt uses '%f' for open-hook with compressed folders, so we use %f - @cmd = map { $_ eq '%f' ? ($replaced = $mfolder) : $_ } @cmd; + my (@cmd, $replaced); + if ($mua =~ /\A(?:mutt|mailx|mail|neomutt)\z/) { + @cmd = ($mua, '-f'); + # TODO: help wanted: other common FOSS MUAs + } else { + require Text::ParseWords; + @cmd = Text::ParseWords::shellwords($mua); + # mutt uses '%f' for open-hook with compressed mbox, we follow + @cmd = map { $_ eq '%f' ? ($replaced = $mfolder) : $_ } @cmd; + } push @cmd, $mfolder unless defined($replaced); - $sock //= $self->{sock}; - if ($sock) { # lei(1) client process runs it + if (my $sock = $self->{sock}) { # lei(1) client process runs it send($sock, exec_buf(\@cmd, {}), MSG_EOR); - } else { # oneshot - $self->{"mua.pid.$self.$$"} = spawn(\@cmd); + } elsif ($self->{oneshot}) { + $self->{"pid.$self.$$"}->{spawn(\@cmd)} = \@cmd; + } + if ($self->{lxs} && $self->{au_done}) { # kick wait_startq + syswrite($self->{au_done}, 'q' x ($self->{lxs}->{jobs} // 0)); + } + $self->{opt}->{quiet} = 1; + delete $self->{-progress}; + delete $self->{opt}->{verbose}; +} + +sub send_exec_cmd { # tell script/lei to execute a command + my ($self, $io, $cmd, $env) = @_; + my $sock = $self->{sock} // die 'lei client gone'; + my $fds = [ map { fileno($_) } @$io ]; + $send_cmd->($sock, $fds, exec_buf($cmd, $env), MSG_EOR); +} + +sub poke_mua { # forces terminal MUAs to wake up and hopefully notice new mail + my ($self) = @_; + my $alerts = $self->{opt}->{alert} // return; + while (my $op = shift(@$alerts)) { + if ($op eq ':WINCH') { + # hit the process group that started the MUA + if ($self->{sock}) { + send($self->{sock}, '-WINCH', MSG_EOR); + } elsif ($self->{oneshot}) { + kill('-WINCH', $$); + } + } elsif ($op eq ':bell') { + out($self, "\a"); + } elsif ($op =~ /(?{sock}) { + send($s, exec_buf($cmd, {}), MSG_EOR); + } elsif ($self->{oneshot}) { + $self->{"pid.$self.$$"}->{spawn($cmd)} = $cmd; + } + } else { + err($self, "W: unsupported --alert=$op"); # non-fatal + } } } # caller needs to "-t $self->{1}" to check if tty sub start_pager { my ($self) = @_; - my $env = $self->{env}; - my $fh = popen_rd([qw(git var GIT_PAGER)], $env); + my $fh = popen_rd([qw(git var GIT_PAGER)]); chomp(my $pager = <$fh> // ''); close($fh) or warn "`git var PAGER' error: \$?=$?"; return if $pager eq 'cat' || $pager eq ''; - # TODO TIOCGWINSZ - my $new_env = { LESS => 'FRX', LV => '-c', COLUMNS => 80 }; + my $new_env = { LESS => 'FRX', LV => '-c' }; $new_env->{MORE} = 'FRX' if $^O eq 'freebsd'; pipe(my ($r, $wpager)) or return warn "pipe: $!"; my $rdr = { 0 => $r, 1 => $self->{1}, 2 => $self->{2} }; - my $pgr = [ undef, @$rdr{1, 2}, $$ ]; - if (my $sock = $self->{sock}) { # lei(1) process runs it + my $pgr = [ undef, @$rdr{1, 2} ]; + my $env = $self->{env}; + if ($self->{sock}) { # lei(1) process runs it delete @$new_env{keys %$env}; # only set iff unset - my $fds = [ map { fileno($_) } @$rdr{0..2} ]; - $send_cmd->($sock, $fds, exec_buf([$pager], $new_env), MSG_EOR); + send_exec_cmd($self, [ @$rdr{0..2} ], [$pager], $new_env); + } elsif ($self->{oneshot}) { + my $cmd = [$pager]; + $self->{"pid.$self.$$"}->{spawn($cmd, $new_env, $rdr)} = $cmd; } else { - $pgr->[0] = spawn([$pager], $new_env, $rdr); + die 'BUG: start_pager w/o socket'; } $self->{1} = $wpager; $self->{2} = $wpager if -t $self->{2}; @@ -724,8 +883,6 @@ sub stop_pager { $self->{2} = $pgr->[2]; # do not restore original stdout, just close it so we error out close(delete($self->{1})) if $self->{1}; - my $pid = $pgr->[0]; - dwaitpid($pid, undef, $self->{sock}) if $pid && $pgr->[3] == $$; } sub accept_dispatch { # Listener {post_accept} callback @@ -733,28 +890,31 @@ sub accept_dispatch { # Listener {post_accept} callback $sock->autoflush(1); my $self = bless { sock => $sock }, __PACKAGE__; vec(my $rvec = '', fileno($sock), 1) = 1; - select($rvec, undef, undef, 1) or + select($rvec, undef, undef, 60) or return send($sock, 'timed out waiting to recv FDs', MSG_EOR); - my @fds = $recv_cmd->($sock, my $buf, 4096 * 33); # >MAX_ARG_STRLEN + # (4096 * 33) >MAX_ARG_STRLEN + my @fds = $recv_cmd->($sock, my $buf, 4096 * 33) or return; # EOF if (scalar(@fds) == 4) { - my $i = 0; - for my $rdr (qw(<&= >&= >&= <&=)) { + for my $i (0..3) { my $fd = shift(@fds); - open($self->{$i++}, $rdr, $fd) and next; - send($sock, "open($rdr$fd) (FD=$i): $!", MSG_EOR); + open($self->{$i}, '+<&=', $fd) and next; + send($sock, "open(+<&=$fd) (FD=$i): $!", MSG_EOR); } + } elsif (!defined($fds[0])) { + warn(my $msg = "recv_cmd failed: $!"); + return send($sock, $msg, MSG_EOR); } else { - return send($sock, "recv_cmd failed: $!", MSG_EOR); + return; } $self->{2}->autoflush(1); # keep stdout buffered until x_it|DESTROY # $ENV_STR = join('', map { "\0$_=$ENV{$_}" } keys %ENV); - # $buf = "$$\0$argc\0".join("\0", @ARGV).$ENV_STR."\0\0"; + # $buf = "$argc\0".join("\0", @ARGV).$ENV_STR."\0\0"; substr($buf, -2, 2, '') eq "\0\0" or # s/\0\0\z// return send($sock, 'request command truncated', MSG_EOR); my ($argc, @argv) = split(/\0/, $buf, -1); undef $buf; my %env = map { split(/=/, $_, 2) } splice(@argv, $argc); - if (chdir(delete($self->{3}))) { + if (chdir($self->{3})) { local %ENV = %env; $self->{env} = \%env; eval { dispatch($self, @argv) }; @@ -766,7 +926,15 @@ sub accept_dispatch { # Listener {post_accept} callback sub dclose { my ($self) = @_; - delete $self->{lxs}; # stops LeiXSearch queries + delete $self->{-progress}; + for my $f (@WQ_KEYS) { + my $wq = delete $self->{$f} or next; + if ($wq->wq_kill) { + $wq->wq_close(0, undef, $self); + } elsif ($wq->wq_kill_old) { + $wq->wq_wait_old(undef, $self); + } + } close(delete $self->{1}) if $self->{1}; # may reap_compress $self->close if $self->{sock}; # PublicInbox::DS::close } @@ -800,15 +968,15 @@ sub event_step { sub event_step_init { my ($self) = @_; + return if $self->{-event_init_done}++; if (my $sock = $self->{sock}) { # using DS->EventLoop - $sock->blocking(0); $self->SUPER::new($sock, EPOLLIN|EPOLLET); } } sub noop {} -our $oldset; sub oldset { $oldset } +sub oldset { $oldset } sub dump_and_clear_log { if (defined($errors_log) && -s STDIN && seek(STDIN, 0, SEEK_SET)) { @@ -822,19 +990,29 @@ sub dump_and_clear_log { # lei(1) calls this when it can't connect sub lazy_start { my ($path, $errno, $narg) = @_; - if ($errno == ECONNREFUSED) { - unlink($path) or die "unlink($path): $!"; - } elsif ($errno != ENOENT) { + local ($errors_log, $listener); + ($errors_log) = ($path =~ m!\A(.+?/)[^/]+\z!); + $errors_log .= 'errors.log'; + my $addr = pack_sockaddr_un($path); + my $lk = bless { lock_path => $errors_log }, 'PublicInbox::Lock'; + $lk->lock_acquire; + socket($listener, AF_UNIX, SOCK_SEQPACKET, 0) or die "socket: $!"; + if ($errno == ECONNREFUSED || $errno == ENOENT) { + return if connect($listener, $addr); # another process won + if ($errno == ECONNREFUSED && -S $path) { + unlink($path) or die "unlink($path): $!"; + } + } else { $! = $errno; # allow interpolation to stringify in die die "connect($path): $!"; } umask(077) // die("umask(077): $!"); - socket(my $l, AF_UNIX, SOCK_SEQPACKET, 0) or die "socket: $!"; - bind($l, pack_sockaddr_un($path)) or die "bind($path): $!"; - listen($l, 1024) or die "listen: $!"; + bind($listener, $addr) or die "bind($path): $!"; + listen($listener, 1024) or die "listen: $!"; + $lk->lock_release; + undef $lk; my @st = stat($path) or die "stat($path): $!"; my $dev_ino_expect = pack('dd', $st[0], $st[1]); # dev+ino - pipe(my ($eof_r, $eof_w)) or die "pipe: $!"; local $oldset = PublicInbox::DS::block_signals(); if ($narg == 5) { $send_cmd = PublicInbox::Spawn->can('send_cmd4'); @@ -850,9 +1028,6 @@ sub lazy_start { require PublicInbox::Listener; require PublicInbox::EOFpipe; (-p STDOUT) or die "E: stdout must be a pipe\n"; - local $errors_log; - ($errors_log) = ($path =~ m!\A(.+?/)[^/]+\z!); - $errors_log .= 'errors.log'; open(STDIN, '+>>', $errors_log) or die "open($errors_log): $!"; STDIN->autoflush(1); dump_and_clear_log("from previous daemon process:\n"); @@ -861,20 +1036,21 @@ sub lazy_start { return if $pid; $0 = "lei-daemon $path"; local %PATH2CFG; - local @TO_CLOSE_ATFORK_CHILD = ($l, $eof_w); - $l->blocking(0); - $l = PublicInbox::Listener->new($l, \&accept_dispatch, $l); + $listener->blocking(0); my $exit_code; - local $quit = sub { - $exit_code //= shift; - my $listener = $l or exit($exit_code); - # closing eof_w triggers \&noop wakeup - $eof_w = $l = $path = undef; - $listener->close; # DS::close - PublicInbox::DS->SetLoopTimeout(1000); + my $pil = PublicInbox::Listener->new($listener, \&accept_dispatch); + local $quit = do { + pipe(my ($eof_r, $eof_w)) or die "pipe: $!"; + PublicInbox::EOFpipe->new($eof_r, \&noop, undef); + sub { + $exit_code //= shift; + my $lis = $pil or exit($exit_code); + # closing eof_w triggers \&noop wakeup + $listener = $eof_w = $pil = $path = undef; + $lis->close; # DS::close + PublicInbox::DS->SetLoopTimeout(1000); + }; }; - PublicInbox::EOFpipe->new($eof_r, \&noop, undef); - undef $eof_r; my $sig = { CHLD => \&PublicInbox::DS::enqueue_reap, QUIT => $quit, @@ -904,9 +1080,9 @@ sub lazy_start { warn "$path dev/ino changed, quitting\n"; $path = undef; } - } elsif (defined($path)) { - warn "stat($path): $!, quitting ...\n"; - undef $path; # don't unlink + } elsif (defined($path)) { # ENOENT is common + warn "stat($path): $!, quitting ...\n" if $! != ENOENT; + undef $path; $quit->(); } return 1 if defined($path); @@ -926,34 +1102,35 @@ sub lazy_start { # STDIN was redirected to /dev/null above, closing STDERR and # STDOUT will cause the calling `lei' client process to finish # reading the <$daemon> pipe. - openlog($path, 'pid', 'user'); local $SIG{__WARN__} = sub { - $current_lei ? err($current_lei, @_) : syslog('warning', "@_"); + $current_lei ? err($current_lei, @_) : warn( + strftime('%Y-%m-%dT%H:%M:%SZ', gmtime(time))," $$ ", @_); }; - my $on_destroy = PublicInbox::OnDestroy->new($$, sub { - syslog('crit', "$@") if $@; - }); open STDERR, '>&STDIN' or die "redirect stderr failed: $!"; open STDOUT, '>&STDIN' or die "redirect stdout failed: $!"; # $daemon pipe to `lei' closed, main loop begins: PublicInbox::DS->EventLoop; - @$on_destroy = (); # cancel on_destroy if we get here exit($exit_code // 0); } -# for users w/o Socket::Msghdr +sub busy { 1 } # prevent daemon-shutdown if client is connected + +# for users w/o Socket::Msghdr installed or Inline::C enabled sub oneshot { my ($main_pkg) = @_; my $exit = $main_pkg->can('exit'); # caller may override exit() local $quit = $exit if $exit; local %PATH2CFG; umask(077) // die("umask(077): $!"); - dispatch((bless { + my $self = bless { + oneshot => 1, 0 => *STDIN{GLOB}, 1 => *STDOUT{GLOB}, 2 => *STDERR{GLOB}, env => \%ENV - }, __PACKAGE__), @ARGV); + }, __PACKAGE__; + dispatch($self, @ARGV); + x_it($self, $self->{child_error}) if $self->{child_error}; } # ensures stdout hits the FS before sock disconnects so a client @@ -962,9 +1139,10 @@ sub DESTROY { my ($self) = @_; $self->{1}->autoflush(1) if $self->{1}; stop_pager($self); - if (my $mua_pid = delete $self->{"mua.pid.$self.$$"}) { - waitpid($mua_pid, 0); - } + my $err = $?; + my $oneshot_pids = delete $self->{"pid.$self.$$"} or return; + waitpid($_, 0) for keys %$oneshot_pids; + $? = $err if $err; # preserve ->fail or ->x_it code } 1;