X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FLock.pm;h=0ee2a8bd60bd964a13c0c24f958f43e0ca9a6b5b;hb=23af251dd607c4e75ab1e68063f2c885c48cc035;hp=c0c4c15c2e6cd3616829bc56a47b339436196fb1;hpb=7318712c430bdd15f4fb52cc6c4e10eeb7d0ded2;p=public-inbox.git diff --git a/lib/PublicInbox/Lock.pm b/lib/PublicInbox/Lock.pm index c0c4c15c..0ee2a8bd 100644 --- a/lib/PublicInbox/Lock.pm +++ b/lib/PublicInbox/Lock.pm @@ -8,7 +8,6 @@ use v5.10.1; use Fcntl qw(:flock :DEFAULT); use Carp qw(croak); use PublicInbox::OnDestroy; -use File::Temp (); # we only acquire the flock if creating or reindexing; # PublicInbox::Import already has the lock on its own. @@ -17,7 +16,7 @@ sub lock_acquire { my $lock_path = $self->{lock_path}; croak 'already locked '.($lock_path // '(undef)') if $self->{lockfh}; return unless defined($lock_path); - sysopen(my $lockfh, $lock_path, O_WRONLY|O_CREAT) or + sysopen(my $lockfh, $lock_path, O_RDWR|O_CREAT) or croak "failed to open $lock_path: $!\n"; flock($lockfh, LOCK_EX) or croak "lock $lock_path failed: $!\n"; $self->{lockfh} = $lockfh; @@ -58,10 +57,4 @@ sub lock_for_scope_fast { PublicInbox::OnDestroy->new(@single_pid, \&lock_release_fast, $self); } -sub new_tmp { - my ($cls, $ident) = @_; - my $tmp = File::Temp->new("$ident.lock-XXXXXX", TMPDIR => 1); - bless { lock_path => $tmp->filename, tmp => $tmp }, $cls; -} - 1;