X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FView.pm;h=5f99644f8abaaebf630624c587b1b835dcd52058;hb=803914775816f7de5485fa397bad64e1bd404381;hp=0b96bda81aab47d5362b8bb60d9cb1b3071b7901;hpb=dfaff07b1578d5b32aae3225cb09c6a3f2177896;p=public-inbox.git diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 0b96bda8..5f99644f 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -8,8 +8,6 @@ use strict; use warnings; use URI::Escape qw/uri_escape_utf8/; use Date::Parse qw/str2time/; -use Encode::MIME::Header; -use Plack::Util; use PublicInbox::Hval qw/ascii_html/; use PublicInbox::Linkify; use PublicInbox::MID qw/mid_clean id_compress mid_mime/; @@ -24,14 +22,13 @@ sub th_pfx ($) { $_[0] == 0 ? '' : TCHILD }; # public functions: (unstable) sub msg_html { - my ($ctx, $mime, $footer) = @_; + my ($ctx, $mime) = @_; my $hdr = $mime->header_obj; my $tip = _msg_html_prepare($hdr, $ctx); - PublicInbox::WwwStream->new($ctx, sub { + PublicInbox::WwwStream->response($ctx, 200, sub { my ($nr, undef) = @_; if ($nr == 1) { - $tip . multipart_text_as_html($mime, '') . - '
' + $tip . multipart_text_as_html($mime, '') . '
' } elsif ($nr == 2) { # fake an EOF if generating the footer fails; # we want to at least show the message if something @@ -49,25 +46,48 @@ sub msg_html { # /$INBOX/$MESSAGE_ID/#R sub msg_reply { my ($ctx, $hdr) = @_; - my $se_url = 'https://git-htmldocs.bogomips.org/git-send-email.html'; + my $se_url = + 'https://kernel.org/pub/software/scm/git/docs/git-send-email.html'; + my $p_url = + 'https://en.wikipedia.org/wiki/Posting_style#Interleaved_style'; + + my $info = ''; + if (my $url = $ctx->{-inbox}->{infourl}) { + $url = PublicInbox::Hval::prurl($ctx->{env}, $url); + $info = qq(\n List information: $url\n); + } my ($arg, $link) = mailto_arg_link($hdr); push @$arg, '/path/to/YOUR_REPLY'; + $arg = join(" \\\n ", '', @$arg); + <
Reply instructions:
+
+You may reply publically to this message via plain-text email
+using any one of the following methods:
+
+* Save the following mbox file, import it into your mail client,
+  and reply-to-all from there: mbox
+
+  Avoid top-posting and favor interleaved quoting:
+  $p_url
+$info
+* Reply to all the recipients using the --to, --cc,
+  and --in-reply-to switches of git-send-email(1):
 
-	"".
-	"You may reply publically to this message via\n".
-	"plain-text email using any one of the following methods:\n\n" .
-	"* Save the following mbox file, import it into your mail client,\n" .
-	"  and reply-to-all from there: mbox\n\n" .
-	"* Reply to all the recipients using the --to, --cc,\n" .
-	"  and --in-reply-to switches of git-send-email(1):\n\n" .
-	"  git send-email \\\n    " .
-	join(" \\\n    ", @$arg ). "\n\n" .
-	qq(  $se_url\n\n) .
-	"* If your mail client supports setting the In-Reply-To" .
-	" header\n  via mailto: links, try the " .
-	qq(mailto: link\n) .
-	'
'; + git send-email$arg + + $se_url + +* If your mail client supports setting the In-Reply-To header + via mailto: links, try the mailto: link +EOF } sub in_reply_to { @@ -103,46 +123,63 @@ sub index_entry { my $subj = $hdr->header('Subject'); my $mid_raw = mid_clean(mid_mime($mime)); - my $id = id_compress($mid_raw); + my $id = id_compress($mid_raw, 1); my $id_m = 'm'.$id; my $mid = PublicInbox::Hval->new_msgid($mid_raw); my $root_anchor = $ctx->{root_anchor} || ''; my $irt = in_reply_to($hdr); - my $rv = ''.ascii_html($subj).''; - $rv = "$rv" if $root_anchor eq $id_m; - $rv .= "\n"; + my $rv = "* "; + $subj = ''.ascii_html($subj).''; + $subj = "$subj" if $root_anchor eq $id_m; + $rv .= $subj . "\n"; $rv .= _th_index_lite($mid_raw, $irt, $id, $ctx); my @tocc; foreach my $f (qw(To Cc)) { my $dst = _hdr_names($hdr, $f); push @tocc, "$f: $dst" if $dst ne ''; } - my $mapping = $ctx->{mapping}; $rv .= "From: "._hdr_names($hdr, 'From').' @ '._msg_date($hdr)." UTC"; my $upfx = $ctx->{-upfx}; - $rv .= qq{ (permalink / }; - $rv .= qq{raw)\n}; + my $mhref = $upfx . $mid->as_href . '/'; + $rv .= qq{ (permalink / }; + $rv .= qq{raw)\n}; $rv .= ' '.join('; +', @tocc) . "\n" if @tocc; + + my $mapping = $ctx->{mapping}; if (!$mapping && $irt) { - $rv .= qq(In-Reply-To: <$irt>\n) + my $mirt = PublicInbox::Hval->new_msgid($irt); + my $href = $upfx . $mirt->as_href . '/'; + my $html = $mirt->as_html; + $rv .= qq(In-Reply-To: <$html>\n) } $rv .= "\n"; # scan through all parts, looking for displayable text - my $href = $mid->as_href; - my $mhref = $ctx->{-upfx}.$href.'/'; msg_iter($mime, sub { $rv .= add_text_body($mhref, $_[0]) }); # add the footer $rv .= "\n^ ". "permalink" . - " / raw" . - " / reply"; + " raw" . + " reply"; if (my $pct = $ctx->{pct}) { # used by SearchView.pm - $rv .= " [relevance $pct->{$mid_raw}%]"; + $rv .= "\t[relevance $pct->{$mid_raw}%]"; + } elsif ($mapping) { + my $threaded = 'threaded'; + my $flat = 'flat'; + my $end = ''; + if ($ctx->{flat}) { + $flat = "$flat"; + } else { + $threaded = "$threaded"; + } + $rv .= "\t[$flat"; + $rv .= "|$threaded]"; + $rv .= " $ctx->{s_nr}"; } + $rv .= $more ? "\n\n" : "\n"; } @@ -150,7 +187,7 @@ sub pad_link ($$;$) { my ($mid, $level, $s) = @_; $s ||= '...'; my $id = id_compress($mid, 1); - (' 'x19).indent_for($level).th_pfx($level)."($s)\n"; + (' 'x19).indent_for($level).th_pfx($level)."($s)\n"; } sub _th_index_lite { @@ -186,7 +223,8 @@ sub _th_index_lite { my $s_c = nr_to_s($nr_c, 'reply', 'replies'); my $this = $map->[1]; $this =~ s!\n\z!\n!s; - $this =~ s! !!s; # no point in duplicating subject + $this =~ s! !!s; # no point in duplicating subject + $this =~ s!]+>([^<]+)!$1!s; # no point linking to self $rv .= "@ $this"; my $node = $map->[2]; if (my $child = $node->child) { @@ -210,7 +248,7 @@ sub _th_index_lite { $rv .= $pad . $mapping->{$nn->messageid}->[1]; } } - $rv .= "_ $s_s, $s_c\n"; + $rv .= $pad ."$s_s, $s_c; $ctx->{s_nr}\n"; } sub walk_thread { @@ -237,6 +275,50 @@ sub pre_thread { skel_dump($ctx, $level, $node); } +sub thread_index_entry { + my ($ctx, $level, $mime) = @_; + my ($beg, $end) = thread_adj_level($ctx, $level); + $beg . '
' . index_entry($mime, $ctx, 0) . '
' . $end; +} + +sub stream_thread ($$) { + my ($th, $ctx) = @_; + my $inbox = $ctx->{-inbox}; + my $mime; + my @q = map { (0, $_) } $th->rootset; + my $level; + while (@q) { + $level = shift @q; + my $node = shift @q or next; + unshift @q, $level+1, $node->child, $level, $node->next; + $mime = $inbox->msg_by_mid($node->messageid) and last; + } + return missing_thread($ctx) unless $mime; + + $mime = Email::MIME->new($mime); + $ctx->{-title_html} = ascii_html($mime->header('Subject')); + $ctx->{-html_tip} = thread_index_entry($ctx, $level, $mime); + PublicInbox::WwwStream->response($ctx, 200, sub { + return unless $ctx; + while (@q) { + $level = shift @q; + my $node = shift @q or next; + unshift @q, $level+1, $node->child, $level, $node->next; + my $mid = $node->messageid; + if ($mime = $inbox->msg_by_mid($mid)) { + $mime = Email::MIME->new($mime); + return thread_index_entry($ctx, $level, $mime); + } else { + return ghost_index_entry($ctx, $level, $mid); + } + } + my $ret = join('', thread_adj_level($ctx, 0)); + $ret .= ${$ctx->{dst}}; # skel + $ctx = undef; + $ret; + }); +} + sub thread_html { my ($ctx) = @_; my $mid = $ctx->{mid}; @@ -244,34 +326,41 @@ sub thread_html { my $msgs = load_results($sres); my $nr = $sres->{total}; return missing_thread($ctx) if $nr == 0; - my $skel = '
';
+	my $skel = '
';
 	$skel .= $nr == 1 ? 'only message in thread' : 'end of thread';
-	$skel .= ", back to index";
-	$skel .= "\n$nr+ messages in thread: (download: ";
-	$skel .= "mbox.gz";
+	$skel .= ", back to index\n\n";
+	$skel .= "Thread overview: ";
+	$skel .= $nr == 1 ? '(only message)' : "$nr+ messages";
+	$skel .= " (download: mbox.gz";
 	$skel .= " / follow: Atom feed)\n";
+	$skel .= "-- links below jump to the message on this page --\n";
+	$ctx->{-upfx} = '../../';
 	$ctx->{cur_level} = 0;
 	$ctx->{dst} = \$skel;
-	$ctx->{mapping} = {}; # mid -> [ reply count, from@date, node ];
 	$ctx->{prev_attr} = '';
 	$ctx->{prev_level} = 0;
 	$ctx->{root_anchor} = anchor_for($mid);
 	$ctx->{seen} = {};
+	$ctx->{mapping} = {};
+	$ctx->{s_nr} = "$nr+ messages in thread";
 
-	walk_thread(thread_results($msgs), $ctx, *pre_thread);
+	my $th = thread_results($msgs);
+	walk_thread($th, $ctx, *pre_thread);
+	$skel .= '
'; + return stream_thread($th, $ctx) unless $ctx->{flat}; - # lazy load the full message from mini_mime: + # flat display: lazy load the full message from mini_mime: my $inbox = $ctx->{-inbox}; my $mime; while ($mime = shift @$msgs) { $mime = $inbox->msg_by_mid(mid_clean(mid_mime($mime))) and last; } + return missing_thread($ctx) unless $mime; $mime = Email::MIME->new($mime); - $ctx->{-upfx} = '../../'; $ctx->{-title_html} = ascii_html($mime->header('Subject')); $ctx->{-html_tip} = '
'.index_entry($mime, $ctx, scalar @$msgs);
 	$mime = undef;
-	my $body = PublicInbox::WwwStream->new($ctx, sub {
+	PublicInbox::WwwStream->response($ctx, 200, sub {
 		return unless $msgs;
 		while ($mime = shift @$msgs) {
 			$mid = mid_clean(mid_mime($mime));
@@ -282,9 +371,8 @@ sub thread_html {
 			return index_entry($mime, $ctx, scalar @$msgs);
 		}
 		$msgs = undef;
-		$skel .= '
'; + '
'.$skel; }); - [ 200, ['Content-Type', 'text/html; charset=UTF-8'], $body ]; } sub multipart_text_as_html { @@ -434,11 +522,12 @@ sub thread_skel { my $mid = mid_clean($hdr->header_raw('Message-ID')); my $sres = $srch->get_thread($mid); my $nr = $sres->{total}; - my $expand = qq(expand ) . + my $expand = qq(expand ) . qq(/ mbox.gz ) . qq(/ Atom feed); my $parent = in_reply_to($hdr); + $$dst .= "\nThread overview: "; if ($nr <= 1) { if (defined $parent) { $$dst .= "($expand)\n "; @@ -470,7 +559,7 @@ sub _parent_headers { my $irt = in_reply_to($hdr); if (defined $irt) { - my $v = PublicInbox::Hval->new_msgid($irt, 1); + my $v = PublicInbox::Hval->new_msgid($irt); my $html = $v->as_html; my $href = $v->as_href; $rv .= "In-Reply-To: <"; @@ -556,21 +645,35 @@ sub html_footer { if ($idx && $srch) { $idx .= "\n"; thread_skel(\$idx, $ctx, $hdr, $tpfx); - my $p = $ctx->{parent_msg}; - my $next = $ctx->{next_msg}; - if ($p) { - $p = PublicInbox::Hval->new_msgid($p); - $p = $p->as_href; - $irt = "parent "; - } else { - $irt = ' ' x length('parent '); + my ($next, $prev); + my $parent = ' '; + $next = $prev = ' '; + + if (my $n = $ctx->{next_msg}) { + $n = PublicInbox::Hval->new_msgid($n)->as_href; + $next = "next"; } - if ($next) { - my $n = PublicInbox::Hval->new_msgid($next)->as_href; - $irt .= "next "; - } else { - $irt .= ' ' x length('next '); + my $u; + my $par = $ctx->{parent_msg}; + if ($par) { + $u = PublicInbox::Hval->new_msgid($par)->as_href; + $u = "$upfx$u/"; + } + if (my $p = $ctx->{prev_msg}) { + $prev = PublicInbox::Hval->new_msgid($p)->as_href; + if ($p && $par && $p eq $par) { + $prev = "prev parent'; + $parent = ''; + } else { + $prev = "prev'; + $parent = " parent" if $u; + } + } elsif ($u) { # unlikely + $parent = " parent"; } + $irt = "$next $prev$parent "; } else { $irt = ''; } @@ -580,7 +683,7 @@ sub html_footer { } sub linkify_ref_nosrch { - my $v = PublicInbox::Hval->new_msgid($_[0], 1); + my $v = PublicInbox::Hval->new_msgid($_[0]); my $html = $v->as_html; my $href = $v->as_href; "<$html>"; @@ -655,18 +758,17 @@ sub _skel_header { if ($attr ne $ctx->{prev_attr} || $ctx->{prev_level} > $level) { $ctx->{prev_attr} = $attr; - } else { - $attr = ''; } $ctx->{prev_level} = $level; if ($cur) { if ($cur eq $mid) { delete $ctx->{cur}; - $$dst .= $d; - $$dst .= "". + $$dst .= "$d". "$attr [this message]\n"; return; + } else { + $ctx->{prev_msg} = $mid; } } else { $ctx->{next_msg} ||= $mid; @@ -748,102 +850,163 @@ sub _tryload_ghost ($$) { } # accumulate recent topics if search is supported -# returns 1 if done, undef if not -sub add_topic { +# returns 200 if done, 404 if not +sub acc_topic { my ($ctx, $level, $node) = @_; my $srch = $ctx->{srch}; my $mid = $node->messageid; my $x = $node->message || _tryload_ghost($srch, $mid); my ($subj, $ts); + my $topic; if ($x) { $x = $x->header_obj; - $subj = $x->header('Subject'); + $subj = $x->header('Subject') || ''; $subj = $srch->subject_normalized($subj); $ts = $x->header('X-PI-TS'); - } else { # ghost message, do not bump level - $ts = -666; - $subj = "<$mid>"; - } - if (++$ctx->{subjs}->{$subj} == 1) { - push @{$ctx->{order}}, [ $level, $subj ]; - } - my $exist = $ctx->{latest}->{$subj}; - if (!$exist || $exist->[1] < $ts) { - $ctx->{latest}->{$subj} = [ $mid, $ts ]; + if ($level == 0) { + $topic = [ $ts, 1, { $subj => $mid }, $subj ]; + $ctx->{-cur_topic} = $topic; + push @{$ctx->{order}}, $topic; + return; + } + + $topic = $ctx->{-cur_topic}; # should never be undef + $topic->[0] = $ts if $ts > $topic->[0]; + $topic->[1]++; + my $seen = $topic->[2]; + if (scalar(@$topic) == 3) { # parent was a ghost + push @$topic, $subj; + } elsif (!$seen->{$subj}) { + push @$topic, $level, $subj; + } + $seen->{$subj} = $mid; # latest for subject + } else { # ghost message + return if $level != 0; # ignore child ghosts + $topic = [ -666, 0, {} ]; + $ctx->{-cur_topic} = $topic; + push @{$ctx->{order}}, $topic; } } -sub emit_topics { +sub dump_topics { my ($ctx) = @_; - my $order = $ctx->{order}; - my $subjs = $ctx->{subjs}; - my $latest = $ctx->{latest}; - my $fh = $ctx->{fh}; - return $fh->write("\n[No topics in range]") unless scalar @$order; - my $pfx; - my $prev = 0; - my $prev_attr = ''; - my $cur; - my @recent; - while (defined(my $info = shift @$order)) { - my ($level, $subj) = @$info; - my $n = delete $subjs->{$subj}; - my ($mid, $ts) = @{delete $latest->{$subj}}; - $mid = PublicInbox::Hval->new_msgid($mid)->as_href; - $pfx = indent_for($level); - my $nl = $level == $prev ? "\n" : ''; - if ($nl && $cur) { - push @recent, $cur; - $cur = undef; - } - $cur ||= [ $ts, '' ]; - $cur->[0] = $ts if $ts > $cur->[0]; - $cur->[1] .= $nl . $pfx . th_pfx($level); - if ($ts == -666) { # ghost - $cur->[1] .= ghost_parent('', $mid) . "\n"; - next; # child will have mbox / atom link - } - - $subj = PublicInbox::Hval->new($subj)->as_html; - $cur->[1] .= "$subj\n"; + my $order = delete $ctx->{order}; # [ ts, subj1, subj2, subj3, ... ] + if (!@$order) { + $ctx->{-html_tip} = '
[No topics in range]
'; + return 404; + } + + my @out; + + # sort by recency, this allows new posts to "bump" old topics... + foreach my $topic (sort { $b->[0] <=> $a->[0] } @$order) { + my ($ts, $n, $seen, $top, @ex) = @$topic; + @$topic = (); + next unless defined $top; # ghost topic + my $mid = delete $seen->{$top}; + my $href = PublicInbox::Hval->new_msgid($mid)->as_href; + $top = PublicInbox::Hval->new($top)->as_html; $ts = fmt_ts($ts); - my $attr = " $ts UTC"; # $n isn't the total number of posts on the topic, # just the number of posts in the current results window - $n = $n == 1 ? '' : " ($n+ messages)"; - - if ($level == 0 || $attr ne $prev_attr) { - my $mbox = qq(mbox.gz); - my $atom = qq(Atom); - $pfx .= INDENT if $level > 0; - $cur->[1] .= $pfx . $attr . $n . " - $mbox / $atom\n"; - $prev_attr = $attr; + my $anchor; + if ($n == 1) { + $n = ''; + $anchor = '#u'; # top of only message + } else { + $n = " ($n+ messages)"; + $anchor = '#t'; # thread skeleton + } + + my $mbox = qq(mbox.gz); + my $atom = qq(Atom); + my $s = "$top\n" . + " $ts UTC $n - $mbox / $atom\n"; + for (my $i = 0; $i < scalar(@ex); $i += 2) { + my $level = $ex[$i]; + my $sub = $ex[$i + 1]; + $mid = delete $seen->{$sub}; + $sub = PublicInbox::Hval->new($sub)->as_html; + $href = PublicInbox::Hval->new_msgid($mid)->as_href; + $s .= indent_for($level) . TCHILD; + $s .= "$sub\n"; + } + push @out, $s; + } + $ctx->{-html_tip} = '
' . join("\n", @out) . '
'; + 200; +} + +sub index_nav { # callback for WwwStream + my (undef, $ctx) = @_; + delete $ctx->{qp} or return; + my ($next, $prev); + $next = $prev = ' '; + my $latest = ''; + + my $next_o = $ctx->{-next_o}; + if ($next_o) { + $next = qq!next!; + } + if (my $cur_o = $ctx->{-cur_o}) { + $latest = qq! latest!; + + my $o = $cur_o - ($next_o - $cur_o); + if ($o > 0) { + $prev = qq!prev!; + } elsif ($o == 0) { + $prev = qq!prev!; } } - push @recent, $cur if $cur; - @recent = map { $_->[1] } sort { $b->[0] <=> $a->[0] } @recent; - $fh->write(join('', @recent) . ''); + "
page: $next $prev$latest
"; } -sub emit_index_topics { +sub index_topics { my ($ctx) = @_; - my ($off) = (($ctx->{cgi}->param('o') || '0') =~ /(\d+)/); + my ($off) = (($ctx->{qp}->{o} || '0') =~ /(\d+)/); + my $opts = { offset => $off, limit => 200 }; + $ctx->{order} = []; - $ctx->{subjs} = {}; - $ctx->{latest} = {}; - my $max = 25; - my %opts = ( offset => $off, limit => $max * 4 ); - while (scalar @{$ctx->{order}} < $max) { - my $sres = $ctx->{srch}->query('', \%opts); - my $nr = scalar @{$sres->{msgs}} or last; + my $sres = $ctx->{srch}->query('', $opts); + my $nr = scalar @{$sres->{msgs}}; + if ($nr) { $sres = load_results($sres); - walk_thread(thread_results($sres), $ctx, *add_topic); - $opts{offset} += $nr; + walk_thread(thread_results($sres), $ctx, *acc_topic); + } + $ctx->{-next_o} = $off+ $nr; + $ctx->{-cur_o} = $off; + PublicInbox::WwwStream->response($ctx, dump_topics($ctx), *index_nav); +} + +sub thread_adj_level { + my ($ctx, $level) = @_; + + my $max = $ctx->{cur_level}; + if ($level <= 0) { + return ('', '') if $max == 0; # flat output + + # reset existing lists + my $beg = $max > 1 ? ('' x ($max - 1)) : ''; + $ctx->{cur_level} = 0; + ("$beg", ''); + } elsif ($level == $max) { # continue existing list + qw(
  • ); + } elsif ($level < $max) { + my $beg = $max > 1 ? ('' x ($max - $level)) : ''; + $ctx->{cur_level} = $level; + ("$beg
  • ", '
  • '); + } else { # ($level > $max) # start a new level + $ctx->{cur_level} = $level; + my $beg = ($max ? '
  • ' : '') . '
    • '; + ($beg, '
    • '); } +} - emit_topics($ctx); - $opts{offset}; +sub ghost_index_entry { + my ($ctx, $level, $mid) = @_; + my ($beg, $end) = thread_adj_level($ctx, $level); + $beg . '
      '. ghost_parent($ctx->{-upfx}, $mid) . '
      ' . $end; } 1;