X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=lib%2FPublicInbox%2FViewVCS.pm;h=d8f6742f01b7f284897a6ae6efcd3d773465ddd1;hb=3e29a9a80e6f940e8b8f7f6b92318793d5d30b90;hp=6b6b94fbe378620679186d065272bb04953eaf34;hpb=a99bf0f90d6d59b8c81876651aaabcd2fd1c4094;p=public-inbox.git diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 6b6b94fb..d8f6742f 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -25,7 +25,8 @@ use PublicInbox::ViewDiff qw(flush_diff uri_escape_path); use PublicInbox::View; use PublicInbox::Eml; use Text::Wrap qw(wrap); -use PublicInbox::Hval qw(ascii_html to_filename); +use PublicInbox::Hval qw(ascii_html to_filename prurl); +use POSIX qw(strftime); my $hl = eval { require PublicInbox::HlMod; PublicInbox::HlMod->new; @@ -99,7 +100,7 @@ sub stream_large_blob ($$) { my $cmd = ['git', "--git-dir=$git->{git_dir}", 'cat-file', $type, $oid]; my $qsp = PublicInbox::Qspawn->new($cmd); my $env = $ctx->{env}; - $env->{'qspawn.wcb'} = delete $ctx->{-wcb}; + $env->{'qspawn.wcb'} = $ctx->{-wcb}; $qsp->psgi_return($env, undef, \&stream_blob_parse_hdr, $ctx); } @@ -152,6 +153,25 @@ sub show_commit_start { # ->psgi_qx callback } } +sub ibx_url_for { + my ($ctx) = @_; + $ctx->{ibx} and return; # just fall back to $upfx + $ctx->{git} or return; # /$CODEREPO/$OID/s/ to (eidx|ibx) + if (my $ALL = $ctx->{www}->{pi_cfg}->ALL) { + $ALL->base_url // $ALL->base_url($ctx->{env}); + } elsif (my $ibxs = $ctx->{git}->{-ibxs}) { + for my $ibx (@$ibxs) { + if ($ibx->isrch) { + return defined($ibx->{url}) ? + prurl($ctx->{env}, $ibx->{url}) : + "../../../$ibx->{name}/"; + } + } + } else { + undef; + } +} + sub cmt_finalize { my ($ctx) = @_; $ctx->{-linkify} //= PublicInbox::Linkify->new; @@ -189,29 +209,27 @@ href="$f.patch">patch)\n parent $P->[0]}; $x = ' (root commit)'; } PublicInbox::WwwStream::html_init($ctx); - $ctx->zmore(<zfh; + print $zfh < commit $H$x - tree $T + tree $T author $au committer $co $s EOM - $ctx->zmore("\n", $ctx->{-linkify}->to_html($bdy)) if length($bdy); + print $zfh "\n", $ctx->{-linkify}->to_html($bdy) if length($bdy); $bdy = ''; open my $fh, '<:utf8', "$ctx->{-tmp}/p" or die "open $ctx->{-tmp}/p: $!"; if (-s $fh > $MAX_SIZE) { - $ctx->zmore("---\n patch is too large to show\n"); + print $zfh "---\n patch is too large to show\n"; } else { # prepare flush_diff: read($fh, $x, -s _); - $ctx->{obuf} = \$bdy; $ctx->{-apfx} = $ctx->{-spfx} = $upfx; $x =~ s/\r?\n/\n/gs; $ctx->{-anchors} = {} if $x =~ /^diff --git /sm; flush_diff($ctx, \$x); # undefs $x - $ctx->zmore($bdy); - undef $bdy; # TODO: should there be another textarea which attempts to # search for the exact email which was applied to make this # commit? @@ -229,12 +247,21 @@ EOM $q = wrap('', '', $q); my $rows = ($q =~ tr/\n/\n/) + 1; $q = ascii_html($q); - $ctx->zmore(<
find related emails, including ancestors/descendants/conflicts
 
-\t(help)
+\t(help) EOM } } @@ -255,10 +282,7 @@ possible to have multiple root commits when merging independent histories. Every commit references one top-level tree object. EOM - $x = $ctx->zflush($x, $ctx->_html_end); - my $res_hdr = delete $ctx->{-res_hdr}; - push @$res_hdr, 'Content-Length', length($x); - delete($ctx->{env}->{'qspawn.wcb'})->([200, $res_hdr, [$x]]); + delete($ctx->{-wcb})->($ctx->html_done($x)); } sub stream_patch_parse_hdr { # {parse_hdr} for Qspawn @@ -288,7 +312,7 @@ sub show_patch ($$) { qw(format-patch -1 --stdout -C), "--signature=git format-patch -1 --stdout -C $oid", $oid); my $qsp = PublicInbox::Qspawn->new(\@cmd); - $ctx->{env}->{'qspawn.wcb'} = delete $ctx->{-wcb}; + $ctx->{env}->{'qspawn.wcb'} = $ctx->{-wcb}; $ctx->{patch_oid} = $oid; $qsp->psgi_return($ctx->{env}, undef, \&stream_patch_parse_hdr, $ctx); } @@ -309,12 +333,12 @@ sub show_commit ($$) { my $e = { GIT_DIR => $git->{git_dir} }; my $qsp = PublicInbox::Qspawn->new($cmd, $e, { -C => "$ctx->{-tmp}" }); $qsp->{qsp_err} = \($ctx->{-qsp_err} = ''); - $ctx->{env}->{'qspawn.wcb'} = delete $ctx->{-wcb}; + $ctx->{env}->{'qspawn.wcb'} = $ctx->{-wcb}; $ctx->{git} = $git; $qsp->psgi_qx($ctx->{env}, undef, \&show_commit_start, $ctx); } -sub show_other ($$) { +sub show_other ($$) { # just in case... my ($ctx, $res) = @_; my ($git, $oid, $type, $size) = @$res; $size > $MAX_SIZE and return html_page($ctx, 200, @@ -338,9 +362,13 @@ sub show_tree_result ($$) { my $pfx = $qp->{b}; $$bref = "
tree $ctx->{tree_oid}";
 	if (defined $pfx) {
-		my $x = ascii_html($pfx);
-		$pfx .= '/';
-		$$bref .= qq(  path: $x\n);
+		if ($pfx eq '') {
+			$$bref .= "  (root)\n";
+		} else {
+			my $x = ascii_html($pfx);
+			$pfx .= '/';
+			$$bref .= qq(  path: $x\n);
+		}
 	} else {
 		$pfx = '';
 		$$bref .= qq[  (path unknown)\n];
@@ -398,6 +426,42 @@ sub show_tree ($$) {
 	$qsp->psgi_qx($ctx->{env}, undef, \&show_tree_result, $ctx);
 }
 
+# returns seconds offset from git TZ offset
+sub tz_adj ($) {
+	my ($tz) = @_; # e.g "-0700"
+	$tz = int($tz);
+	my $mm = $tz < 0 ? -$tz : $tz;
+	$mm = int($mm / 100) * 60 + ($mm % 100);
+	$mm = $tz < 0 ? -$mm : $mm;
+	($mm * 60);
+}
+
+sub show_tag_result { # git->cat_async callback
+	my ($bref, $oid, $type, $size, $ctx) = @_;
+	utf8::decode($$bref);
+	my $l = PublicInbox::Linkify->new;
+	$$bref = $l->to_html($$bref);
+	$$bref =~ s!^object ([a-f0-9]+)!object $1!;
+
+	$$bref =~ s/^(tagger .*> )([0-9]+) ([\-+]?[0-9]+)/$1.strftime(
+		'%Y-%m-%d %H:%M:%S', gmtime($2 + tz_adj($3)))." $3"/sme;
+	# TODO: download link
+	html_page($ctx, 200, '
', $$bref, '
', dbg_log($ctx)); +} + +sub show_tag ($$) { + my ($ctx, $res) = @_; + my ($git, $oid) = @$res; + $ctx->{git} = $git; + if ($ctx->{env}->{'pi-httpd.async'}) { + ibx_async_cat($ctx, $oid, \&show_tag_result, $ctx); + } else { # synchronous (generic PSGI) + $git->cat_async($oid, \&show_tag_result, $ctx); + $git->cat_async_wait; + } +} + # user_cb for SolverGit, called as: user_cb->($result_or_error, $uarg) sub solve_result { my ($res, $ctx) = @_; @@ -408,6 +472,7 @@ sub solve_result { my ($git, $oid, $type, $size, $di) = @$res; return show_commit($ctx, $res) if $type eq 'commit'; return show_tree($ctx, $res) if $type eq 'tree'; + return show_tag($ctx, $res) if $type eq 'tag'; return show_other($ctx, $res) if $type ne 'blob'; my $path = to_filename($di->{path_b} // $hints->{path_b} // 'blob'); my $raw_link = "(raw)"; @@ -415,14 +480,25 @@ sub solve_result { return stream_large_blob($ctx, $res) if defined $ctx->{fn}; return html_page($ctx, 200, <Too big to show, download available -"$oid $type $size bytes $raw_link
+blob $oid $size bytes $raw_link EOM } + @{$ctx->{-paths}} = ($path, $raw_link); + bless $ctx, 'PublicInbox::WwwStream'; # for DESTROY + $ctx->{git} = $git; + if ($ctx->{env}->{'pi-httpd.async'}) { + ibx_async_cat($ctx, $oid, \&show_blob, $ctx); + } else { # synchronous + $git->cat_async($oid, \&show_blob, $ctx); + $git->cat_async_wait; + } +} - my $blob = $git->cat_file($oid); - if (!$blob) { # WTF? +sub show_blob { # git->cat_async callback + my ($blob, $oid, $type, $size, $ctx) = @_; + if (!$blob) { my $e = "Failed to retrieve generated blob ($oid)"; - warn "$e ($git->{git_dir})"; + warn "$e ($ctx->{git}->{git_dir}) type=$type"; return html_page($ctx, 500, "
$e
".dbg_log($ctx)) } @@ -433,8 +509,9 @@ EOM return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]); } + my ($path, $raw_link) = @{delete $ctx->{-paths}}; $bin and return html_page($ctx, 200, - "
$oid $type $size bytes (binary)" .
+				"
blob $oid $size bytes (binary)" .
 				" $raw_link
".dbg_log($ctx)); # TODO: detect + convert to ensure validity @@ -450,14 +527,14 @@ EOM $$blob = ascii_html($$blob); } - my $x = "
$oid $type $size bytes $raw_link
" . + # using some of the same CSS class names and ids as cgit + my $x = "
blob $oid $size bytes $raw_link
" . "
". "
";
+	# scratchpad in this loop is faster here than `printf $zfh':
 	$x .= sprintf("% ${pad}u\n", $_) for (1..$nl);
 	$x .= '
 
'. # pad for non-CSS users ""; - - # using some of the same CSS class names and ids as cgit html_page($ctx, 200, $x, $ctx->{-linkify}->linkify_2($$blob), '
'.dbg_log($ctx)); } @@ -477,6 +554,7 @@ sub show ($$;$) { open $ctx->{lh}, '+>>', "$ctx->{-tmp}/solve.log" or die "open: $!"; my $solver = PublicInbox::SolverGit->new($ctx->{ibx}, \&solve_result, $ctx); + $solver->{gits} //= [ $ctx->{git} ]; $solver->{tmp} = $ctx->{-tmp}; # share tmpdir # PSGI server will call this immediately and give us a callback (-wcb) sub {