X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=script%2Fpublic-inbox-learn;h=c4c4d4b95882cd45d36896519ad51381718d2f11;hb=96a8b8832d791d53e05f235b5bc2492daab5f60a;hp=bfbf023363295f15ce95d40bd2de79a3294a2c76;hpb=1cf14fe543ad6259003cdd1995a1c83a7a70b535;p=public-inbox.git diff --git a/script/public-inbox-learn b/script/public-inbox-learn index bfbf0233..c4c4d4b9 100755 --- a/script/public-inbox-learn +++ b/script/public-inbox-learn @@ -1,6 +1,6 @@ #!/usr/bin/perl -w -# Copyright (C) 2014-2015 all contributors -# License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt) +# Copyright (C) 2014-2019 all contributors +# License: AGPL-3.0+ # # Used for training spam (via SpamAssassin) and removing messages from a # public-inbox @@ -8,23 +8,34 @@ my $usage = "$0 (spam|ham) < /path/to/message"; use strict; use warnings; use PublicInbox::Config; -use PublicInbox::Git; -use PublicInbox::Import; -use Email::MIME; -use Email::MIME::ContentType; -$Email::MIME::ContentType::STRICT_PARAMS = 0; # user input is imperfect +use PublicInbox::InboxWritable; +use PublicInbox::MIME; use PublicInbox::Address; -use IPC::Run qw/run/; +use PublicInbox::Spamcheck::Spamc; my $train = shift or die "usage: $usage\n"; -if ($train !~ /\A(?:ham|spam)\z/) { +if ($train !~ /\A(?:ham|spam|rm)\z/) { die "`$train' not recognized.\nusage: $usage\n"; } +my $spamc = PublicInbox::Spamcheck::Spamc->new; my $pi_config = PublicInbox::Config->new; -my $mime = Email::MIME->new(eval { +my $err; +my $mime = PublicInbox::MIME->new(eval { local $/; my $data = scalar ; - $data =~ s/\AFrom [^\r\n]*\r?\n//s; + $data =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s; + + if ($train ne 'rm') { + eval { + if ($train eq 'ham') { + $spamc->hamlearn(\$data); + } elsif ($train eq 'spam') { + $spamc->spamlearn(\$data); + } + die "spamc failed with: $?\n" if $?; + }; + $err = $@; + } $data }); @@ -37,33 +48,34 @@ foreach my $h (qw(Cc To)) { } } -if ($train eq "ham") { - require PublicInbox::MDA; - require PublicInbox::Filter; - PublicInbox::Filter->run($mime); +if ($train eq 'spam') { + $pi_config->each_inbox(sub { + my ($ibx) = @_; + $ibx = PublicInbox::InboxWritable->new($ibx); + my $im = $ibx->importer(0); + $im->remove($mime, 'spam'); + $im->done; + }); } -my $err = 0; -my @output = qw(> /dev/null > /dev/null); +require PublicInbox::MDA if $train eq "ham"; # n.b. message may be cross-posted to multiple public-inboxes foreach my $recipient (keys %dests) { my $dst = $pi_config->lookup($recipient) or next; - my $git_dir = $dst->{mainrepo} or next; - my ($out, $err) = ("", ""); - my $git = PublicInbox::Git->new($git_dir); # We do not touch GIT_COMMITTER_* env here so we can track # who trained the message. - my $name = $ENV{GIT_COMMITTER_NAME} || $dst->{inbox}; - my $email = $ENV{GIT_COMMITTER_EMAIL} || $recipient; - my $im = PublicInbox::Import->new($git, $name, $email); + $dst->{name} = $ENV{GIT_COMMITTER_NAME} || $dst->{name}; + $dst->{-primary_address} = $ENV{GIT_COMMITTER_EMAIL} || $recipient; + $dst = PublicInbox::InboxWritable->new($dst); + my $im = $dst->importer(0); - if ($train eq "spam") { + if ($train eq "spam" || $train eq "rm") { # This needs to be idempotent, as my inotify trainer # may train for each cross-posted message, and this # script already learns for every list in # ~/.public-inbox/config - $im->remove($mime); + $im->remove($mime, $train); } else { # $train eq "ham" # no checking for spam here, we assume the message has # been reviewed by a human at this point: @@ -74,15 +86,9 @@ foreach my $recipient (keys %dests) { $im->add($mime); } $im->done; - my $in = $mime->as_string; - if (!run([qw(spamc -L), $train], \$in, @output)) { - $err = 1; - } - - $err or eval { - require PublicInbox::SearchIdx; - PublicInbox::SearchIdx->new($git_dir, 2)->index_sync; - }; } -exit $err; +if ($err) { + warn $err; + exit 1; +}