X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fnntpd.t;h=c7ea3197c20f3808fc037e5144ee5aad2fd89c5f;hb=0b1de991a099b5e8b9a9e3e85b5eaaacc9362dbb;hp=28d8491017a8c0d15d8dc0d4c2c5fd0f94f9e095;hpb=e41a7b0db983b38f77f535b432e33a021b5bab38;p=public-inbox.git diff --git a/t/nntpd.t b/t/nntpd.t index 28d84910..c7ea3197 100644 --- a/t/nntpd.t +++ b/t/nntpd.t @@ -1,40 +1,42 @@ -# Copyright (C) 2015 all contributors -# License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt) +# Copyright (C) 2015-2018 all contributors +# License: AGPL-3.0+ use strict; use warnings; use Test::More; -eval { require PublicInbox::SearchIdx }; -plan skip_all => "Xapian missing for nntpd" if $@; -eval { require PublicInbox::Msgmap }; -plan skip_all => "DBD::SQLite missing for nntpd" if $@; -use Cwd; +foreach my $mod (qw(DBD::SQLite)) { + eval "require $mod"; + plan skip_all => "$mod missing for nntpd.t" if $@; +} +require PublicInbox::SearchIdx; +require PublicInbox::Msgmap; use Email::Simple; use IO::Socket; -use Fcntl qw(FD_CLOEXEC F_SETFD F_GETFD); -use Socket qw(SO_KEEPALIVE IPPROTO_TCP TCP_NODELAY); +use Socket qw(IPPROTO_TCP TCP_NODELAY); use File::Temp qw/tempdir/; use Net::NNTP; -use IPC::Run qw(run); -use Data::Dumper; +use Sys::Hostname; +require './t/common.perl'; + +# FIXME: make easier to test both versions +my $version = $ENV{PI_VERSION} || 2; +require_git('2.6') if $version == 2; -my $tmpdir = tempdir(CLEANUP => 1); +my $tmpdir = tempdir('pi-nntpd-XXXXXX', TMPDIR => 1, CLEANUP => 1); my $home = "$tmpdir/pi-home"; my $err = "$tmpdir/stderr.log"; my $out = "$tmpdir/stdout.log"; -my $pi_home = "$home/.public-inbox"; -my $pi_config = "$pi_home/config"; -my $maindir = "$tmpdir/main.git"; -my $main_bin = getcwd()."/t/main-bin"; -my $main_path = "$main_bin:$ENV{PATH}"; # for spamc ham mock +my $mainrepo = "$tmpdir/main.git"; my $group = 'test-nntpd'; my $addr = $group . '@example.com'; -my $cfgpfx = "publicinbox.$group"; -my $failbox = "$home/fail.mbox"; -local $ENV{PI_EMERGENCY} = $failbox; -my $mda = 'blib/script/public-inbox-mda'; my $nntpd = 'blib/script/public-inbox-nntpd'; my $init = 'blib/script/public-inbox-init'; -my $index = 'blib/script/public-inbox-index'; +use_ok 'PublicInbox::Import'; +use_ok 'PublicInbox::Inbox'; +use_ok 'PublicInbox::Git'; +SKIP: { + skip "git 2.6+ required for V2Writable", 1 if $version == 1; + use_ok 'PublicInbox::V2Writable'; +} my %opts = ( LocalAddr => '127.0.0.1', @@ -45,72 +47,127 @@ my %opts = ( ); my $sock = IO::Socket::INET->new(%opts); my $pid; +my $len; END { kill 'TERM', $pid if defined $pid }; + +my $ibx = { + mainrepo => $mainrepo, + name => $group, + version => $version, + -primary_address => $addr, + indexlevel => 'basic', +}; +$ibx = PublicInbox::Inbox->new($ibx); { local $ENV{HOME} = $home; - system($init, $group, $maindir, 'http://example.com/', $addr); + my @cmd = ($init, $group, $mainrepo, 'http://example.com/', $addr); + push @cmd, "-V$version", '-Lbasic'; + is(system(@cmd), 0, 'init OK'); + is(system(qw(git config), "--file=$home/.public-inbox/config", + "publicinbox.$group.newsgroup", $group), + 0, 'enabled newsgroup'); + my $len; + + my $im; + if ($version == 2) { + $im = PublicInbox::V2Writable->new($ibx); + } elsif ($version == 1) { + use_ok 'PublicInbox::V1Writable'; + $im = PublicInbox::V1Writable->new($ibx); + } else { + die "unsupported version: $version"; + } # ensure successful message delivery { - local $ENV{ORIGINAL_RECIPIENT} = $addr; - my $simple = Email::Simple->new(< -To: You + my $mime = Email::MIME->new(< +From: =?utf-8?Q?El=C3=A9anor?= Cc: $addr Message-Id: -Subject: hihi -Date: Thu, 01 Jan 1970 00:00:00 +0000 +Content-Type: text/plain; charset=utf-8 +Subject: Testing for =?utf-8?Q?El=C3=A9anor?= +Date: Thu, 01 Jan 1970 06:06:06 +0000 +Content-Transfer-Encoding: 8bit +References: -nntp +This is a test message for El\xc3\xa9anor EOF - my $in = $simple->as_string; - local $ENV{PATH} = $main_path; - IPC::Run::run([$mda], \$in); - is(0, $?, 'ran MDA correctly'); - is(0, system($index, $maindir), 'indexed git dir'); + my $list_id = $addr; + $list_id =~ s/@/./; + $mime->header_set('List-Id', "<$list_id>"); + $len = length($mime->as_string); + $im->add($mime); + $im->done; + if ($version == 1) { + my $s = PublicInbox::SearchIdx->new($mainrepo, 1); + $s->index_sync; + } } ok($sock, 'sock created'); - $! = 0; - my $fl = fcntl($sock, F_GETFD, 0); - ok(! $!, 'no error from fcntl(F_GETFD)'); - is($fl, FD_CLOEXEC, 'cloexec set by default (Perl behavior)'); - $pid = fork; - if ($pid == 0) { - use POSIX qw(dup2); - # pretend to be systemd - fcntl($sock, F_SETFD, $fl &= ~FD_CLOEXEC); - dup2(fileno($sock), 3) or die "dup2 failed: $!\n"; - $ENV{LISTEN_PID} = $$; - $ENV{LISTEN_FDS} = 1; - exec $nntpd, "--stdout=$out", "--stderr=$err"; - die "FAIL: $!\n"; - } + my $cmd = [ $nntpd, "--stdout=$out", "--stderr=$err" ]; + $pid = spawn_listener(undef, $cmd, [ $sock ]); ok(defined $pid, 'forked nntpd process successfully'); - $! = 0; - fcntl($sock, F_SETFD, $fl |= FD_CLOEXEC); - ok(! $!, 'no error from fcntl(F_SETFD)'); my $host_port = $sock->sockhost . ':' . $sock->sockport; my $n = Net::NNTP->new($host_port); my $list = $n->list; is_deeply($list, { $group => [ qw(1 1 n) ] }, 'LIST works'); is_deeply([$n->group($group)], [ qw(0 1 1), $group ], 'GROUP works'); + is_deeply($n->listgroup($group), [1], 'listgroup OK'); + %opts = ( + PeerAddr => $host_port, + Proto => 'tcp', + Type => SOCK_STREAM, + Timeout => 1, + ); my $mid = ''; my %xhdr = ( 'message-id' => $mid, - 'subject' => 'hihi', - 'date' => 'Thu, 01 Jan 1970 00:00:00 +0000', - 'from' => 'Me ', - 'to' => 'You ', + subject => "Testing for El\xc3\xa9anor", + 'date' => 'Thu, 01 Jan 1970 06:06:06 +0000', + 'from' => "El\xc3\xa9anor ", + 'to' => "El\xc3\xa9anor ", 'cc' => $addr, - 'xref' => "example.com $group:1" + 'xref' => hostname . " $group:1", + 'references' => '', ); + + my $s = IO::Socket::INET->new(%opts); + sysread($s, my $buf, 4096); + is($buf, "201 " . hostname . " ready - post via email\r\n", + 'got greeting'); + $s->autoflush(1); + + ok(syswrite($s, " \r\n"), 'wrote spaces'); + ok(syswrite($s, "\r\n"), 'wrote nothing'); + syswrite($s, "NEWGROUPS\t19990424 000000 \033GMT\007\r\n"); + is(0, sysread($s, $buf, 4096), 'GOT EOF on cntrl'); + + $s = IO::Socket::INET->new(%opts); + sysread($s, $buf, 4096); + is($buf, "201 " . hostname . " ready - post via email\r\n", + 'got greeting'); + $s->autoflush(1); + + syswrite($s, "NEWGROUPS 19990424 000000 GMT\r\n"); + $buf = read_til_dot($s); + like($buf, qr/\A231 list of /, 'newgroups OK'); + while (my ($k, $v) = each %xhdr) { is_deeply($n->xhdr("$k $mid"), { $mid => $v }, - "$k by message-id works"); + "XHDR $k by message-id works"); is_deeply($n->xhdr("$k 1"), { 1 => $v }, "$k by article number works"); + is_deeply($n->xhdr("$k 1-"), { 1 => $v }, + "$k by article range works"); + $buf = ''; + syswrite($s, "HDR $k $mid\r\n"); + $buf = read_til_dot($s); + my @r = split("\r\n", $buf); + like($r[0], qr/\A225 /, '225 response for HDR'); + is($r[1], "0 $v", 'got expected response for HDR'); } { @@ -121,13 +178,133 @@ EOF } } - # TODO: upgrades and such + is_deeply($n->xover('1-'), { + '1' => ["Testing for El\xc3\xa9anor", + "El\xc3\xa9anor ", + 'Thu, 01 Jan 1970 06:06:06 +0000', + '', + '', + $len, + '1', + 'Xref: '. hostname . ' test-nntpd:1'] }, + "XOVER range works"); + + is_deeply($n->xover('1'), { + '1' => ["Testing for El\xc3\xa9anor", + "El\xc3\xa9anor ", + 'Thu, 01 Jan 1970 06:06:06 +0000', + '', + '', + $len, + '1', + 'Xref: '. hostname . ' test-nntpd:1'] }, + "XOVER by article works"); - ok(kill('TERM', $pid), 'killed nntpd'); - $pid = undef; - waitpid(-1, 0); + is_deeply($n->head(1), $n->head(''), 'HEAD OK'); + is_deeply($n->body(1), $n->body(''), 'BODY OK'); + is($n->body(1)->[0], "This is a test message for El\xc3\xa9anor\n", + 'body really matches'); + my $art = $n->article(1); + is(ref($art), 'ARRAY', 'got array for ARTICLE'); + is_deeply($art, $n->article(''), 'ARTICLE OK'); + is($n->article(999), undef, 'non-existent num'); + is($n->article(''), undef, 'non-existent mid'); + + { + syswrite($s, "OVER $mid\r\n"); + $buf = read_til_dot($s); + my @r = split("\r\n", $buf); + like($r[0], qr/^224 /, 'got 224 response for OVER'); + is($r[1], "0\tTesting for El\xc3\xa9anor\t" . + "El\xc3\xa9anor \t" . + "Thu, 01 Jan 1970 06:06:06 +0000\t" . + "$mid\t\t$len\t1" . + "\tXref: " . hostname . " test-nntpd:0", + 'OVER by Message-ID works'); + is($r[2], '.', 'correctly terminated response'); + } + + is_deeply($n->xhdr(qw(Cc 1-)), { 1 => 'test-nntpd@example.com' }, + 'XHDR Cc 1- works'); + is_deeply($n->xhdr(qw(References 1-)), { 1 => '' }, + 'XHDR References 1- works)'); + is_deeply($n->xhdr(qw(list-id 1-)), {}, + 'XHDR on invalid header returns empty'); + + my $mids = $n->newnews(0, '*'); + is_deeply($mids, [''], 'NEWNEWS works'); + { + my $t0 = time; + my $date = $n->date; + my $t1 = time; + ok($date >= $t0, 'valid date after start'); + ok($date <= $t1, 'valid date before stop'); + } + + # pipelined requests: + { + my $nreq = 90; + syswrite($s, "GROUP $group\r\n"); + my $res = <$s>; + my $rdr = fork; + if ($rdr == 0) { + use POSIX qw(_exit); + for (1..$nreq) { + <$s> =~ /\A224 / or _exit(1); + <$s> =~ /\A1/ or _exit(2); + <$s> eq ".\r\n" or _exit(3); + } + _exit(0); + } + for (1..$nreq) { + syswrite($s, "XOVER 1\r\n"); + } + is($rdr, waitpid($rdr, 0), 'reader done'); + is($? >> 8, 0, 'no errors'); + } + SKIP: { + my @of = `lsof -p $pid 2>/dev/null`; + skip('lsof broken', 1) if (!scalar(@of) || $?); + my @xap = grep m!Search/Xapian!, @of; + is_deeply(\@xap, [], 'Xapian not loaded in nntpd'); + } + { + setsockopt($s, IPPROTO_TCP, TCP_NODELAY, 1); + syswrite($s, 'HDR List-id 1-'); + select(undef, undef, undef, 0.15); + ok(kill('TERM', $pid), 'killed nntpd'); + select(undef, undef, undef, 0.15); + syswrite($s, "\r\n"); + $buf = ''; + do { + sysread($s, $buf, 4096, length($buf)); + } until ($buf =~ /\r\n\z/); + my @r = split("\r\n", $buf); + like($r[0], qr/^5\d\d /, + 'got 5xx response for unoptimized HDR'); + is(scalar @r, 1, 'only one response line'); + } + + $n = $s = undef; + is($pid, waitpid($pid, 0), 'nntpd exited successfully'); + my $eout = eval { + local $/; + open my $fh, '<', $err or die "open $err failed: $!"; + <$fh>; + }; + is($?, 0, 'no error in exited process'); + unlike($eout, qr/wide/i, 'no Wide character warnings'); } done_testing(); +sub read_til_dot { + my ($s) = @_; + my $buf = ''; + do { + sysread($s, $buf, 4096, length($buf)); + } until ($buf =~ /\r\n\.\r\n\z/); + $buf; +} + 1;