X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fnodatacow.t;h=0940d908e935772183fda449be0ff7d6b152e75c;hb=refs%2Fheads%2Fmaster;hp=87b6bdf72142a72a008e3366f301a1e30a0a517f;hpb=c106504309621b662ce6c7cd914718f7045edca4;p=public-inbox.git

diff --git a/t/nodatacow.t b/t/nodatacow.t
index 87b6bdf7..0940d908 100644
--- a/t/nodatacow.t
+++ b/t/nodatacow.t
@@ -1,34 +1,42 @@
 #!perl -w
-# Copyright (C) 2020 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
-use strict;
-use Test::More;
-use File::Temp qw(tempfile);
-use PublicInbox::TestCommon;
-use PublicInbox::Spawn qw(which);
-use_ok 'PublicInbox::NDC_PP';
+use strict; use v5.10.1; use PublicInbox::TestCommon;
+use File::Temp 0.19;
+use_ok 'PublicInbox::Syscall';
+
+# btrfs on Linux is copy-on-write (COW) by default.  As of Linux 5.7,
+# this still leads to fragmentation for SQLite and Xapian files where
+# random I/O happens, so we disable COW just for SQLite files and Xapian
+# directories.  Disabling COW disables checksumming, so we only do this
+# for regeneratable files, and not canonical git storage (git doesn't
+# checksum refs, only data under $GIT_DIR/objects).
 
 SKIP: {
 	my $nr = 2;
 	skip 'test is Linux-only', $nr if $^O ne 'linux';
 	my $dir = $ENV{BTRFS_TESTDIR};
 	skip 'BTRFS_TESTDIR not defined', $nr unless defined $dir;
-	skip 'chattr(1) not installed', $nr unless which('chattr');
-	my $lsattr = which('lsattr') or skip 'lsattr(1) not installed', $nr;
-	my ($fh, $name) = tempfile(DIR => $dir, UNLINK => 1);
-	BAIL_OUT "tempfile: $!" unless $fh && defined($name);
-	my $pp_sub = \&PublicInbox::NDC_PP::set_nodatacow;
-	$pp_sub->(fileno($fh));
+
+	my $lsattr = require_cmd('lsattr', 1) or
+		skip 'lsattr(1) not installed', $nr;
+
+	my $tmp = File::Temp->newdir('nodatacow-XXXX', DIR => $dir);
+	my $dn = $tmp->dirname;
+
+	my $name = "$dn/pp.f";
+	open my $fh, '>', $name or BAIL_OUT "open($name): $!";
+	PublicInbox::Syscall::nodatacow_fh($fh);
 	my $res = xqx([$lsattr, $name]);
-	like($res, qr/C/, "`C' attribute set with pure Perl");
-
-	my $ic_sub = \&PublicInbox::Spawn::set_nodatacow;
-	$pp_sub == $ic_sub and
-		skip 'Inline::C or Linux kernel headers missing', 1;
-	($fh, $name) = tempfile(DIR => $dir, UNLINK => 1);
-	$ic_sub->(fileno($fh));
-	$res = xqx([$lsattr, $name]);
-	like($res, qr/C/, "`C' attribute set with Inline::C");
+
+	BAIL_OUT "lsattr(1) fails in $dir" if $?;
+	like($res, qr/C.*\Q$name\E/, "`C' attribute set on fd with pure Perl");
+
+	$name = "$dn/pp.d";
+	mkdir($name) or BAIL_OUT "mkdir($name) $!";
+	PublicInbox::Syscall::nodatacow_dir($name);
+	$res = xqx([$lsattr, '-d', $name]);
+	like($res, qr/C.*\Q$name\E/, "`C' attribute set on dir with pure Perl");
 };
 
 done_testing;