X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fsearch.t;h=a728d79f77aa725355f9eaa8da4f1d9fc269adaa;hb=845d45f8b1c33a4b5fb559101ca53238b4dfc1aa;hp=b1dbb301a7fa5abe9726e7e8bd5eabf7269328f2;hpb=9bd675d33ad1e49bd2ebe12a1d216216e61380de;p=public-inbox.git

diff --git a/t/search.t b/t/search.t
index b1dbb301..a728d79f 100644
--- a/t/search.t
+++ b/t/search.t
@@ -17,7 +17,8 @@ my $git_dir = "$tmpdir/a.git";
 my $ibx = PublicInbox::Inbox->new({ mainrepo => $git_dir });
 my ($root_id, $last_id);
 
-is(0, system(qw(git init --shared -q --bare), $git_dir), "git init (main)");
+is(0, system(qw(git init --shared -q --bare), $git_dir), "git init (main)")
+	or BAIL_OUT("`git init --shared' failed, weird FS or seccomp?");
 eval { PublicInbox::Search->new($ibx)->xdb };
 ok($@, "exception raised on non-existent DB");
 
@@ -35,28 +36,30 @@ my $rw_commit = sub {
 	$rw->begin_txn_lazy;
 };
 
+sub oct_is ($$$) {
+	my ($got, $exp, $msg) = @_;
+	is(sprintf('0%03o', $got), sprintf('0%03o', $exp), $msg);
+}
+
 {
 	# git repository perms
-	is($ibx->_git_config_perm(), &PublicInbox::InboxWritable::PERM_GROUP,
-	   "undefined permission is group");
-	is(PublicInbox::InboxWritable::_umask_for(
-	     PublicInbox::InboxWritable->_git_config_perm('0644')),
-	   0022, "644 => umask(0022)");
-	is(PublicInbox::InboxWritable::_umask_for(
-	     PublicInbox::InboxWritable->_git_config_perm('0600')),
-	   0077, "600 => umask(0077)");
-	is(PublicInbox::InboxWritable::_umask_for(
-	     PublicInbox::InboxWritable->_git_config_perm('0640')),
-	   0027, "640 => umask(0027)");
-	is(PublicInbox::InboxWritable::_umask_for(
-	     PublicInbox::InboxWritable->_git_config_perm('group')),
-	   0007, 'group => umask(0007)');
-	is(PublicInbox::InboxWritable::_umask_for(
-	     PublicInbox::InboxWritable->_git_config_perm('everybody')),
-	   0002, 'everybody => umask(0002)');
-	is(PublicInbox::InboxWritable::_umask_for(
-	     PublicInbox::InboxWritable->_git_config_perm('umask')),
-	   umask, 'umask => existing umask');
+	oct_is($ibx->_git_config_perm(),
+		&PublicInbox::InboxWritable::PERM_GROUP,
+		'undefined permission is group');
+	my @t = (
+		[ '0644', 0022, '644 => umask(0022)' ],
+		[ '0600', 0077, '600 => umask(0077)' ],
+		[ '0640', 0027, '640 => umask(0027)' ],
+		[ 'group', 0007, 'group => umask(0007)' ],
+		[ 'everybody', 0002, 'everybody => umask(0002)' ],
+		[ 'umask', umask, 'umask => existing umask' ],
+	);
+	for (@t) {
+		my ($perm, $exp, $msg) = @$_;
+		my $got = PublicInbox::InboxWritable::_umask_for(
+			PublicInbox::InboxWritable->_git_config_perm($perm));
+		oct_is($got, $exp, $msg);
+	}
 }
 
 $ibx->with_umask(sub {
@@ -452,7 +455,7 @@ foreach my $f ("$git_dir/public-inbox/msgmap.sqlite3",
 		glob("$git_dir/public-inbox/xapian*/*")) {
 	my @st = stat($f);
 	my ($bn) = (split(m!/!, $f))[-1];
-	is($st[2] & $all_mask, -f _ ? 0660 : $dir_mask,
+	oct_is($st[2] & $all_mask, -f _ ? 0660 : $dir_mask,
 		"sharedRepository respected for $bn");
 }