X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fspawn.t;h=5fc99a2a101c8c2c83466e515a84bba471b9546e;hb=refs%2Fheads%2Fmaster;hp=884042824265b59717d4ca1bc9a6096f50f0807a;hpb=07f770c321474751550c4d73c65c27b2b197ac35;p=public-inbox.git diff --git a/t/spawn.t b/t/spawn.t index 88404282..ff95ae8e 100644 --- a/t/spawn.t +++ b/t/spawn.t @@ -1,9 +1,11 @@ -# Copyright (C) 2015-2018 all contributors +#!perl -w +# Copyright (C) all contributors # License: AGPL-3.0+ -use strict; -use warnings; +use v5.12; use Test::More; use PublicInbox::Spawn qw(which spawn popen_rd); +require PublicInbox::Sigfd; +require PublicInbox::DS; { my $true = which('true'); @@ -17,6 +19,60 @@ use PublicInbox::Spawn qw(which spawn popen_rd); is($?, 0, 'true exited successfully'); } +SKIP: { + my $pid = spawn(['true'], undef, { pgid => 0 }); + ok($pid, 'spawned process with new pgid'); + is(waitpid($pid, 0), $pid, 'waitpid succeeds on spawned process'); + is($?, 0, 'true exited successfully'); + pipe(my ($r, $w)) or BAIL_OUT; + + # Find invalid PID to try to join its process group. + my $wrong_pgid = 1; + for (my $i=0x7fffffff; $i >= 2; $i--) { + if (kill(0, $i) == 0) { + $wrong_pgid = $i; + last; + } + } + + # Test spawn behavior when it can't join the requested process group. + $pid = eval { spawn(['true'], undef, { pgid => $wrong_pgid, 2 => $w }) }; + close $w; + my $err = do { local $/; <$r> }; + if (defined $pid) { + waitpid($pid, 0); + isnt($?, 0, 'child error (pure-Perl)'); + } else { + ok($@, 'exception raised'); + } +} + +{ # ensure waitpid(-1, 0) and SIGCHLD works in spawned process + my $script = <<'EOF'; +$| = 1; # unbuffer stdout +defined(my $pid = fork) or die "fork: $!"; +if ($pid == 0) { exit } +elsif ($pid > 0) { + my $waited = waitpid(-1, 0); + $waited == $pid or die "mismatched child $pid != $waited"; + $? == 0 or die "child err: $>"; + $SIG{CHLD} = sub { print "HI\n"; exit }; + print "RDY $$\n"; + select(undef, undef, undef, 0.01) while 1; +} +EOF + my $oldset = PublicInbox::DS::block_signals(); + my $rd = popen_rd([$^X, '-e', $script]); + diag 'waiting for child to reap grandchild...'; + chomp(my $line = readline($rd)); + my ($rdy, $pid) = split(/ /, $line); + is($rdy, 'RDY', 'got ready signal, waitpid(-1) works in child'); + ok(kill('CHLD', $pid), 'sent SIGCHLD to child'); + is(readline($rd), "HI\n", '$SIG{CHLD} works in child'); + ok(close $rd, 'popen_rd close works'); + PublicInbox::DS::sig_setmask($oldset); +} + { my ($r, $w); pipe $r, $w or die "pipe failed: $!"; @@ -31,23 +87,13 @@ use PublicInbox::Spawn qw(which spawn popen_rd); my ($r, $w); pipe $r, $w or die "pipe failed: $!"; my $pid = spawn(['sh', '-c', 'echo $HELLO'], - { 'HELLO' => 'world' }, { 1 => fileno($w) }); + { 'HELLO' => 'world' }, { 1 => $w }); close $w or die "close pipe[1] failed: $!"; is(<$r>, "world\n", 'read stdout of spawned from pipe'); is(waitpid($pid, 0), $pid, 'waitpid succeeds on spawned process'); is($?, 0, 'sh exited successfully'); } -{ - my ($r, $w); - pipe $r, $w or die "pipe failed: $!"; - my $pid = spawn(['env'], {}, { -env => 1, 1 => fileno($w) }); - close $w or die "close pipe[1] failed: $!"; - ok(!defined(<$r>), 'read stdout of spawned from pipe'); - is(waitpid($pid, 0), $pid, 'waitpid succeeds on spawned process'); - is($?, 0, 'env(1) exited successfully'); -} - { my $fh = popen_rd([qw(echo hello)]); ok(fileno($fh) >= 0, 'tied fileno works'); @@ -60,6 +106,11 @@ use PublicInbox::Spawn qw(which spawn popen_rd); { my $fh = popen_rd([qw(printf foo\nbar)]); ok(fileno($fh) >= 0, 'tied fileno works'); + my $tfh = (tied *$fh)->{fh}; + is($tfh->blocking(0), 1, '->blocking was true'); + is($tfh->blocking, 0, '->blocking is false'); + is($tfh->blocking(1), 0, '->blocking was true'); + is($tfh->blocking, 1, '->blocking is true'); my @line = <$fh>; is_deeply(\@line, [ "foo\n", 'bar' ], 'wantarray works on readline'); } @@ -71,25 +122,62 @@ use PublicInbox::Spawn qw(which spawn popen_rd); is($buf, "hello\n", 'tied gets works'); is(sysread($fh, $buf, 6), 0, 'sysread got EOF'); $? = 1; - close $fh; + ok(close($fh), 'close succeeds'); is($?, 0, '$? set properly'); } { my $fh = popen_rd([qw(false)]); - close $fh; + ok(!close($fh), 'close fails on false'); isnt($?, 0, '$? set properly: '.$?); } { - my ($fh, $pid) = popen_rd([qw(sleep 60)], undef, { Blocking => 0 }); - ok(defined $pid && $pid > 0, 'returned pid when array requested'); - is(kill(0, $pid), 1, 'child process is running'); - ok(!defined(sysread($fh, my $buf, 1)) && $!{EAGAIN}, - 'sysread returned quickly with EAGAIN'); - is(kill(9, $pid), 1, 'child process killed early'); - is(waitpid($pid, 0), $pid, 'child process reapable'); - isnt($?, 0, '$? set properly: '.$?); + local $ENV{GIT_CONFIG} = '/path/to/this/better/not/exist'; + my $fh = popen_rd([qw(env)], { GIT_CONFIG => undef }); + ok(!grep(/^GIT_CONFIG=/, <$fh>), 'GIT_CONFIG clobbered'); +} + +{ # ->CLOSE vs ->DESTROY waitpid caller distinction + my @c; + my $fh = popen_rd(['true'], undef, { cb_arg => [sub { @c = caller }] }); + ok(close($fh), '->CLOSE fired and successful'); + ok(scalar(@c), 'callback fired by ->CLOSE'); + ok(grep(!m[/PublicInbox/DS\.pm\z], @c), 'callback not invoked by DS'); + + @c = (); + $fh = popen_rd(['true'], undef, { cb_arg => [sub { @c = caller }] }); + undef $fh; # ->DESTROY + ok(scalar(@c), 'callback fired by ->DESTROY'); + ok(grep(!m[/PublicInbox/ProcessPipe\.pm\z], @c), + 'callback not invoked by ProcessPipe'); +} + +{ # children don't wait on siblings + use POSIX qw(_exit); + pipe(my ($r, $w)) or BAIL_OUT $!; + my @arg; + my $cb = [ sub { @arg = @_; warn "x=$$\n" }, 'hi' ]; + my $fh = popen_rd(['cat'], undef, { 0 => $r, cb_arg => $cb }); + my $pp = tied *$fh; + my $pid = fork // BAIL_OUT $!; + local $SIG{__WARN__} = sub { _exit(1) }; + if ($pid == 0) { + local $SIG{__DIE__} = sub { _exit(2) }; + undef $fh; + _exit(0); + } + waitpid($pid, 0); + is($?, 0, 'forked process exited'); + my @w; + local $SIG{__WARN__} = sub { push @w, @_ }; + close $w; + close $fh; + is($?, 0, 'cat exited'); + is(scalar(@arg), 2, 'callback got args'); + is($arg[1], 'hi', 'passed arg'); + like($arg[0], qr/\A\d+\z/, 'PID'); + is_deeply(\@w, [ "x=$$\n" ], 'callback fired from owner'); } SKIP: { @@ -111,6 +199,30 @@ SKIP: { isnt($?, 0, 'non-zero exit status'); } -done_testing(); +SKIP: { + require PublicInbox::SpawnPP; + require File::Temp; + my $tmp = File::Temp->newdir('spawnpp-XXXX', TMPDIR => 1); + my $cmd = [ qw(/bin/sh -c), 'echo $HI >foo' ]; + my $env = [ 'HI=hihi' ]; + my $rlim = []; + my $pgid = -1; + my $pid = PublicInbox::SpawnPP::pi_fork_exec([], '/bin/sh', $cmd, $env, + $rlim, "$tmp", $pgid); + is(waitpid($pid, 0), $pid, 'spawned process exited'); + is($?, 0, 'no error'); + open my $fh, '<', "$tmp/foo" or die "open: $!"; + is(readline($fh), "hihi\n", 'env+chdir worked for SpawnPP'); + close $fh; + unlink("$tmp/foo") or die "unlink: $!"; + { + local $ENV{MOD_PERL} = 1; + $pid = PublicInbox::SpawnPP::pi_fork_exec([], + '/bin/sh', $cmd, $env, $rlim, "$tmp", $pgid); + } + is(waitpid($pid, 0), $pid, 'spawned process exited'); + open $fh, '<', "$tmp/foo" or die "open: $!"; + is(readline($fh), "hihi\n", 'env+chdir SpawnPP under (faked) MOD_PERL'); +} -1; +done_testing();