X-Git-Url: http://www.git.stargrave.org/?a=blobdiff_plain;f=t%2Fview.t;h=b829ecf883f8cca07cf28444e5ba4741578de57c;hb=4db4bfa2c9178b315d2ac09cff794a4476ba1f6e;hp=10a182b355da5786a5995c87c40f7208643404f4;hpb=a1331e538ed8fff6e9554de553a2869954f54167;p=public-inbox.git

diff --git a/t/view.t b/t/view.t
index 10a182b3..b829ecf8 100644
--- a/t/view.t
+++ b/t/view.t
@@ -1,10 +1,38 @@
-# Copyright (C) 2013, Eric Wong <normalperson@yhbt.net> and all contributors
-# License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt)
+# Copyright (C) 2013-2018 all contributors <meta@public-inbox.org>
+# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
 use warnings;
 use Test::More;
 use Email::MIME;
-use PublicInbox::View;
+use Plack::Util;
+use_ok 'PublicInbox::View';
+
+# FIXME: make this test less fragile
+my $ctx = {
+	env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'http' },
+	-inbox => Plack::Util::inline_object(
+		name => 'test',
+		search => sub { undef },
+		base_url => sub { 'http://example.com/' },
+		cloneurl => sub {[]},
+		nntp_url => sub {[]},
+		max_git_part => sub { undef },
+		description => sub { '' }),
+};
+$ctx->{-inbox}->{-primary_address} = 'test@example.com';
+
+sub msg_html ($) {
+	my ($mime) = @_;
+
+	my $s = '';
+	my $r = PublicInbox::View::msg_html($ctx, $mime);
+	my $body = $r->[2];
+	while (defined(my $buf = $body->getline)) {
+		$s .= $buf;
+	}
+	$body->close;
+	$s;
+}
 
 # plain text
 {
@@ -18,7 +46,14 @@ OK
 > We generate links to a separate full page where quoted-text is inline.
 > This is
 >
-> Currently 5 lines
+> Currently 12 lines
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
 > See MAX_INLINE_QUOTED
 
 hello world
@@ -32,26 +67,14 @@ EOF
 			Subject => 'this is a subject',
 		],
 		body => $body,
-	);
-	$s = Email::MIME->new($s->as_string);
-	my $html = PublicInbox::View->msg_html($s);
+	)->as_string;
+	my $mime = Email::MIME->new($s);
+	my $html = msg_html($mime);
 
 	# ghetto tests
-	like($html, qr!<a href="\.\./m/hello%40!s, "MID link present");
+	like($html, qr!<a\nhref="raw"!s, "raw link present");
 	like($html, qr/hello world\b/, "body present");
 	like($html, qr/&gt; keep this inline/, "short quoted text is inline");
-	like($html, qr/<a name=[^>]+>&gt; Long and wordy/,
-		"long quoted text is anchored");
-
-	# short page
-	my $pfx = "http://example.com/test/f";
-	my $short = PublicInbox::View->msg_html($s, $pfx);
-	like($short, qr!<a href="hello%40!s, "MID link present");
-	like($short, qr/\n&gt; keep this inline/,
-		"short quoted text is inline");
-	like($short, qr/<a href="\Q$pfx\E#[^>]+>Long and wordy/,
-		"long quoted text is made into a link");
-	ok(length($short) < length($html), "short page is shorter");
 }
 
 # multipart crap
@@ -76,8 +99,8 @@ EOF
 		parts => $parts,
 	);
 
-	my $html = PublicInbox::View->msg_html($mime);
-	like($html, qr/hi\n-+ part #2 -+\nbye\n/, "multipart split");
+	my $html = msg_html($mime);
+	like($html, qr/hi\n.*-- Attachment #2.*\nbye\n/s, "multipart split");
 }
 
 # multipart email with attached patch
@@ -90,7 +113,7 @@ EOF
 		Email::MIME->create(
 			attributes => {
 				content_type => 'text/plain',
-				filename => "foo.patch",
+				filename => "foo&.patch",
 			},
 			body => "--- a/file\n+++ b/file\n" .
 			        "@@ -49, 7 +49,34 @@\n",
@@ -105,9 +128,67 @@ EOF
 		parts => $parts,
 	);
 
-	my $html = PublicInbox::View->msg_html($mime);
-	like($html, qr!see attached patch\n-+ foo\.patch -+\n--- a/file\n!,
+	my $html = msg_html($mime);
+	like($html, qr!.*Attachment #2: foo&(?:amp|#38);\.patch --!,
 		"parts split with filename");
 }
 
+# multipart collapsed to single quoted-printable text/plain
+{
+	my $parts = [
+		Email::MIME->create(
+			attributes => {
+				content_type => 'text/plain',
+				encoding => 'quoted-printable',
+			},
+			body => 'hi = bye',
+		)
+	];
+	my $mime = Email::MIME->create(
+		header_str => [
+			From => 'qp@example.com',
+			Subject => 'QP',
+			'Message-ID' => '<qp@example.com>',
+			],
+		parts => $parts,
+	);
+
+	my $orig = $mime->body_raw;
+	my $html = msg_html($mime);
+	like($orig, qr/hi =3D bye=/, "our test used QP correctly");
+	like($html, qr/\bhi = bye\b/, "HTML output decoded QP");
+}
+
+{
+	use PublicInbox::MID qw/id_compress/;
+
+	# n.b: this is probably invalid since we dropped CGI for PSGI:
+	like(id_compress('foo%bar@wtf'), qr/\A[a-f0-9]{40}\z/,
+		"percent always converted to sha1 to workaround buggy httpds");
+
+	is(id_compress('foobar-wtf'), 'foobar-wtf',
+		'regular ID not compressed');
+}
+
+{
+	my $cols = PublicInbox::View::COLS();
+	my @addr;
+	until (length(join(', ', @addr)) > ($cols * 2)) {
+		push @addr, '"l, f" <a@a>';
+		my $n = int(rand(20)) + 1;
+		push @addr, ('x'x$n).'@x';
+	}
+	my $orig = join(', ', @addr);
+	my $res = PublicInbox::View::fold_addresses($orig.'');
+	isnt($res, $orig, 'folded result');
+	unlike($res, qr/l,\n\tf/s, '"last, first" no broken');
+	my @nospc = ($res, $orig);
+	s/\s+//g for @nospc;
+	is($nospc[0], $nospc[1], 'no addresses lost in translation');
+	my $tws = PublicInbox::View::fold_addresses($orig.' ');
+	# (Email::Simple drops leading whitespace, but not trailing)
+	$tws =~ s/ \z//;
+	is($tws, $res, 'not thrown off by trailing whitespace');
+}
+
 done_testing();