lib/PublicInbox/SearchIdx.pm | 8 +++----- diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index 9638e0c559a956d96218552fdd720bfe7333e546..36f97b36d7bb8170237884bd27742cc6afed0fd1 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -539,9 +539,9 @@ $doc->add_boolean_term('XNUM' . $num) if defined $num; $doc->add_boolean_term('XPATH' . $xpath) if defined $xpath; $doc->add_boolean_term('Q' . $_) foreach @$mids; - my $vivified = 0; $self->{skel} and die "Should not have read-only skel here\n";; foreach my $mid (@$mids) { + my $vivified = 0; $self->each_smsg_by_mid($mid, sub { my ($cur) = @_; my $type = $cur->type; @@ -563,10 +563,8 @@ $self->{xdb}->replace_document($doc_id, $doc); ++$vivified; 1; }); - } - if ($vivified > 1) { - my $id = '<'.join('> <', @$mids).'>'; - warn "BUG: vivified multiple ($vivified) ghosts for $id\n"; + $vivified > 1 and warn + "BUG: vivified multiple ($vivified) ghosts for $mid\n"; } # not really important, but we return any vivified ghost docid, here: return $doc_id if defined $doc_id;