.deepsource.toml | 11 +++++++++++ fs/torrentfs.go | 4 ++-- mse/mse.go | 2 +- mse/mse_test.go | 2 +- webtorrent/tracker_client.go | 2 +- diff --git a/.deepsource.toml b/.deepsource.toml new file mode 100644 index 0000000000000000000000000000000000000000..6c68e6d8e7a7991279df82c2403cb74220951253 --- /dev/null +++ b/.deepsource.toml @@ -0,0 +1,11 @@ +version = 1 + +test_patterns = ["**/*_test.go"] + +[[analyzers]] +name = "go" +enabled = true + + [analyzers.meta] + import_paths = ["github.com/anacrolix/torrent"] + diff --git a/fs/torrentfs.go b/fs/torrentfs.go index 0b3b7a91f1421f3068f03e1d9dd34cb6bdf6602c..aedab1af68d5d216883ffd244bbc93ab5dc9908e 100644 --- a/fs/torrentfs.go +++ b/fs/torrentfs.go @@ -60,14 +60,14 @@ _ fusefs.HandleReadDirAller = dirNode{} ) func isSubPath(parent, child string) bool { - if len(parent) == 0 { + if parent == "" { return len(child) > 0 } if !strings.HasPrefix(child, parent) { return false } extra := child[len(parent):] - if len(extra) == 0 { + if extra == "" { return false } // Not just a file with more stuff on the end. diff --git a/mse/mse.go b/mse/mse.go index d4a0368e11c9bc718844fc214447f2a7b3e49b29..a2f2d1d90eff349b557d249acda94ba272064093 100644 --- a/mse/mse.go +++ b/mse/mse.go @@ -133,7 +133,7 @@ cr.b = nil return ret } }() - cr.c.XORKeyStream(be[:], b) + cr.c.XORKeyStream(be, b) n, err = cr.w.Write(be[:len(b)]) if n != len(b) { // The cipher will have advanced beyond the callers stream position. diff --git a/mse/mse_test.go b/mse/mse_test.go index b10ca8f92a4b980bba4fa41d2c4a1757ed453858..f13c259f6c19f9c4bb400ae0ed0951fb86305a62 100644 --- a/mse/mse_test.go +++ b/mse/mse_test.go @@ -87,7 +87,7 @@ assert.Equal(t, cryptoSelect(cryptoProvides), res.CryptoMethod) go b.Write([]byte(bData)) // Need to be exact here, as there are several reads, and net.Pipe is most synchronous. msg := make([]byte, len(ia)+len(aData)) - n, _ := io.ReadFull(b, msg[:]) + n, _ := io.ReadFull(b, msg) if n != len(msg) { t.FailNow() } diff --git a/webtorrent/tracker_client.go b/webtorrent/tracker_client.go index 0fe980c7a21c77b3ae11ad9f89f6c2f2ed353099..004825c8e572558f1adf1538caaa93dd8df9f8a4 100644 --- a/webtorrent/tracker_client.go +++ b/webtorrent/tracker_client.go @@ -92,7 +92,7 @@ return } case <-closeChan: return - default: + } } }()