lib/PublicInbox/Reply.pm | 3 ---
lib/PublicInbox/View.pm | 3 +++
t/reply.t | 10 ++--------
diff --git a/lib/PublicInbox/Reply.pm b/lib/PublicInbox/Reply.pm
index 592dfb624f7a7091af7cdf4bd935d09624488d74..091f20bc00f35106afdef4a84df1d88372f61b22 100644
--- a/lib/PublicInbox/Reply.pm
+++ b/lib/PublicInbox/Reply.pm
@@ -68,7 +68,6 @@ my @arg;
my $obfs = $ibx->{obfuscate};
my $subj = $hdr->header('Subject') || '';
$subj = "Re: $subj" unless $subj =~ /\bRe:/i;
- my $subj_raw = $subj;
my $mid = $hdr->header_raw('Message-ID');
push @arg, '--in-reply-to='.squote_maybe(mid_clean($mid));
my $irt = mid_href($mid);
@@ -97,8 +96,6 @@ $cc = '&Cc=' . uri_escape_utf8(join(',', @cc));
push(@arg, map { "--cc=$_" } @cc);
}
}
-
- push @arg, "--subject=".squote_maybe($subj_raw);
# I'm not sure if address obfuscation and mailto: links can
# be made compatible; and address obfuscation is misguided,
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index b90cb08baadc04783c54a43853a39f5545dd983d..fa96cca337d87f9113425a209c5b78aafa2b6dfa 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -142,6 +142,9 @@
$se_url
$link
+
+ Be sure your reply has a Subject: header at the top and a blank line
+ before the message body.
EOF
}
diff --git a/t/reply.t b/t/reply.t
index 41d72db22c6586eb771009c056b413123ddae77c..7319e2337dd18b95ab3c623b995ef25f8e037bd4 100644
--- a/t/reply.t
+++ b/t/reply.t
@@ -38,7 +38,6 @@ '--in-reply-to=blah@example.com',
'--to=from@example.com',
'--cc=cc@example.com',
'--cc=to@example.com',
- "--subject='Re: hihi'"
];
is_deeply($arg, $exp, 'default reply is to :all');
@@ -46,8 +45,7 @@ $ibx->{replyto} = ':all';
($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr);
is_deeply($arg, $exp, '":all" also works');
-$exp = [ '--in-reply-to=blah@example.com', '--to=primary@example.com',
- "--subject='Re: hihi'" ];
+$exp = [ '--in-reply-to=blah@example.com', '--to=primary@example.com' ];
$ibx->{replyto} = ':list';
($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr);
is_deeply($arg, $exp, '":list" works for centralized lists');
@@ -57,7 +55,6 @@ '--in-reply-to=blah@example.com',
'--to=primary@example.com',
'--cc=cc@example.com',
'--cc=to@example.com',
- "--subject='Re: hihi'"
];
$ibx->{replyto} = ':list,Cc,To';
($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr);
@@ -65,9 +62,7 @@ is_deeply($arg, $exp, '":list,Cc,To" works for kinda centralized lists');
$ibx->{replyto} = 'new@example.com';
($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr);
-$exp = [ '--in-reply-to=blah@example.com', '--to=new@example.com',
- "--subject='Re: hihi'"
-];
+$exp = [ '--in-reply-to=blah@example.com', '--to=new@example.com' ];
is_deeply($arg, $exp, 'explicit address works, too');
$ibx->{replyto} = ':all';
@@ -78,7 +73,6 @@ '--in-reply-to=blah@example.com',
'--to=from@example$(echo .)com',
'--cc=cc@example$(echo .)com',
'--cc=to@example$(echo .)com',
- "--subject='Re: hihi'"
];
is_deeply($arg, $exp, 'address obfuscation works');
is($link, '', 'no mailto: link given');