lib/PublicInbox/View.pm | 18 +++++++----------- t/view.t | 2 +- diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 3695bb2aafe8bc54a6e292aa28b52adea092e13c..bc4c7ac70cfd90831c625ba8fb1189ab6bdb5614 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -54,8 +54,8 @@ my $subj = $mime->header('Subject'); my $header_obj = $mime->header_obj; my $mid_raw = $header_obj->header_raw('Message-ID'); - my $name = anchor_for($mid_raw); - $seen->{$name} = "#$name"; # save the anchor for later + my $id = anchor_for($mid_raw); + $seen->{$id} = "#$id"; # save the anchor for later my $mid = PublicInbox::Hval->new_msgid($mid_raw); my $from = PublicInbox::Hval->new_oneline($mime->header('From'))->raw; @@ -78,13 +78,9 @@ $fmt = '%m/%d ' . $time; } $ts = POSIX::strftime($fmt, gmtime($ts)); - $rv .= "$pfx" . - "" . - "$subj\n$pfx"; - + $rv .= "$pfx$subj\n$pfx"; $rv .= "- by $from @ $ts - "; - - $rv .= "next"; + $rv .= "next"; if ($prev >= 0) { $rv .= "/prev"; } @@ -153,7 +149,7 @@ $seen->{$anchor_idx} = $anchor; } $rv .= " parent"; } - $rv .= " threadlink"; + $rv .= " threadlink"; $rv . "\n\n"; } @@ -269,7 +265,7 @@ $s =~ s!^((?:(?:>[^\n]*)\n)+)! my $cur = $1; my @lines = split(/\n/, $cur); if (@lines > MAX_INLINE_QUOTED) { - "$cur"; + "$cur"; } else { $cur; } @@ -382,7 +378,7 @@ sub anchor_for { my ($msgid) = @_; $msgid =~ s/\A\s*?\s*\z//; - Digest::SHA::sha1_hex($msgid); + 'm' . Digest::SHA::sha1_hex($msgid); } 1; diff --git a/t/view.t b/t/view.t index 1851793377fbd557f90fb7dc2105ac916798b346..63de49bd43ef8c9bd8398ecb0177beda4e62b904 100644 --- a/t/view.t +++ b/t/view.t @@ -47,7 +47,7 @@ # ghetto tests like($html, qr!]+>> Long and wordy/, + like($html, qr/]+>> Long and wordy/, "long quoted text is anchored"); # short page