lib/PublicInbox/SearchThread.pm | 5 ++--- diff --git a/lib/PublicInbox/SearchThread.pm b/lib/PublicInbox/SearchThread.pm index 05de9ec5b84d270fefc34b8b709a4e1d2c9ca292..003a8d118fc5e6d3a2db6ac7d6116f2f8edd89b2 100644 --- a/lib/PublicInbox/SearchThread.pm +++ b/lib/PublicInbox/SearchThread.pm @@ -33,7 +33,7 @@ sub thread { my $self = shift; _add_message($self, $_) foreach @{$self->{messages}}; my $id_table = delete $self->{id_table}; - $self->{rootset} = [ grep { !$_->{parent} } values %$id_table ]; + $self->{rootset} = [ grep { !delete $_->{parent} } values %$id_table ]; } sub _get_cont_for_id ($$) { @@ -90,7 +90,6 @@ package PublicInbox::SearchThread::Msg; use strict; use warnings; use Carp qw(croak); -use Scalar::Util qw(weaken); sub new { bless { @@ -112,7 +111,7 @@ if (defined(my $parent = $child->{parent})) { delete $parent->{children}->{$cid}; } - weaken($child->{parent} = $self); + $child->{parent} = $self; } sub has_descendent {