From: Eric Wong <e@80x24.org>
Date: Tue, 10 Nov 2020 03:20:29 +0000 (+0000)
Subject: searchidx: fix fallback on unindex miss
X-Git-Tag: v1.7.0~1637
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=0246654927fd9ddc9718ca0d7d5c7e29ce004d5c;p=public-inbox.git

searchidx: fix fallback on unindex miss

In case of other bugs or intentional corruption of over.sqlite3,
we don't want to attempt dereferencing a non-ref scalar when
calling ->mid_delete in the fallback code path.

Noticed while chasing another bug in extindex development...
---

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 06d1a9f5..662055c6 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -554,8 +554,8 @@ sub unindex_eml {
 		$tmp{$_}++ for @removed;
 	}
 	if (!$nr) {
-		$mids = join('> <', @$mids);
-		warn "W: <$mids> missing for removal from overview\n";
+		my $m = join('> <', @$mids);
+		warn "W: <$m> missing for removal from overview\n";
 	}
 	while (my ($num, $nr) = each %tmp) {
 		warn "BUG: $num appears >1 times ($nr) for $oid\n" if $nr != 1;