From: Eric Wong <e@80x24.org>
Date: Fri, 26 Mar 2021 09:51:26 +0000 (+0000)
Subject: lei mark: disallow '!' in labels
X-Git-Tag: v1.7.0~895
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=0c1a911235f99ea3469c69a4297e544fe5301bfa;p=public-inbox.git

lei mark: disallow '!' in labels

'!' could wreak havoc if exposed to a shell like bash.  It seems
like a rare character for use in file/directory/mailbox names.
---

diff --git a/lib/PublicInbox/LeiMark.pm b/lib/PublicInbox/LeiMark.pm
index 7a2ccf77..6d236411 100644
--- a/lib/PublicInbox/LeiMark.pm
+++ b/lib/PublicInbox/LeiMark.pm
@@ -23,7 +23,7 @@ my %ERR = (
 		my ($label) = @_;
 		length($label) >= $L_MAX and
 			return "`$label' too long (must be <= $L_MAX)";
-		$label =~ m{\A[a-z0-9_][a-z0-9_\-\./\@\!,]*[a-z0-9]\z} ?
+		$label =~ m{\A[a-z0-9_][a-z0-9_\-\./\@,]*[a-z0-9]\z} ?
 			undef : "`$label' is invalid";
 	},
 	kw => sub {