From: Eric Wong <e@80x24.org>
Date: Mon, 7 Jan 2019 11:53:10 +0000 (+0000)
Subject: nntp: fix uninitialized variable in event_read
X-Git-Tag: v1.2.0~419
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=0f0d6284b51db4e0f10b698a4461e45f2e774495;p=public-inbox.git

nntp: fix uninitialized variable in event_read

do_write must return 0 or 1.
---

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 90a5a3a5..623ffd35 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -902,7 +902,7 @@ sub more ($$) {
 sub do_write ($$) {
 	my ($self, $data) = @_;
 	my $done = $self->write($data);
-	return if $self->{closed};
+	return 0 if $self->{closed};
 
 	# Do not watch for readability if we have data in the queue,
 	# instead re-enable watching for readability when we can