From: Eric Wong <e@80x24.org>
Date: Mon, 29 Aug 2022 09:26:34 +0000 (+0000)
Subject: viewvcs: use array for highlighted blob display
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=2231b44cd5726ce338ca6213300b4e8c74f1bcaa;p=public-inbox.git

viewvcs: use array for highlighted blob display

This can avoid at least one expensive copy for displaying
large blobs with syntax highlighting.

However, we cannot blindly change everything to arrays, either:
the cost of invoking Compress::Raw::Zlib->deflate must be taken
into account.  Joining short strings via `.=', `.', `join' or
interpolation is typically faster since it avoids ->deflate
method calls (and non-magic perlops are the fastest dispatches
in Perl).
---

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 23524ac0..8fb0844d 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -313,15 +313,15 @@ EOM
 		$$blob = ascii_html($$blob);
 	}
 
-	# using some of the same CSS class names and ids as cgit
-	html_page($ctx, 200, "<pre>$oid $type $size bytes $raw_link</pre>" .
+	my $x = "<pre>$oid $type $size bytes $raw_link</pre>" .
 		"<hr /><table\nclass=blob>".
-		"<tr><td\nclass=linenumbers><pre>" . join('', map {
-			sprintf("<a id=n$_ href=#n$_>% ${pad}u</a>\n", $_)
-		} (1..$nl)) . '</pre></td>' .
-		'<td><pre> </pre></td>'. # pad for non-CSS users
-		"<td\nclass=lines><pre\nstyle='white-space:pre'><code>" .
-		$ctx->{-linkify}->linkify_2($$blob) .
+		"<tr><td\nclass=linenumbers><pre>";
+	$x .= sprintf("<a id=n$_ href=#n$_>% ${pad}u</a>\n", $_) for (1..$nl);
+	$x .= '</pre></td><td><pre> </pre></td>'. # pad for non-CSS users
+		"<td\nclass=lines><pre\nstyle='white-space:pre'><code>";
+
+	# using some of the same CSS class names and ids as cgit
+	html_page($ctx, 200, $x, $ctx->{-linkify}->linkify_2($$blob),
 		'</code></pre></td></tr></table>'.dbg_log($ctx));
 }