lib/PublicInbox/Cgit.pm | 5 +---- lib/PublicInbox/Config.pm | 7 +++---- diff --git a/lib/PublicInbox/Cgit.pm b/lib/PublicInbox/Cgit.pm index 8ad07be227345e2d15269128bb46718e0737c8ab..cc729aa286f4bf126de8f7093dab1c37d0b480a2 100644 --- a/lib/PublicInbox/Cgit.pm +++ b/lib/PublicInbox/Cgit.pm @@ -63,15 +63,12 @@ cgit_data => $cgit_data, pi_cfg => $pi_cfg, }, $class; - # fill in -code_repos mapped to inboxes - $pi_cfg->each_inbox($pi_cfg->can('repo_objs')); - # some cgit repos may not be mapped to inboxes, so ensure those exist: my $code_repos = $pi_cfg->{-code_repos}; foreach my $k (keys %$pi_cfg) { $k =~ /\Acoderepo\.(.+)\.dir\z/ or next; my $dir = $pi_cfg->{$k}; - $code_repos->{$1} ||= PublicInbox::Git->new($dir); + $code_repos->{$1} ||= $pi_cfg->fill_code_repo($1); } while (my ($nick, $repo) = each %$code_repos) { $self->{"\0$nick"} = $repo; diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index f2e5d5f0801e4c0f566f51ae654bdc55a5112c38..41117ac535d49678020bdddb4f5e79092794defa 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -323,9 +323,8 @@ } cgit_repo_merge($self, $repo->{dir}, $repo) if $repo; } -# parse a code repo -# Only git is supported at the moment, but SVN and Hg are possibilities -sub _fill_code_repo { +# parse a code repo, only git is supported at the moment +sub fill_code_repo { my ($self, $nick) = @_; my $pfx = "coderepo.$nick"; my $dir = $self->{"$pfx.dir"} // do { # aka "GIT_DIR" @@ -392,7 +391,7 @@ warn "invalid coderepo name: `$nick'\n"; next; } my $repo = $code_repos->{$nick} //= - _fill_code_repo($self, $nick); + fill_code_repo($self, $nick); push @repo_objs, $repo if $repo; } if (scalar @repo_objs) {