lib/PublicInbox/MailDiff.pm | 8 +++++--- t/psgi_v2.t | 40 +++++++++++++++++++++++++++++++++++++++- diff --git a/lib/PublicInbox/MailDiff.pm b/lib/PublicInbox/MailDiff.pm index a0ecef9fbdd75634809b35a58eccd657a4f7ba6b..7511144c6419e235e7b2e63f5a81f64fa3fed6a0 100644 --- a/lib/PublicInbox/MailDiff.pm +++ b/lib/PublicInbox/MailDiff.pm @@ -19,8 +19,10 @@ } my $ct = $part->content_type || 'text/plain'; my ($s, $err) = msg_part_text($part, $ct); my $sfx = defined($s) ? 'txt' : 'bin'; - open my $fh, '>', "$self->{curdir}/$idx.$sfx" or die "open: $!"; - print $fh ($s // $part->body) or die "print $!"; + $s //= $part->body; + $s =~ s/\r+\n/\n/sg; + open my $fh, '>:utf8', "$self->{curdir}/$idx.$sfx" or die "open: $!"; + print $fh $s or die "print $!"; close $fh or die "close $!"; } @@ -66,9 +68,9 @@ sub emit_msg_diff { my ($bref, $self) = @_; # bref is `git diff' output # will be escaped to `•' in HTML + utf8::decode($$bref); $self->{ctx}->{ibx}->{obfuscate} and obfuscate_addrs($self->{ctx}->{ibx}, $$bref, "\x{2022}"); - $$bref =~ s/\r+\n/\n/sg; print { $self->{ctx}->{zfh} } '
' if $self->{nr} > 1;
flush_diff($self->{ctx}, $bref);
next_smsg($self);
diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index f709c3c7a04ba8ef06eb20b6df4e8d0ce50bc98e..5b197a9f65b9d2d14d8e659bbb392f19dd7425c5 100644
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -13,6 +13,36 @@ URI::Escape Plack::Builder HTTP::Date));
use_ok($_) for (qw(HTTP::Request::Common Plack::Test));
use_ok 'PublicInbox::WWW';
my ($tmpdir, $for_destroy) = tmpdir();
+my $enc_dup = 'ref-20150309094050.GO3427@x1.example';
+
+my $dibx = create_inbox 'v2-dup', version => 2, indexlevel => 'medium',
+ tmpdir => "$tmpdir/dup", sub {
+ my ($im, $ibx) = @_;
+ my $common = <<"";
+Date: Mon, 9 Mar 2015 09:40:50 +0000
+From: x\@example.com
+To: y\@example.com
+Subject: re
+Message-ID: <$enc_dup>
+MIME-Version: 1.0
+
+ $im->add(PublicInbox::Eml->new($common.<add(PublicInbox::Eml->new($common.<new(<<'EOF');
From oldbug-pre-a0c07cba0e5d8b6a Fri Oct 2 00:00:00 1993
From: a@example.com
@@ -53,6 +83,9 @@ print $fh <{inboxdir}
address = $ibx->{-primary_address}
+[publicinbox "dup"]
+ inboxdir = $dibx->{inboxdir}
+ address = $dibx->{-primary_address}
EOF
close $fh or BAIL_OUT;
}
@@ -221,8 +254,13 @@ like($raw, qr!>\Q$mid\E!s, "Message-ID $mid shown");
}
like($raw, qr/\b3\+ messages\b/, 'thread overview shown');
- $res = $cb->(GET('/v2test/a-mid@b/d/'));
+ $res = $cb->(GET("/dup/$enc_dup/d/"));
is($res->code, 200, '/d/ (diff) endpoint works');
+ $raw = $res->content;
+ like($raw, qr! cr_mismatch\n!s,
+ 'cr_mismatch is only diff context');
+ like($raw, qr!>\-pipe !s, 'pipe diff del line');
+ like($raw, qr!>\+pipe !s, 'pipe diff ins line');
};
test_psgi(sub { $www->call(@_) }, $client1);