lib/PublicInbox/NNTP.pm | 10 +++++++--- diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 6acfcc1bd793ea581aae6ac3bc59d3c527da6762..10a2e158fe739ff171d8ccff4cff2654e5f0f499 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -107,7 +107,6 @@ $self->SUPER::new($sock, $ev); $self->{nntpd} = $nntpd; push @$wbuf, \&greet; $self->{wbuf} = $wbuf; - $self->{rbuf} = ''; update_idle_time($self); $expt ||= PublicInbox::EvCleanup::later(*expire_old); $self; @@ -964,7 +963,7 @@ # only read more requests if we've drained the write buffer, # otherwise we can be buffering infinitely w/o backpressure use constant LINE_MAX => 512; # RFC 977 section 2.3 - my $rbuf = \($self->{rbuf}); + my $rbuf = $self->{rbuf} // (\(my $x = '')); my $r = 1; if (index($$rbuf, "\n") < 0) { @@ -984,6 +983,11 @@ return $self->close if $r < 0; my $len = bytes::length($$rbuf); return $self->close if ($len >= LINE_MAX); + if ($len) { + $self->{rbuf} = $rbuf; + } else { + delete $self->{rbuf}; + } update_idle_time($self); # maybe there's more pipelined data, or we'll have @@ -1002,7 +1006,7 @@ # for graceful shutdown in PublicInbox::Daemon: sub busy { my ($self, $now) = @_; - ($self->{rbuf} ne '' || $self->{wbuf} || not_idle_long($self, $now)); + ($self->{rbuf} || $self->{wbuf} || not_idle_long($self, $now)); } 1;