From: Eric Wong <e@80x24.org>
Date: Tue, 27 Oct 2020 07:54:11 +0000 (+0000)
Subject: v2writable: hoist out write_alternates
X-Git-Tag: v1.7.0~1690
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=71b32a3eb1419d8391b5e7e4bae4046d879f91e4;p=public-inbox.git

v2writable: hoist out write_alternates

We'll be reusing this for external indices and possibly
other places.
---

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index eecc702b..aa812a6b 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -681,6 +681,18 @@ sub done {
 	die $err if $err;
 }
 
+sub write_alternates ($$$) {
+	my ($info_dir, $mode, $out) = @_;
+	my $fh = File::Temp->new(TEMPLATE => 'alt-XXXXXXXX', DIR => $info_dir);
+	my $tmp = $fh->filename;
+	print $fh @$out or die "print $tmp: $!\n";
+	chmod($mode, $fh) or die "fchmod $tmp: $!\n";
+	close $fh or die "close $tmp $!\n";
+	my $alt = "$info_dir/alternates";
+	rename($tmp, $alt) or die "rename $tmp => $alt: $!\n";
+	$fh->unlink_on_destroy(0);
+}
+
 sub fill_alternates ($$) {
 	my ($self, $epoch) = @_;
 
@@ -719,15 +731,8 @@ sub fill_alternates ($$) {
 		}
 	}
 	return unless $new;
-
-	my $fh = File::Temp->new(TEMPLATE => 'alt-XXXXXXXX', DIR => $info_dir);
-	my $tmp = $fh->filename;
-	print $fh join("\n", sort { $alt{$b} <=> $alt{$a} } keys %alt), "\n"
-		or die "print $tmp: $!\n";
-	chmod($mode, $fh) or die "fchmod $tmp: $!\n";
-	close $fh or die "close $tmp $!\n";
-	rename($tmp, $alt) or die "rename $tmp => $alt: $!\n";
-	$fh->unlink_on_destroy(0);
+	write_alternates($info_dir, $mode,
+		[join("\n", sort { $alt{$b} <=> $alt{$a} } keys %alt), "\n"]);
 }
 
 sub git_init {