lib/PublicInbox/ViewDiff.pm | 8 ++------ diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index b91156692976849ac26474c4c35c2acde79c4bd6..fba3d76c7b0cc10473261380c081301f93b5b119 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -124,12 +124,8 @@ if ($pa eq $pb && $pb ne '/dev/null') { $dctx->{Q} = '?b='.uri_escape_path($pb); } else { my @q; - if ($pb ne '/dev/null') { - push @q, 'b='.uri_escape_path($pb); - } - if ($pa ne '/dev/null') { - push @q, 'a='.uri_escape_path($pa); - } + push @q, 'b='.uri_escape_path($pb) if $pb ne '/dev/null'; + push @q, 'a='.uri_escape_path($pa) if $pa ne '/dev/null'; $dctx->{Q} = '?'.join('&', @q); }