lib/PublicInbox/SharedKV.pm | 22 ---------------------- t/shared_kv.t | 13 ++----------- diff --git a/lib/PublicInbox/SharedKV.pm b/lib/PublicInbox/SharedKV.pm index 95a3cb147d2973fa3c91e84593936c487d9723c6..d49a39c1b28ce38d95cb76229a91c1633563c08e 100644 --- a/lib/PublicInbox/SharedKV.pm +++ b/lib/PublicInbox/SharedKV.pm @@ -56,12 +56,6 @@ } $self; } -sub index_values { - my ($self) = @_; - my $lock = $self->lock_for_scope_fast; - $self->dbh($lock)->do('CREATE INDEX IF NOT EXISTS idx_v ON kv (v)'); -} - sub set_maybe { my ($self, $key, $val, $lock) = @_; $lock //= $self->lock_for_scope_fast; @@ -95,22 +89,6 @@ } else { @pfx = (); # [0] may've been undef } map { $_->[0] } @{$self->dbh->selectall_arrayref($sql, undef, @pfx)}; -} - -sub delete_by_val { - my ($self, $val, $lock) = @_; - $lock //= $self->lock_for_scope_fast; - $self->{dbh}->prepare_cached(<<'')->execute($val) + 0; -DELETE FROM kv WHERE v = ? - -} - -sub replace_values { - my ($self, $oldval, $newval, $lock) = @_; - $lock //= $self->lock_for_scope_fast; - $self->{dbh}->prepare_cached(<<'')->execute($newval, $oldval) + 0; -UPDATE kv SET v = ? WHERE v = ? - } sub set { diff --git a/t/shared_kv.t b/t/shared_kv.t index 251b7f3942c88eceb36785f5e486fbdd4fb58cdf..8b4f9c29ea9553971208a52ccf67b27a8e931b8d 100644 --- a/t/shared_kv.t +++ b/t/shared_kv.t @@ -1,5 +1,5 @@ #!perl -w -# Copyright (C) 2020-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ use strict; use v5.10.1; @@ -26,10 +26,6 @@ is($skv->get($dead), $cafe, 'get after xchg'); is($skv->xchg($dead, undef), $cafe, 'xchg to undef'); is($skv->get($dead), undef, 'get after xchg to undef'); is($skv->get($cafe), $dead, 'get after set_maybe'); -ok($skv->index_values, 'index_values works'); -is($skv->replace_values($dead, $cafe), 1, 'replaced one by value'); -is($skv->get($cafe), $cafe, 'value updated'); -is($skv->replace_values($dead, $cafe), 0, 'replaced none by value'); is($skv->xchg($dead, $cafe), undef, 'xchg from undef'); is($skv->count, 2, 'count works'); @@ -39,13 +35,8 @@ while (my ($k, $v) = $sth->fetchrow_array) { $seen{$k} = $v; } is($seen{$dead}, $cafe, '$dead has expected value'); -is($seen{$cafe}, $cafe, '$cafe has expected value'); +is($seen{$cafe}, $dead, '$cafe has expected value'); is(scalar keys %seen, 2, 'iterated through all'); - -is($skv->replace_values($cafe, $dead), 2, 'replaced 2 by value'); -is($skv->delete_by_val('bogus'), 0, 'delete_by_val misses'); -is($skv->delete_by_val($dead), 2, 'delete_by_val hits'); -is($skv->delete_by_val($dead), 0, 'delete_by_val misses again'); undef $skv; ok(!-d $skv_tmpdir, 'temporary dir gone');