From: Eric Wong Date: Mon, 4 Oct 2021 11:12:34 +0000 (-1100) Subject: extsearchidx: favor 20-byte OID comparison X-Git-Tag: v1.7.0~219 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=88344a50f62a39dcb5673b0aa42ebec7ec44bd71;p=public-inbox.git extsearchidx: favor 20-byte OID comparison As with most of our internal-only code, favor smaller comparisons to reduce memory traffic. --- diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index eb7c3d67..3a1856c8 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -120,9 +120,8 @@ sub apply_boost ($$) { || $a->[1] <=> $b->[1] # break ties with {xnum} } @$xr3; - my $top_blob = unpack('H*', $xr3->[0]->[2]); my $new_smsg = $req->{new_smsg}; - return if $top_blob ne $new_smsg->{blob}; # loser + return if $xr3->[0]->[2] ne pack('H*', $new_smsg->{blob}); # loser # replace the old smsg with the more boosted one $new_smsg->{num} = $smsg->{num};