From: Eric Wong <e@80x24.org>
Date: Fri, 11 Jan 2019 03:50:51 +0000 (+0000)
Subject: import: purge: reap fast-export process
X-Git-Tag: v1.2.0~382^2~5
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=9739f3aa67425958f306f8418c0c6fbf186481c3;p=public-inbox.git

import: purge: reap fast-export process

Zombies are bad.
---

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index fd4255cf..7e596abc 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -495,7 +495,7 @@ sub purge_oids {
 	my $old = $self->{'ref'};
 	my $git = $self->{git};
 	my @export = (qw(fast-export --no-data --use-done-feature), $old);
-	my ($rd, $pid) = $git->popen(@export);
+	my $rd = $git->popen(@export);
 	my ($r, $w) = $self->gfi_start;
 	my @buf;
 	my $npurge = 0;
@@ -550,6 +550,7 @@ sub purge_oids {
 			push @buf, $_;
 		}
 	}
+	close $rd or die "close fast-export failed: $?";
 	if (@buf) {
 		$w->print(@buf) or wfail;
 	}