From: Eric Wong <e@80x24.org>
Date: Wed, 30 Jan 2019 07:39:02 +0000 (+0000)
Subject: httpd: a few comments about some fields we set
X-Git-Tag: v1.2.0~399
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=a00def885e67f7da07fe64a92b6fd306d5011d45;p=public-inbox.git

httpd: a few comments about some fields we set

Removing 'psgix.input.buffered' could be a possibility in
the future.
---

diff --git a/lib/PublicInbox/HTTPD.pm b/lib/PublicInbox/HTTPD.pm
index 38517710..b0bf94ad 100644
--- a/lib/PublicInbox/HTTPD.pm
+++ b/lib/PublicInbox/HTTPD.pm
@@ -29,9 +29,16 @@ sub new {
 		'psgi.run_once'	 => Plack::Util::FALSE,
 		'psgi.multithread' => Plack::Util::FALSE,
 		'psgi.multiprocess' => Plack::Util::TRUE,
+
+		# We don't use this anywhere, but we can support
+		# other PSGI apps which might use it:
 		'psgix.input.buffered' => Plack::Util::TRUE,
 
-		# XXX unstable API!
+		# XXX unstable API!, only GitHTTPBackend needs
+		# this to limit git-http-backend(1) parallelism.
+		# The rest of our PSGI code is generic, relying
+		# on "pull" model using "getline" to prevent
+		# over-buffering.
 		'pi-httpd.async' => do {
 			no warnings 'once';
 			*pi_httpd_async