From: Eric Wong <e@80x24.org>
Date: Thu, 16 May 2019 03:40:47 +0000 (+0000)
Subject: search: disable phrase searching, for now
X-Git-Tag: v1.2.0~274
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=c23df198cb3b101c8f0ede73092c8f3dae5eda35;p=public-inbox.git

search: disable phrase searching, for now

There probably needs to be an option to enable this
independently of indexlevel; but for now this is
the safest option.

And, as I discovered during the development of the
indexlevel option, Xapian does a pretty good job of
finding phrases without position data, anyways.
---

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index 090d998b..bb4bd454 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -45,7 +45,11 @@ use constant {
 
 	# n.b. FLAG_PURE_NOT is expensive not suitable for a public website
 	# as it could become a denial-of-service vector
-	QP_FLAGS => FLAG_PHRASE|FLAG_BOOLEAN|FLAG_LOVEHATE|FLAG_WILDCARD,
+	#
+	# FLAG_PHRASE also seems to cause performance problems sometimes.
+	# TODO: make this an option, maybe?
+	# or make indexlevel=medium as default
+	QP_FLAGS => FLAG_BOOLEAN|FLAG_LOVEHATE|FLAG_WILDCARD,
 };
 
 my %bool_pfx_external = (