From: Eric Wong Date: Fri, 5 Jul 2019 22:53:37 +0000 (+0000) Subject: nntp: move LINE_MAX constant to the top X-Git-Tag: v1.2.0~123^2~3 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=f60b310cf3ebabbb7aae6a74fb91bf5946983503;hp=29a0c01a6e53586d5c23bcb0d54c700be1b8a9a4;p=public-inbox.git nntp: move LINE_MAX constant to the top It'll be accessible from other places, and there was no real point in having it declared inside a sub. --- diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 9b8b81ec..631fd3c7 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -18,6 +18,7 @@ PublicInbox::DS->import(qw(now)); use Digest::SHA qw(sha1_hex); use Time::Local qw(timegm timelocal); use constant { + LINE_MAX => 512, # RFC 977 section 2.3 r501 => '501 command syntax error', r221 => '221 Header follows', r224 => '224 Overview information follows (multi-line)', @@ -954,7 +955,6 @@ sub event_step { # only read more requests if we've drained the write buffer, # otherwise we can be buffering infinitely w/o backpressure - use constant LINE_MAX => 512; # RFC 977 section 2.3 my $rbuf = $self->{rbuf} // (\(my $x = '')); my $r = 1;