From b9eab10485eabbf4ac59a6aeb492ac7370e96ba9 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 31 Dec 2015 21:16:39 +0000 Subject: [PATCH] git: add support for qx wrapper This lets us one-line git commands easily like ``, but without having to remember --git-dir or escape arguments. --- lib/PublicInbox/Git.pm | 8 ++++++++ t/git.t | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 0f92dd9a..c406c031 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -117,6 +117,14 @@ sub popen { popen_rd(\@cmd); } +sub qx { + my ($self, @cmd) = @_; + my $fh = $self->popen(@cmd); + return <$fh> if wantarray; + local $/; + <$fh> +} + sub cleanup { my ($self) = @_; _destroy($self, qw(in out pid)); diff --git a/t/git.t b/t/git.t index 0f3dbae3..d7b20d0d 100644 --- a/t/git.t +++ b/t/git.t @@ -129,6 +129,14 @@ if (1) { local $/; is($all, <$fh>, 'entire read matches'); }; + + my $ref = $gcf->qx(qw(cat-file blob), $buf); + is($all, $ref, 'qx read giant single string'); + + my @ref = $gcf->qx(qw(cat-file blob), $buf); + is($all, join('', @ref), 'qx returned array when wanted'); + my $nl = scalar @ref; + ok($nl > 1, "qx returned array length of $nl"); } done_testing(); -- 2.44.0