From 2981d6929f400630e575bcc8fc1851bc531e73e9 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 12 Aug 2015 22:41:10 +0000 Subject: [PATCH] view: consistent ordering of Cc: addresses This fixes a minor test failure in t/cgi.t Tested with perl 5.18.2-2ubuntu1 on Ubuntu 14.04.3 LTS --- lib/PublicInbox/View.pm | 2 +- t/cgi.t | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index c0f3e9f9..30759a30 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -349,7 +349,7 @@ sub html_footer { $to = uri_escape_utf8($to); $subj = uri_escape_utf8($subj); - my $cc = uri_escape_utf8(join(',', values %cc)); + my $cc = uri_escape_utf8(join(',', sort values %cc)); my $href = "mailto:$to?In-Reply-To=$irp&Cc=${cc}&Subject=$subj"; my $idx = $standalone ? " index" : ''; diff --git a/t/cgi.t b/t/cgi.t index b59ca54a..a16ebd8d 100644 --- a/t/cgi.t +++ b/t/cgi.t @@ -120,7 +120,9 @@ EOF like($res->{head}, qr/Status: 200 OK/, "index returns 200"); my $idx = cgi_run("/test/index.html"); - $idx->{body} =~ s!/index.html(\?r=)!/$1!; # dirty... + $idx->{body} =~ s!/index.html(\?r=)!/$1!g; # dirty... + $idx->{body} = [ split(/\n/, $idx->{body}) ]; + $res->{body} = [ split(/\n/, $res->{body}) ]; is_deeply($res, $idx, '/$LISTNAME/ and /$LISTNAME/index.html are nearly identical'); # more checks in t/feed.t -- 2.44.0