From 98e259c8cf893b50fe22f5a5909b2fb54c98d8e0 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 12 Aug 2022 21:30:37 +0000 Subject: [PATCH] pop3: fix off-by-one error when handling `EXPIRE 0' mark_dele already works on the cache offset, so there's no need to make further adjustments to the offset (as we do with POP3 sequence numbers). --- lib/PublicInbox/POP3.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/POP3.pm b/lib/PublicInbox/POP3.pm index bd7dfc65..19fcc434 100644 --- a/lib/PublicInbox/POP3.pm +++ b/lib/PublicInbox/POP3.pm @@ -233,7 +233,7 @@ sub retr_cb { # called by git->cat_async via ibx_async_cat my @tmp = split(/^/m, $bdy); $hdr .= join('', splice(@tmp, 0, $top_nr)); } elsif (exists $self->{expire}) { - $self->{expire} .= pack('S', $off + 1); + $self->{expire} .= pack('S', $off); } $$bref =~ s/^\./../gms; $$bref .= substr($$bref, -2, 2) eq "\r\n" ? ".\r\n" : "\r\n.\r\n"; -- 2.44.0