From a3e3a5f5f34f258744938e60639c0b4d7a362f60 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 25 Mar 2021 06:20:20 +0200 Subject: [PATCH] lei add-external: do not initialize writable store There's no need to create or write lei/store when adding an external, we just need to write to the config file. --- lib/PublicInbox/LeiExternal.pm | 2 -- t/lei-externals.t | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm index 56d6ef39..5e8dc71a 100644 --- a/lib/PublicInbox/LeiExternal.pm +++ b/lib/PublicInbox/LeiExternal.pm @@ -144,8 +144,6 @@ sub add_external_finish { sub lei_add_external { my ($self, $location) = @_; - my $sto = $self->_lei_store(1); - $sto->write_prepare($self); my $opt = $self->{opt}; my $mirror = $opt->{mirror} // do { my @fail; diff --git a/t/lei-externals.t b/t/lei-externals.t index 2045691f..afd90d19 100644 --- a/t/lei-externals.t +++ b/t/lei-externals.t @@ -93,8 +93,7 @@ test_lei(sub { \'added external'); is($lei_out.$lei_err, '', 'no output'); }); - ok(-s $config_file && -e $store_dir, - 'add-external created config + store'); + ok(-s $config_file, 'add-external created config'); my $lcfg = PublicInbox::Config->new($config_file); $cfg->each_inbox(sub { my ($ibx) = @_; -- 2.44.0