From c714cb69920c48c85347474b7b56db578de3980b Mon Sep 17 00:00:00 2001
From: Matt Joiner <anacrolix@gmail.com>
Date: Wed, 3 Feb 2021 19:42:46 +1100
Subject: [PATCH] Fix some go vet warnings

---
 mse/cmd/mse/main.go   | 4 ++--
 test/issue377_test.go | 6 +++---
 tracker/udp_test.go   | 1 +
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/mse/cmd/mse/main.go b/mse/cmd/mse/main.go
index 2d90398a..9485fc2a 100644
--- a/mse/cmd/mse/main.go
+++ b/mse/cmd/mse/main.go
@@ -28,12 +28,12 @@ func mainErr() error {
 			Address        string `arg:"positional"`
 			SecretKey      string `arg:"positional"`
 			InitialPayload []byte
-		} `arg:"subcommand""`
+		} `arg:"subcommand"`
 		Listen *struct {
 			Network    string   `arg:"positional"`
 			Address    string   `arg:"positional"`
 			SecretKeys []string `arg:"positional"`
-		} `arg:"subcommand""`
+		} `arg:"subcommand"`
 	}{
 		CryptoMethod: mse.AllSupportedCrypto,
 	}
diff --git a/test/issue377_test.go b/test/issue377_test.go
index 9e3febe6..4ede3576 100644
--- a/test/issue377_test.go
+++ b/test/issue377_test.go
@@ -119,12 +119,12 @@ func (me *diskFullStorage) Piece(p metainfo.Piece) storage.PieceImpl {
 	}
 }
 
-func (me diskFullStorage) Close() error {
+func (me *diskFullStorage) Close() error {
 	return nil
 }
 
-func (d diskFullStorage) OpenTorrent(info *metainfo.Info, infoHash metainfo.Hash) (storage.TorrentImpl, error) {
-	return &d, nil
+func (d *diskFullStorage) OpenTorrent(info *metainfo.Info, infoHash metainfo.Hash) (storage.TorrentImpl, error) {
+	return d, nil
 }
 
 type pieceImpl struct {
diff --git a/tracker/udp_test.go b/tracker/udp_test.go
index 7a047b1a..d33550f1 100644
--- a/tracker/udp_test.go
+++ b/tracker/udp_test.go
@@ -186,6 +186,7 @@ func TestAnnounceRandomInfoHashThirdParty(t *testing.T) {
 		}(url)
 	}
 	wg.Wait()
+	cancel()
 }
 
 // Check that URLPath option is done correctly.
-- 
2.44.0