From fb4b16193d0d839a0869b2cf2295b7384ef5f1e3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 9 Sep 2021 05:24:58 +0000 Subject: [PATCH] net_reader: do not set "SSL" fields for non-TLS This will save a little bit of memory and IPC I/O for users connecting to localhost and the majority of Tor .onions. --- lib/PublicInbox/NetReader.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index 08166415..b5d14f13 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -79,6 +79,7 @@ sub mic_for ($$$$) { # mic = Mail::IMAPClient Keepalive => 1, # SO_KEEPALIVE %$common, # may set Starttls, Compress, Debug .... }; + $mic_arg->{Ssl} = 1 if $uri->scheme eq 'imaps'; require PublicInbox::IMAPClient; my $mic = mic_new($self, $mic_arg, $sec, $uri) or die "E: <$uri> new: $@\n"; @@ -197,9 +198,9 @@ sub nn_for ($$$$) { # nn = Net::NNTP my $nn_arg = { Port => $uri->port, Host => $host, - SSL => $uri->secure, # snews == nntps %$common, # may Debug .... }; + $nn_arg->{SSL} = 1 if $uri->secure; # snews == nntps my $sa = $self->{-proxy_cli}; %$nn_arg = (%$nn_arg, %$sa) if $sa; my $nn = nn_new($nn_arg, $nntp_opt, $uri); -- 2.44.0