commit 5348aed83e39bd1d450d92d7f627e994c2db6ebf [browse]
Author: Andrew Bonventre
Date: 2018-01-25 11:22:38 -05:00

[release-branch.go1.10] go1.10rc1

Change-Id: I49ec1e476e02d403a4b46f55ea48a9c3cee54efa
Reviewed-on: https://go-review.googlesource.com/89855
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>

commit 1b69d19a422830a5a2c043df36330f30b3df445e [browse]
Author: Daniel Theophanes
Date: 2018-01-24 12:27:59 -08:00

database/sql: fix TestConversions when count > 1

Provide a fresh conversion table for TestConversions as it gets
modified on each test.

Change-Id: I6e2240d0c3455451271a6879e994b82222c3d44c
Reviewed-on: https://go-review.googlesource.com/89595
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

commit e72e69a3f65232b5b8352259d58a31d30e521efa [browse]
Author: Richard Miller
Date: 2018-01-24 16:17:05 Z

os: use the syscall version of Getwd for Plan 9

In Plan 9, each OS thread has its own independent working directory,
so the Go runtime for Plan 9 needs to coordinate Chdir and Getwd
operations to keep the working directory consistent for all goroutines.

The function os.Getwd in Plan 9 should always call syscall.Getwd
to retrieve the common working directory.  Failure to do this was
the cause of (at least some of) the intermittent failures in the
Plan 9 builders with a seemingly spurious "file does not exist"
message, when a thread's working directory had been removed in
another thread.

Change-Id: Ifb834ad025ee39578234ad3b04d08bc98e939291
Reviewed-on: https://go-review.googlesource.com/89575
Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

commit 8d88c9ae074d4128556785b7b77ef169edd97c99 [browse]
Author: Russ Cox
Date: 2018-01-22 20:07:58 -05:00

cmd/go: fix -coverpkg=all with dot imports

If you use -coverpkg=all you get coverage for all packages in the build.
Go 1.9 used a global counter for all the GoCover variables, so that they
were distinct for the entire build. The global counter caused problems
with caching, so we switched to a per-package counter. But now the
GoCover_0 in one package may be dot-imported into another and
conflict with the GoCover_0 in that other package.

Reestablish (overwhelmingly likely) global uniqueness of GoCover
variables by appending an _xxxxxxxxxxxx suffix, where the x's are
the prefix of the SHA256 hash of the import path. The point is only
to avoid accidents, not to defeat people determined to break the tools.

Fixes #23432.

Change-Id: I3088eceebbe35174f2eefe8d558b7c8b59d3eeac
Reviewed-on: https://go-review.googlesource.com/89135
Reviewed-by: Ian Lance Taylor <iant@golang.org>

commit 236abdb46bc13c3e3afe019950d3c3db126190c4 [browse]
Author: Kevin Burke
Date: 2018-01-23 22:19:34 -08:00

go/types: fix spelling mistake in comment

Change-Id: If8609dd7c4bdc261056804759ec254f8af0156df
Reviewed-on: https://go-review.googlesource.com/89417
Reviewed-by: Ian Lance Taylor <iant@golang.org>