src/syscall/exec_unix.go | 20 ++++++-------------- diff --git a/src/syscall/exec_unix.go b/src/syscall/exec_unix.go index 54b18dccd73e266e680d9a5e3250be18ce08ead4..c9c9d1abf3d74f3284530c96675ba567d9d7aee5 100644 --- a/src/syscall/exec_unix.go +++ b/src/syscall/exec_unix.go @@ -153,9 +153,6 @@ if sys == nil { sys = &zeroSysProcAttr } - p[0] = -1 - p[1] = -1 - // Convert args to C form. argv0p, err := BytePtrFromString(argv0) if err != nil { @@ -205,14 +202,17 @@ ForkLock.Lock() // Allocate child status pipe close on exec. if err = forkExecPipe(p[:]); err != nil { - goto error + ForkLock.Unlock() + return 0, err } // Kick off child. pid, err1 = forkAndExecInChild(argv0p, argvp, envvp, chroot, dir, attr, sys, p[1]) if err1 != 0 { - err = Errno(err1) - goto error + Close(p[0]) + Close(p[1]) + ForkLock.Unlock() + return 0, Errno(err1) } ForkLock.Unlock() @@ -244,14 +244,6 @@ } // Read got EOF, so pipe closed on exec, so exec succeeded. return pid, nil - -error: - if p[0] >= 0 { - Close(p[0]) - Close(p[1]) - } - ForkLock.Unlock() - return 0, err } // Combination of fork and exec, careful to be thread safe.