commit 3dbc53ae6ad4e3b93f31d35d98b38f6dda25f4ee [browse]
Author: Andrew Gerrand
Date: 2014-10-01 11:20:15 +10:00

go1.3.3

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/151190043

commit 59c83485dffad603a832218a466e30deba9183a4 [browse]
Author: Andrew Gerrand
Date: 2014-10-01 09:45:12 +10:00

[release-branch.go1.3] doc: document go1.3.3

««« CL 149280044 / ce32e953ef6f
doc: document go1.3.3

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/149280044
»»»

TBR=r
R=golang-codereviews
CC=golang-codereviews
https://golang.org/cl/151170043

commit 32fb19371bc2901910de79444e87ee84779ce24c [browse]
Author: Russ Cox
Date: 2014-09-30 12:43:49 -04:00

[release-branch.go1.3] cmd/5l, cmd/6l, cmd/8l: fix nacl binary corruption bug

««« CL 135050043 / 57dfd03985a9
cmd/5l, cmd/6l, cmd/8l: fix nacl binary corruption bug

NaCl requires the addition of a 32-byte "halt sled" at the end
of the text segment. This means that segtext.len is actually
32 bytes shorter than reality. The computation of the file offset
of the end of the data segment did not take this 32 bytes into
account, so if len and len+32 rounded up (by 64k) to different
values, the symbol table overwrote the last page of the data
segment.

The last page of the data segment is usually the C .string
symbols, which contain the strings used in error prints
by the runtime. So when this happens, your program
probably crashes, and then when it does, you get binary
garbage instead of all the usual prints.

The chance of hitting this with a randomly sized text segment
is 32 in 65536, or 1 in 2048.

If you add or remove ANY code while trying to debug this
problem, you're overwhelmingly likely to bump the text
segment one way or the other and make the bug disappear.

Correct all the computations to use segdata.fileoff+segdata.filelen
instead of trying to rederive segdata.fileoff.

This fixes the failure during the nacl/amd64p32 build.

TBR=iant
CC=golang-codereviews
https://golang.org/cl/135050043
»»»

LGTM=bradfitz
R=golang-codereviews
CC=adg, bradfitz, golang-codereviews, iant
https://golang.org/cl/151150044

commit c09c8bb32595fc4b0bfcb1f6cedaf01040b05e1a [browse]
Author: Russ Cox
Date: 2014-09-30 12:34:36 -04:00

[release-branch.go1.3] nacltest.bash: unset GOROOT

The GOROOT baked into the go command being run is correct.
The GOROOT in the environment may not be. Remove it.

Fixes nacltest.bash if you have GOROOT set elsewhere.

This is already fixed in the default branch.

LGTM=r
R=golang-codereviews, r
CC=bradfitz, golang-codereviews, iant
https://golang.org/cl/147380044

commit fcfb7aaf2ed8ffbe22c7c40e8536523c4ae599cb [browse]
Author: Russ Cox
Date: 2014-09-29 22:50:34 -04:00

[release-branch.go1.3] runtime: fix GOTRACEBACK reading on Windows, Plan 9

Only Unix was resetting the traceback_cache variable
after initializing the environment. Reset it on all systems
by resetting in parsedebugvars.

Fixes #8813.

LGTM=adg, alex.brainman
R=golang-codereviews, adg, alex.brainman
CC=golang-codereviews, iant, r
https://golang.org/cl/152760043