do.go | 3 +++ doc/news.texi | 7 +++++++ ood.go | 6 ++---- t/apenwarr-120-defaults-flat.t | 1 - t/apenwarr/120-defaults-flat/.gitignore | 6 ------ t/apenwarr/120-defaults-flat/all.do | 1 - t/apenwarr/120-defaults-flat/c.c.c.b.b.a | 1 - t/apenwarr/120-defaults-flat/c.do | 3 --- t/apenwarr/120-defaults-flat/clean.do | 2 -- t/apenwarr/120-defaults-flat/default.b.do | 10 ---------- t/apenwarr/120-defaults-flat/default.c.c.do | 4 ---- t/apenwarr/120-defaults-flat/default.c.do | 4 ---- t/apenwarr/120-defaults-flat/default.do | 4 ---- t/goredo-rel-ifcreate.t | 24 ++++++++++++------------ usage.go | 2 +- diff --git a/do.go b/do.go index 6dbbba24b8a61d8e5e40c0145ed52dbaf1567ba9112274b5b2dd722d4ab75c93..96132ae7d28623083c1df9c0f3e1be721a4f08e82b694c1f2735b25863ba7d24 100644 --- a/do.go +++ b/do.go @@ -34,6 +34,9 @@ func existsDo(w io.Writer, fdDepName, cwd, pth string) (bool, error) { if FileExists(path.Join(cwd, pth)) { return true, nil } + if w == nil { + return false, nil + } return false, ifcreate(w, fdDepName, pth) } diff --git a/doc/news.texi b/doc/news.texi index 72cfc3a79a507ef4f36384145be307e045ae65686d68dee762e3f1a511dd6fc9..f8c3c7969e6178564aff12f67e4c22d525a4e640a0ea93c16c6a997a16a36ccf 100644 --- a/doc/news.texi +++ b/doc/news.texi @@ -2,6 +2,13 @@ @node News @cindex news @unnumbered News +@anchor{Release 2_7_0} +@section Release 2.7.0 +@itemize +@item + Proper @file{.do} file searching during source file determination. +@end itemize + @anchor{Release 2_6_5} @section Release 2.6.5 @itemize diff --git a/ood.go b/ood.go index 232f575e74a19b9bc27f8ffe79f21ed22e89bb3ee2839015db5ab8b005ee52a0..dc45d317f906358beb54abc700390c4b1f456b6092c12152f56e5316080c0042 100644 --- a/ood.go +++ b/ood.go @@ -74,10 +74,8 @@ func isSrc(tgt *Tgt) bool { if !FileExists(tgt.a) { return false } - if FileExists(tgt.a + ".do") { - return false - } - if FileExists(tgt.dep) { + tgtH, tgtT := pathSplit(tgt.a) + if do, _, _ := findDo(nil, tgt.a, tgtH, tgtT); do != "" { return false } return true diff --git a/t/apenwarr-120-defaults-flat.t b/t/apenwarr-120-defaults-flat.t deleted file mode 120000 index 5b698cda62b3e2881aa0458ad0d715053fcdeb6dc55ab0dc958fa5daf2a392f8..0000000000000000000000000000000000000000 --- a/t/apenwarr-120-defaults-flat.t +++ /dev/null @@ -1 +0,0 @@ -apenwarr/wrapper.rc \ No newline at end of file diff --git a/t/apenwarr/120-defaults-flat/.gitignore b/t/apenwarr/120-defaults-flat/.gitignore deleted file mode 100644 index 8a8d4d4eb08e4a314e784bb2dfda89c56356ebbbe3321bef925445a6ff9ad2db..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/.gitignore +++ /dev/null @@ -1,6 +0,0 @@ -c -c.c -c.c.c -c.c.c.b -c.c.c.b.b -d diff --git a/t/apenwarr/120-defaults-flat/all.do b/t/apenwarr/120-defaults-flat/all.do deleted file mode 100644 index 38334b11ead319f8a202b7270792291945312011340bb09040eef220521db762..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/all.do +++ /dev/null @@ -1 +0,0 @@ -redo-ifchange c d diff --git a/t/apenwarr/120-defaults-flat/c.c.c.b.b.a b/t/apenwarr/120-defaults-flat/c.c.c.b.b.a deleted file mode 100644 index 8751962d9af200ee221f0940651faa11cd11a4c13ad0809adc5bafe54509c5b6..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/c.c.c.b.b.a +++ /dev/null @@ -1 +0,0 @@ -chicken diff --git a/t/apenwarr/120-defaults-flat/c.do b/t/apenwarr/120-defaults-flat/c.do deleted file mode 100644 index 3c06f1bc1db6783a09d31207e4a4a730c34bee02a1509f0c8dd6c2605117311e..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/c.do +++ /dev/null @@ -1,3 +0,0 @@ -redo-ifchange $1.c -echo c.do -cat $1.c diff --git a/t/apenwarr/120-defaults-flat/clean.do b/t/apenwarr/120-defaults-flat/clean.do deleted file mode 100644 index 3bd22cbd374504c3507a3ab5c9e7b01c7aacf154e74cd8abaf943ee98e7b5ccf..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/clean.do +++ /dev/null @@ -1,2 +0,0 @@ -rm -f c c.c c.c.c c.c.c.b c.c.c.b.b d \ - *~ .*~ diff --git a/t/apenwarr/120-defaults-flat/default.b.do b/t/apenwarr/120-defaults-flat/default.b.do deleted file mode 100644 index 408d58bb8140727443819f0819dc5733435c41ac9b1ff029349cf2643612b0f3..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/default.b.do +++ /dev/null @@ -1,10 +0,0 @@ -if [ -e "$1.a" -o -e "default${1#$2}.a" ]; then - redo-ifchange "$1.a" - echo a-to-b - cat "$1.a" -else - redo-ifchange "$1.b" - echo b-to-b - cat "$1.b" -fi -../sleep 1.1 diff --git a/t/apenwarr/120-defaults-flat/default.c.c.do b/t/apenwarr/120-defaults-flat/default.c.c.do deleted file mode 100644 index 3537f61ce4c12c7751c167bb0604f969035fc38156c9d105f3519f2654f2c85b..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/default.c.c.do +++ /dev/null @@ -1,4 +0,0 @@ -redo-ifchange $1.b -echo b-to-cc -cat $1.b -../sleep 1.2 diff --git a/t/apenwarr/120-defaults-flat/default.c.do b/t/apenwarr/120-defaults-flat/default.c.do deleted file mode 100644 index 225b4d0b6e25e1f63d0f9f7e24a1b282ecdc3a1a06e6c4b24a07ce8b11b3d620..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/default.c.do +++ /dev/null @@ -1,4 +0,0 @@ -redo-ifchange $1.c -echo c-to-c -cat $1.c -../sleep 1.3 diff --git a/t/apenwarr/120-defaults-flat/default.do b/t/apenwarr/120-defaults-flat/default.do deleted file mode 100644 index 1afdd37b8d54d3f8a0d8869323ffad2300aaf435e62dbb0409beafa94f92ea81..0000000000000000000000000000000000000000 --- a/t/apenwarr/120-defaults-flat/default.do +++ /dev/null @@ -1,4 +0,0 @@ -redo-ifchange c -echo default-rule -cat c -../sleep 1.4 diff --git a/t/goredo-rel-ifcreate.t b/t/goredo-rel-ifcreate.t index 825868f750a48d62ee746e7f95ec9f2a84942c4c164b4cbd78727fc98b8ee9a3..7d5d39c17aac3dd05deaf6e3501a85ddd96203177ac28ff66c310f924777c546 100755 --- a/t/goredo-rel-ifcreate.t +++ b/t/goredo-rel-ifcreate.t @@ -4,24 +4,24 @@ test_description="Proper relative to DirPrefix ifcreate paths" . $SHARNESS_TEST_SRCDIR/sharness.sh export REDO_TOP_DIR="`pwd`" REDO_NO_PROGRESS=1 -mkdir -p a/b/c a/c -echo whatever >a/b/c/dep -cat >a/b/default.do <a/b/dep +cat >a/b/c/default.do <