From c0a888ee179dd044c99cef7ffc2c8fe18b9243b2 Mon Sep 17 00:00:00 2001 From: Matt Joiner Date: Mon, 13 Dec 2021 12:12:30 +1100 Subject: [PATCH] Tidy up request heaping comments --- requesting.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/requesting.go b/requesting.go index a3a7e1c3..59f6693c 100644 --- a/requesting.go +++ b/requesting.go @@ -171,9 +171,6 @@ func (p *Peer) getDesiredRequestState() (desired desiredRequestState) { allowedFast := p.peerAllowedFast.ContainsInt(pieceIndex) p.t.piece(pieceIndex).undirtiedChunksIter.Iter(func(ci request_strategy.ChunkIndex) { r := p.t.pieceRequestIndexOffset(pieceIndex) + ci - // if p.t.pendingRequests.Get(r) != 0 && !p.requestState.Requests.Contains(r) { - // return - // } if !allowedFast { // We must signal interest to request this. TODO: We could set interested if the // peers pieces (minus the allowed fast set) overlap with our missing pieces if @@ -189,7 +186,7 @@ func (p *Peer) getDesiredRequestState() (desired desiredRequestState) { } } if p.requestState.Cancelled.Contains(r) { - // Can't re-request. + // Can't re-request while awaiting acknowledgement. return } requestHeap.requestIndexes = append(requestHeap.requestIndexes, r) -- 2.44.0