From fe43ce07c8fe026f82d2f38033b6462013aa5d98 Mon Sep 17 00:00:00 2001 From: Matt Joiner Date: Sun, 20 Feb 2022 16:15:45 +1100 Subject: [PATCH] Quote UDP tracker response error bodies with %#q --- tracker/udp/client.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tracker/udp/client.go b/tracker/udp/client.go index c7f9392d..0095a912 100644 --- a/tracker/udp/client.go +++ b/tracker/udp/client.go @@ -164,7 +164,9 @@ func (cl *Client) request(ctx context.Context, action Action, body []byte) (resp respBody = dr.Body addr = dr.Addr } else if dr.Header.Action == ActionError { - err = fmt.Errorf("error response: %s", dr.Body) + // I've seen "Connection ID mismatch.^@" in less and other tools, I think they're just + // not handling a trailing \x00 nicely. + err = fmt.Errorf("error response: %#q", dr.Body) } else { err = fmt.Errorf("unexpected response action %v", dr.Header.Action) } -- 2.44.0