X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=blobdiff_plain;f=lib%2FPublicInbox%2FDaemon.pm;h=292bc339a73c086f06c4a34bc47f63e3e962b4ed;hp=9e177f2eb39bff8b0c9d47b8ad63e6b05b28e6a9;hb=55b707d788ce13696e4411389583e720ea6dab01;hpb=dcee95db6431f313f7fd1b2408390f3ae3718568 diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm index 9e177f2e..292bc339 100644 --- a/lib/PublicInbox/Daemon.pm +++ b/lib/PublicInbox/Daemon.pm @@ -1,33 +1,87 @@ -# Copyright (C) 2015 all contributors -# License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt) -package PublicInbox::Daemon; # empty class :p - -# contains common daemon code for the nntpd server. +# Copyright (C) 2015-2019 all contributors +# License: AGPL-3.0+ +# contains common daemon code for the nntpd and httpd servers. # This may be used for read-only IMAP server if we decide to implement it. -package main; +package PublicInbox::Daemon; use strict; use warnings; use Getopt::Long qw/:config gnu_getopt no_ignore_case auto_abbrev/; -require Danga::Socket; -require POSIX; +use IO::Handle; # ->autoflush +use IO::Socket; +use POSIX qw(WNOHANG :signal_h); +use Socket qw(IPPROTO_TCP SOL_SOCKET); +sub SO_ACCEPTFILTER () { 0x1000 } +use Cwd qw/abs_path/; +STDOUT->autoflush(1); +STDERR->autoflush(1); +use PublicInbox::DS qw(now); +use PublicInbox::Syscall qw(SFD_NONBLOCK); require PublicInbox::Listener; +require PublicInbox::ParentPipe; +require PublicInbox::Sigfd; my @CMD; -my $set_user; +my ($set_user, $oldset, $newset); my (@cfg_listen, $stdout, $stderr, $group, $user, $pid_file, $daemonize); my $worker_processes = 1; my @listeners; my %pids; -my %listener_names; +my %tls_opt; # scheme://sockname => args for IO::Socket::SSL->start_SSL my $reexec_pid; -my $cleanup; my ($uid, $gid); -END { $cleanup->() if $cleanup }; +my ($default_cert, $default_key); +my %KNOWN_TLS = ( 443 => 'https', 563 => 'nntps' ); +my %KNOWN_STARTTLS = ( 119 => 'nntp' ); + +sub accept_tls_opt ($) { + my ($opt_str) = @_; + # opt_str: opt1=val1,opt2=val2 (opt may repeat for multi-value) + require PublicInbox::TLS; + my $o = {}; + # allow ',' as delimiter since '&' is shell-unfriendly + foreach (split(/[,&]/, $opt_str)) { + my ($k, $v) = split(/=/, $_, 2); + push @{$o->{$k} ||= []}, $v; + } + + # key may be a part of cert. At least + # p5-io-socket-ssl/example/ssl_server.pl has this fallback: + $o->{cert} //= [ $default_cert ]; + $o->{key} //= defined($default_key) ? [ $default_key ] : $o->{cert}; + my %ctx_opt = (SSL_server => 1); + # parse out hostname:/path/to/ mappings: + foreach my $k (qw(cert key)) { + my $x = $ctx_opt{'SSL_'.$k.'_file'} = {}; + foreach my $path (@{$o->{$k}}) { + my $host = ''; + $path =~ s/\A([^:]+):// and $host = $1; + $x->{$host} = $path; + } + } + my $ctx = IO::Socket::SSL::SSL_Context->new(%ctx_opt) or + die 'SSL_Context->new: '.PublicInbox::TLS::err(); + + # save ~34K per idle connection (cf. SSL_CTX_set_mode(3ssl)) + # RSS goes from 346MB to 171MB with 10K idle NNTPS clients on amd64 + # cf. https://rt.cpan.org/Ticket/Display.html?id=129463 + my $mode = eval { Net::SSLeay::MODE_RELEASE_BUFFERS() }; + if ($mode && $ctx->{context}) { + eval { Net::SSLeay::CTX_set_mode($ctx->{context}, $mode) }; + warn "W: $@ (setting SSL_MODE_RELEASE_BUFFERS)\n" if $@; + } + + { SSL_server => 1, SSL_startHandshake => 0, SSL_reuse_ctx => $ctx }; +} + +sub sig_setmask { sigprocmask(SIG_SETMASK, @_) or die "sigprocmask: $!" } sub daemon_prepare ($) { my ($default_listen) = @_; + my $listener_names = {}; # sockname => IO::Handle + $oldset = POSIX::SigSet->new(); + $newset = POSIX::SigSet->new(); + $newset->fillset or die "fillset: $!"; + sig_setmask($newset, $oldset); @CMD = ($0, @ARGV); - $SIG{HUP} = $SIG{USR1} = $SIG{USR2} = $SIG{PIPE} = - $SIG{TTIN} = $SIG{TTOU} = $SIG{WINCH} = 'IGNORE'; my %opts = ( 'l|listen=s' => \@cfg_listen, '1|stdout=s' => \$stdout, @@ -37,44 +91,126 @@ sub daemon_prepare ($) { 'u|user=s' => \$user, 'g|group=s' => \$group, 'D|daemonize' => \$daemonize, + 'cert=s' => \$default_cert, + 'key=s' => \$default_key, ); GetOptions(%opts) or die "bad command-line args\n"; if (defined $pid_file && $pid_file =~ /\.oldbin\z/) { die "--pid-file cannot end with '.oldbin'\n"; } - @listeners = inherit(); + @listeners = inherit($listener_names); + + # allow socket-activation users to set certs once and not + # have to configure each socket: + my @inherited_names = keys(%$listener_names) if defined($default_cert); + # ignore daemonize when inheriting $daemonize = undef if scalar @listeners; push @cfg_listen, $default_listen unless (@listeners || @cfg_listen); foreach my $l (@cfg_listen) { - next if $listener_names{$l}; # already inherited - require IO::Socket::INET6; # works for IPv4, too - my %o = ( - LocalAddr => $l, - ReuseAddr => 1, - Proto => 'tcp', - ); - if (my $s = IO::Socket::INET6->new(%o)) { - $listener_names{sockname($s)} = $s; - push @listeners, $s; + my $orig = $l; + my $scheme = ''; + if ($l =~ s!\A([^:]+)://!!) { + $scheme = $1; + } elsif ($l =~ /\A(?:\[[^\]]+\]|[^:]+):([0-9])+/) { + my $s = $KNOWN_TLS{$1} // $KNOWN_STARTTLS{$1}; + $scheme = $s if defined $s; + } + if ($l =~ s!/?\?(.+)\z!!) { + $tls_opt{"$scheme://$l"} = accept_tls_opt($1); + } elsif (defined($default_cert)) { + $tls_opt{"$scheme://$l"} = accept_tls_opt(''); + } elsif ($scheme =~ /\A(?:nntps|https)\z/) { + die "$orig specified w/o cert=\n"; + } + # TODO: use scheme to load either NNTP.pm or HTTP.pm + + next if $listener_names->{$l}; # already inherited + my (%o, $sock_pkg); + if (index($l, '/') == 0) { + $sock_pkg = 'IO::Socket::UNIX'; + eval "use $sock_pkg"; + die $@ if $@; + %o = (Type => SOCK_STREAM, Peer => $l); + if (-S $l) { + my $c = $sock_pkg->new(%o); + if (!defined($c) && $!{ECONNREFUSED}) { + unlink $l or die +"failed to unlink stale socket=$l: $!\n"; + } # else: let the bind fail + } + $o{Local} = delete $o{Peer}; } else { - warn "error binding $l: $!\n"; + # both work for IPv4, too + for (qw(IO::Socket::IP IO::Socket::INET6)) { + $sock_pkg = $_; + eval "use $sock_pkg"; + $@ or last; + } + die $@ if $@; + %o = (LocalAddr => $l, ReuseAddr => 1, Proto => 'tcp'); + } + $o{Listen} = 1024; + my $prev = umask 0000; + my $s = eval { $sock_pkg->new(%o) }; + warn "error binding $l: $! ($@)\n" unless $s; + umask $prev; + if ($s) { + $listener_names->{sockname($s)} = $s; + $s->blocking(0); + push @listeners, $s; } } - die 'No listeners bound' unless @listeners; + + # cert/key options in @cfg_listen takes precedence when inheriting, + # but map well-known inherited ports if --listen isn't specified + # at all + for my $sockname (@inherited_names) { + $sockname =~ /:([0-9]+)\z/ or next; + if (my $scheme = $KNOWN_TLS{$1}) { + $tls_opt{"$scheme://$sockname"} ||= accept_tls_opt(''); + } elsif (($scheme = $KNOWN_STARTTLS{$1})) { + next if $tls_opt{"$scheme://$sockname"}; + $tls_opt{''} ||= accept_tls_opt(''); + } + } + + die "No listeners bound\n" unless @listeners; +} + +sub check_absolute ($$) { + my ($var, $val) = @_; + if (defined $val && index($val, '/') != 0) { + die +"--$var must be an absolute path when using --daemonize: $val\n"; + } } sub daemonize () { - chdir '/' or die "chdir failed: $!\n"; - open(STDIN, '+<', '/dev/null') or die "redirect stdin failed: $!\n"; + if ($daemonize) { + foreach my $i (0..$#ARGV) { + my $arg = $ARGV[$i]; + next unless -e $arg; + $ARGV[$i] = abs_path($arg); + } + check_absolute('stdout', $stdout); + check_absolute('stderr', $stderr); + check_absolute('pid-file', $pid_file); + + chdir '/' or die "chdir failed: $!"; + } return unless (defined $pid_file || defined $group || defined $user || $daemonize); - require Net::Server::Daemonize; + eval { require Net::Server::Daemonize }; + if ($@) { + die +"Net::Server required for --pid-file, --group, --user, and --daemonize\n$@\n"; + } Net::Server::Daemonize::check_pid_file($pid_file) if defined $pid_file; $uid = Net::Server::Daemonize::get_uid($user) if defined $user; @@ -89,52 +225,65 @@ sub daemonize () { # The upgrade will create the ".oldbin" pid file in the # same directory as the given pid file. $uid and $set_user = sub { + $set_user = undef; Net::Server::Daemonize::set_user($uid, $gid); }; if ($daemonize) { - my ($pid, $err) = do_fork(); - die "could not fork: $err\n" unless defined $pid; + my $pid = fork; + die "could not fork: $!\n" unless defined $pid; exit if $pid; + open(STDIN, '+<', '/dev/null') or + die "redirect stdin failed: $!\n"; open STDOUT, '>&STDIN' or die "redirect stdout failed: $!\n"; open STDERR, '>&STDIN' or die "redirect stderr failed: $!\n"; POSIX::setsid(); - ($pid, $err) = do_fork(); - die "could not fork: $err\n" unless defined $pid; + $pid = fork; + die "could not fork: $!\n" unless defined $pid; exit if $pid; } - if (defined $pid_file) { - write_pid($pid_file); - my $unlink_pid = $$; - $cleanup = sub { - unlink_pid_file_safe_ish($unlink_pid, $pid_file); - }; - } + return unless defined $pid_file; + + write_pid($pid_file); + # for ->DESTROY: + bless { pid => $$, pid_file => $pid_file }, __PACKAGE__; } -sub worker_quit () { +sub worker_quit { # $_[0] = signal name or number (unused) # killing again terminates immediately: exit unless @listeners; + $_->close foreach @listeners; # call PublicInbox::DS::close @listeners = (); - - # give slow clients 30s to finish reading/writing whatever - Danga::Socket->AddTimer(30, sub { exit }); - + my $proc_name; + my $warn = 0; # drop idle connections and try to quit gracefully - Danga::Socket->SetPostLoopCallback(sub { + PublicInbox::DS->SetPostLoopCallback(sub { my ($dmap, undef) = @_; my $n = 0; + my $now = now(); foreach my $s (values %$dmap) { - if ($s->can('busy') && $s->busy) { - $n = 1; + $s->can('busy') or next; + if ($s->busy($now)) { + ++$n; } else { # close as much as possible, early as possible $s->close; } } + if ($n) { + if (($warn + 5) < now()) { + warn "$$ quitting, $n client(s) left\n"; + $warn = now(); + } + unless (defined $proc_name) { + $proc_name = (split(/\s+/, $0))[0]; + $proc_name =~ s!\A.*?([^/]+)\z!$1!; + } + $0 = "$proc_name quitting, $n client(s) left"; + } $n; # true: loop continues, false: loop breaks }); } @@ -156,32 +305,72 @@ sub reopen_logs { sub sockname ($) { my ($s) = @_; - my $n = getsockname($s) or return; - my ($port, $addr); - if (length($n) >= 28) { - require Socket6; - ($port, $addr) = Socket6::unpack_sockaddr_in6($n); - } else { - ($port, $addr) = Socket::sockaddr_in($n); + my $addr = getsockname($s) or return; + my ($host, $port) = host_with_port($addr); + if ($port == 0 && $host eq '127.0.0.1') { + my ($path) = Socket::sockaddr_un($addr); + return $path; } - if (length($addr) == 4) { - $n = Socket::inet_ntoa($addr) - } else { - $n = '['.Socket6::inet_ntop(Socket6::AF_INET6(), $addr).']'; + "$host:$port"; +} + +sub unpack_ipv6 ($) { + my ($addr) = @_; + my ($port, $host); + + # Socket.pm in Perl 5.14+ supports IPv6: + eval { + ($port, $host) = Socket::unpack_sockaddr_in6($addr); + $host = Socket::inet_ntop(Socket::AF_INET6(), $host); + }; + + if ($@) { + # Perl 5.12 or earlier? SpamAssassin and Net::Server use + # Socket6, so it may be installed on our system, already + # (otherwise die here): + require Socket6; + + ($port, $host) = Socket6::unpack_sockaddr_in6($addr); + $host = Socket6::inet_ntop(Socket6::AF_INET6(), $host); } - $n .= ":$port"; + ($host, $port); +} + +sub host_with_port ($) { + my ($addr) = @_; + my ($port, $host); + + # this eval will die on Unix sockets: + eval { + if (length($addr) >= 28) { + ($host, $port) = unpack_ipv6($addr); + $host = "[$host]"; + } else { + ($port, $host) = Socket::sockaddr_in($addr); + $host = Socket::inet_ntoa($host); + } + }; + $@ ? ('127.0.0.1', 0) : ($host, $port); } -sub inherit () { +sub inherit ($) { + my ($listener_names) = @_; return () if ($ENV{LISTEN_PID} || 0) != $$; my $fds = $ENV{LISTEN_FDS} or return (); my $end = $fds + 2; # LISTEN_FDS_START - 1 my @rv = (); foreach my $fd (3..$end) { - my $s = IO::Handle->new; - $s->fdopen($fd, 'r'); + my $s = IO::Handle->new_from_fd($fd, 'r'); if (my $k = sockname($s)) { - $listener_names{$k} = $s; + if ($s->blocking) { + $s->blocking(0); + warn <<""; +Inherited socket (fd=$fd) is blocking, making it non-blocking. +Set 'NonBlocking = true' in the systemd.service unit to avoid stalled +processes when multiple service instances start. + + } + $listener_names->{$k} = $s; push @rv, $s; } else { warn "failed to inherit fd=$fd (LISTEN_FDS=$fds)"; @@ -190,7 +379,7 @@ sub inherit () { @rv } -sub upgrade () { +sub upgrade { # $_[0] = signal name or number (unused) if ($reexec_pid) { warn "upgrade in-progress: $reexec_pid\n"; return; @@ -204,9 +393,9 @@ sub upgrade () { $pid_file .= '.oldbin'; write_pid($pid_file); } - my ($pid, $err) = do_fork(); + my $pid = fork; unless (defined $pid) { - warn "fork failed: $err\n"; + warn "fork failed: $!\n"; return; } if ($pid == 0) { @@ -231,19 +420,6 @@ sub kill_workers ($) { } } -sub do_fork () { - my $new = POSIX::SigSet->new; - $new->fillset; - my $old = POSIX::SigSet->new; - POSIX::sigprocmask(&POSIX::SIG_BLOCK, $new, $old) or - die "SIG_BLOCK: $!\n"; - my $pid = fork; - my $err = $!; - POSIX::sigprocmask(&POSIX::SIG_SETMASK, $old) or - die "SIG_SETMASK: $!\n"; - ($pid, $err); -} - sub upgrade_aborted ($) { my ($p) = @_; warn "reexec PID($p) died with: $?\n"; @@ -251,16 +427,16 @@ sub upgrade_aborted ($) { return unless $pid_file; my $file = $pid_file; - $file =~ s/\.oldbin\z// or die "BUG: no '.oldbin' suffix in $file\n"; + $file =~ s/\.oldbin\z// or die "BUG: no '.oldbin' suffix in $file"; unlink_pid_file_safe_ish($$, $pid_file); $pid_file = $file; eval { write_pid($pid_file) }; warn $@, "\n" if $@; } -sub reap_children () { +sub reap_children { # $_[0] = 'CHLD' or POSIX::SIGCHLD() while (1) { - my $p = waitpid(-1, &POSIX::WNOHANG) or return; + my $p = waitpid(-1, WNOHANG) or return; if (defined $reexec_pid && $p == $reexec_pid) { upgrade_aborted($p); } elsif (defined(my $id = delete $pids{$p})) { @@ -278,6 +454,7 @@ sub unlink_pid_file_safe_ish ($$) { return unless defined $unlink_pid && $unlink_pid == $$; open my $fh, '<', $file or return; + local $/ = "\n"; defined(my $read_pid = <$fh>) or return; chomp $read_pid; if ($read_pid == $unlink_pid) { @@ -285,107 +462,187 @@ sub unlink_pid_file_safe_ish ($$) { } } +sub master_quit ($) { + exit unless @listeners; + @listeners = (); + kill_workers($_[0]); +} + sub master_loop { - pipe(my ($p0, $p1)) or die "failed to create parent-pipe: $!\n"; - pipe(my ($r, $w)) or die "failed to create self-pipe: $!\n"; - IO::Handle::blocking($w, 0); + pipe(my ($p0, $p1)) or die "failed to create parent-pipe: $!"; + # 1031: F_SETPIPE_SZ, 4096: page size + fcntl($p1, 1031, 4096) if $^O eq 'linux'; my $set_workers = $worker_processes; - my @caught; - my $master_pid = $$; - foreach my $s (qw(HUP CHLD QUIT INT TERM USR1 USR2 TTIN TTOU WINCH)) { - $SIG{$s} = sub { - return if $$ != $master_pid; - push @caught, $s; - syswrite($w, '.'); - }; - } reopen_logs(); - # main loop - while (1) { - while (my $s = shift @caught) { - if ($s eq 'USR1') { - reopen_logs(); - kill_workers($s); - } elsif ($s eq 'USR2') { - upgrade(); - } elsif ($s =~ /\A(?:QUIT|TERM|INT)\z/) { - # drops pipes and causes children to die - exit - } elsif ($s eq 'WINCH') { + my $ignore_winch; + my $sig = { + USR1 => sub { reopen_logs(); kill_workers($_[0]); }, + USR2 => \&upgrade, + QUIT => \&master_quit, + INT => \&master_quit, + TERM => \&master_quit, + WINCH => sub { + return if $ignore_winch || !@listeners; + if (-t STDIN || -t STDOUT || -t STDERR) { + $ignore_winch = 1; + warn < $worker_processes) { - ++$worker_processes; - } else { - $worker_processes = ++$set_workers; - } - } elsif ($s eq 'TTOU') { - if ($set_workers > 0) { - $worker_processes = --$set_workers; - } - } elsif ($s eq 'CHLD') { - reap_children(); } + }, + HUP => sub { + return unless @listeners; + $worker_processes = $set_workers; + kill_workers($_[0]); + }, + TTIN => sub { + return unless @listeners; + if ($set_workers > $worker_processes) { + ++$worker_processes; + } else { + $worker_processes = ++$set_workers; + } + }, + TTOU => sub { + $worker_processes = --$set_workers if $set_workers > 0; + }, + CHLD => \&reap_children, + }; + my $sigfd = PublicInbox::Sigfd->new($sig, 0); + local %SIG = (%SIG, %$sig) if !$sigfd; + sig_setmask($oldset) if !$sigfd; + while (1) { # main loop + my $n = scalar keys %pids; + unless (@listeners) { + exit if $n == 0; + $set_workers = $worker_processes = $n = 0; } - my $n = scalar keys %pids; if ($n > $worker_processes) { while (my ($k, $v) = each %pids) { kill('TERM', $k) if $v >= $worker_processes; } $n = $worker_processes; } - foreach my $i ($n..($worker_processes - 1)) { - my ($pid, $err) = do_fork(); - if (!defined $pid) { - warn "failed to fork worker[$i]: $err\n"; - } elsif ($pid == 0) { - $set_user->() if $set_user; - return $p0; # run normal work code - } else { - warn "PID=$pid is worker[$i]\n"; - $pids{$pid} = $i; + my $want = $worker_processes - 1; + if ($n <= $want) { + sig_setmask($newset) if !$sigfd; + for my $i ($n..$want) { + my $pid = fork; + if (!defined $pid) { + warn "failed to fork worker[$i]: $!\n"; + } elsif ($pid == 0) { + $set_user->() if $set_user; + return $p0; # run normal work code + } else { + warn "PID=$pid is worker[$i]\n"; + $pids{$pid} = $i; + } } + sig_setmask($oldset) if !$sigfd; + } + + if ($sigfd) { # Linux and IO::KQueue users: + $sigfd->wait_once; + } else { # wake up every second + sleep(1); } - # just wait on signal events here: - sysread($r, my $buf, 8); } exit # never gets here, just for documentation } -sub daemon_loop ($$) { - my ($refresh, $post_accept) = @_; +sub tls_start_cb ($$) { + my ($opt, $orig_post_accept) = @_; + sub { + my ($io, $addr, $srv) = @_; + my $ssl = IO::Socket::SSL->start_SSL($io, %$opt); + $orig_post_accept->($ssl, $addr, $srv); + } +} + +sub defer_accept ($$) { + my ($s, $af_name) = @_; + return unless defined $af_name; + if ($^O eq 'linux') { + my $x = getsockopt($s, IPPROTO_TCP, Socket::TCP_DEFER_ACCEPT()); + return unless defined $x; # may be Unix socket + my $sec = unpack('i', $x); + return if $sec > 0; # systemd users may set a higher value + setsockopt($s, IPPROTO_TCP, Socket::TCP_DEFER_ACCEPT(), 1); + } elsif ($^O eq 'freebsd') { + my $x = getsockopt($s, SOL_SOCKET, SO_ACCEPTFILTER); + return if defined $x; # don't change if set + my $accf_arg = pack('a16a240', $af_name, ''); + setsockopt($s, SOL_SOCKET, SO_ACCEPTFILTER, $accf_arg); + } +} + +sub daemon_loop ($$$$) { + my ($refresh, $post_accept, $nntpd, $af_default) = @_; + my %post_accept; + while (my ($k, $v) = each %tls_opt) { + if ($k =~ s!\A(?:nntps|https)://!!) { + $post_accept{$k} = tls_start_cb($v, $post_accept); + } elsif ($nntpd) { # STARTTLS, $k eq '' is OK + $nntpd->{accept_tls} = $v; + } + } + my $sig = { + HUP => $refresh, + INT => \&worker_quit, + QUIT => \&worker_quit, + TERM => \&worker_quit, + TTIN => 'IGNORE', + TTOU => 'IGNORE', + USR1 => \&reopen_logs, + USR2 => 'IGNORE', + WINCH => 'IGNORE', + CHLD => \&PublicInbox::DS::enqueue_reap, + }; my $parent_pipe; if ($worker_processes > 0) { - $parent_pipe = master_loop(); # returns if in child process - my $fd = fileno($parent_pipe); - Danga::Socket->AddOtherFds($fd => sub { kill('TERM', $$) } ); + $refresh->(); # preload by default + my $fh = master_loop(); # returns if in child process + $parent_pipe = PublicInbox::ParentPipe->new($fh, *worker_quit); } else { reopen_logs(); $set_user->() if $set_user; - $SIG{USR2} = sub { worker_quit() if upgrade() }; + $sig->{USR2} = sub { worker_quit() if upgrade() }; + $refresh->(); } $uid = $gid = undef; reopen_logs(); - $refresh->(); - $SIG{QUIT} = $SIG{INT} = $SIG{TERM} = *worker_quit; - $SIG{USR1} = *reopen_logs; - $SIG{HUP} = $refresh; - # this calls epoll_create: - PublicInbox::Listener->new($_, $post_accept) for @listeners; - Danga::Socket->EventLoop; - $parent_pipe = undef; + @listeners = map {; + my $tls_cb = $post_accept{sockname($_)}; + + # NNTPS, HTTPS, HTTP, and POP3S are client-first traffic + # NNTP and POP3 are server-first + defer_accept($_, $tls_cb ? 'dataready' : $af_default); + + # this calls epoll_create: + PublicInbox::Listener->new($_, $tls_cb || $post_accept) + } @listeners; + my $sigfd = PublicInbox::Sigfd->new($sig, SFD_NONBLOCK); + local %SIG = (%SIG, %$sig) if !$sigfd; + if (!$sigfd) { + # wake up every second to accept signals if we don't + # have signalfd or IO::KQueue: + sig_setmask($oldset); + PublicInbox::DS->SetLoopTimeout(1000); + } + PublicInbox::DS->EventLoop; } - -sub daemon_run ($$$) { - my ($default, $refresh, $post_accept) = @_; +sub run ($$$;$) { + my ($default, $refresh, $post_accept, $nntpd) = @_; daemon_prepare($default); - daemonize(); - daemon_loop($refresh, $post_accept); + my $af_default = $default =~ /:8080\z/ ? 'httpready' : undef; + my $for_destroy = daemonize(); + daemon_loop($refresh, $post_accept, $nntpd, $af_default); + PublicInbox::DS->Reset; + # ->DESTROY runs when $for_destroy goes out-of-scope } sub do_chown ($) { @@ -401,4 +658,8 @@ sub write_pid ($) { do_chown($path); } +sub DESTROY { + unlink_pid_file_safe_ish($_[0]->{pid}, $_[0]->{pid_file}); +} + 1;