X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=blobdiff_plain;f=lib%2FPublicInbox%2FMID.pm;h=c82e84013ec0d68730423ab4b691074c5b690dc5;hp=117d3c42f987e1fc2079cbccd2025f0176194085;hb=1cb230c4d47c8ef5d03f0b8de2f8ad93c303d816;hpb=537eb7ec8c0f8ebd6fa39807a08515ccd3c4be66 diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm index 117d3c42..c82e8401 100644 --- a/lib/PublicInbox/MID.pm +++ b/lib/PublicInbox/MID.pm @@ -65,12 +65,6 @@ sub mids ($) { push(@mids, $v); } } - foreach my $i (0..$#mids) { - next if length($mids[$i]) <= MAX_MID_SIZE; - warn "Message-ID: <$mids[$i]> too long, truncating\n"; - $mids[$i] = substr($mids[$i], 0, MAX_MID_SIZE); - } - uniq_mids(\@mids); } @@ -92,10 +86,14 @@ sub uniq_mids ($) { my ($mids) = @_; my @ret; my %seen; - foreach (@$mids) { - next if $seen{$_}; - push @ret, $_; - $seen{$_} = 1; + foreach my $mid (@$mids) { + if (length($mid) > MAX_MID_SIZE) { + warn "Message-ID: <$mid> too long, truncating\n"; + $mid = substr($mid, 0, MAX_MID_SIZE); + } + next if $seen{$mid}; + push @ret, $mid; + $seen{$mid} = 1; } \@ret; }