]> Sergey Matveev's repositories - public-inbox.git/commit
viewdiff: stricter highlighting and linkification check
authorEric Wong <e@yhbt.net>
Wed, 6 May 2020 10:40:54 +0000 (10:40 +0000)
committerEric Wong <e@yhbt.net>
Thu, 7 May 2020 19:09:43 +0000 (19:09 +0000)
commitc2bc9ebcb770a27823d8e989707f434826333b0e
tree4186ab7ca6cae110e1262acd95c8d7eeb9b287da
parent65b37aeb8392a62e9aa8ceac08227c77c6fa6b8b
viewdiff: stricter highlighting and linkification check

Sometimes senders draw ASCII tables and such which we
get fooled into attempting highlighting and diffstat
anchoring.

We now require 3 consecutive diff header lines:

/^--- /, /^\Q+++\E /, and /^@@ /

to enable diff highlighting (whether generated with git or not).
The presence of a line matching /^diff / is not sufficient or
even useful to us for highlighting diffs, since that could just
be part of a line-wrapped sentence.

However, we'll now check for the presence of a line matching
/^diff --git / before enabling diffstat anchors.  Otherwise
cover letters for a patch series may fool us into creating
anchors for diffstats.
lib/PublicInbox/View.pm
lib/PublicInbox/ViewDiff.pm