]> Sergey Matveev's repositories - public-inbox.git/commitdiff
t/precheck: remove Email::Simple->create from tests
authorEric Wong <e@yhbt.net>
Wed, 29 Apr 2020 11:14:43 +0000 (11:14 +0000)
committerEric Wong <e@yhbt.net>
Thu, 30 Apr 2020 07:34:00 +0000 (07:34 +0000)
It's likely we'll replace Email::Simple using our Email::MIME
alternative/replacement, as well.  So reduce the API surface we
interact with and make it easier to swap implementations.

t/precheck.t

index 53d4fb2bdbcb5b8629c5466beb9fadc3d29dc294..a8fd31b1ab33423d3261d807a554e08a7d3baa66 100644 (file)
@@ -27,65 +27,61 @@ sub do_checks {
 }
 
 {
-       my $s = Email::Simple->create(
-               header => [
-                       From => 'abc@example.com',
-                       To => 'abc@example.com',
-                       Cc => 'c@example.com, another-list@example.com',
-                       'Content-Type' => 'text/plain',
-                       Subject => 'list is fine',
-                       'Message-ID' => '<MID@host>',
-                       Date => 'Wed, 09 Apr 2014 01:28:34 +0000',
-               ],
-               body => "hello world\n",
-       );
+       my $s = Email::Simple->new(<<'EOF');
+From: abc@example.com
+To: abc@example.com
+Cc: c@example.com, another-list@example.com
+Content-Type: text/plain
+Subject: list is fine
+Message-ID: <MID@host>
+Date: Wed, 09 Apr 2014 01:28:34 +0000
+
+hello world
+EOF
        my $addr = [ 'c@example.com', 'd@example.com' ];
        ok(PublicInbox::MDA->precheck($s, $addr), 'Cc list is OK');
 }
 
 {
-       do_checks(Email::Simple->create(
-               header => [
-                       From => 'a@example.com',
-                       To => 'b@example.com',
-                       Cc => 'c@example.com',
-                       'Content-Type' => 'text/plain',
-                       Subject => 'this is a subject',
-                       'Message-ID' => '<MID@host>',
-                       Date => 'Wed, 09 Apr 2014 01:28:34 +0000',
-               ],
-               body => "hello world\n",
-       ));
+       do_checks(Email::Simple->new(<<'EOF'));
+From: a@example.com
+To: b@example.com
+Cc: c@example.com
+Content-Type: text/plain
+Subject: this is a subject
+Message-ID: <MID@host>
+Date: Wed, 09 Apr 2014 01:28:34 +0000
+
+hello world
+EOF
 }
 
 {
-       do_checks(Email::Simple->create(
-               header => [
-                       From => 'a@example.com',
-                       To => 'b+plus@example.com',
-                       Cc => 'John Doe <c@example.com>',
-                       'Content-Type' => 'text/plain',
-                       Subject => 'this is a subject',
-                       'Message-ID' => '<MID@host>',
-                       Date => 'Wed, 09 Apr 2014 01:28:34 +0000',
-               ],
-               body => "hello world\n",
-       ));
+       do_checks(Email::Simple->new(<<'EOF'));
+From: a@example.com
+To: b+plus@example.com
+Cc: John Doe <c@example.com>
+Content-Type: text/plain
+Subject: this is a subject
+Message-ID: <MID@host>
+Date: Wed, 09 Apr 2014 01:28:34 +0000
+
+hello world
+EOF
 }
 
 {
        my $recipient = 'b@example.com';
-       my $s = Email::Simple->create(
-               header => [
-                       To => 'b@example.com',
-                       Cc => 'c@example.com',
-                       'Content-Type' => 'text/plain',
-                       Subject => 'this is a subject',
-                       'Message-ID' => '<MID@host>',
-                       Date => 'Wed, 09 Apr 2014 01:28:34 +0000',
-               ],
-               body => "hello world\n",
-       );
+       my $s = Email::Simple->new(<<'EOF');
+To: b@example.com
+Cc: c@example.com
+Content-Type: text/plain
+Subject: this is a subject
+Message-ID: <MID@host>
+Date: Wed, 09 Apr 2014 01:28:34 +0000
+
+hello world
+EOF
        ok(!PublicInbox::MDA->precheck($s, $recipient),
                "missing From: is rejected");
 }