]> Sergey Matveev's repositories - public-inbox.git/commitdiff
qspawn: remove Perl 5.16.x leak workaround
authorEric Wong <e@yhbt.net>
Fri, 17 Apr 2020 09:33:31 +0000 (09:33 +0000)
committerEric Wong <e@yhbt.net>
Tue, 21 Apr 2020 05:51:38 +0000 (05:51 +0000)
It seems no longer necessary to workaround this Perl 5.16.3 bug
after the removal of anonymous subs from all of our internal
code in
https://public-inbox.org/meta/20191225075104.22184-1-e@80x24.org/

Tested with repeated clones (both aborted and completed)
in a CentOS 7.x VM which was once able to reproduce leaks
before the workaround appeared in 2fc42236f72ad16a
("qspawn: workaround Perl 5.16.3 leak, re-enable Deflater")

Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
lib/PublicInbox/Qspawn.pm

index aebcb1f7db091ea8d3283407a2c0cbd559d407f8..c09e8d2c227b0b6bc01ddc1a13598d72c73d6c72 100644 (file)
@@ -281,10 +281,6 @@ sub psgi_return_init_cb {
                                        ${$self->{hdr_buf}}, $filter);
                $wcb->($r);
        }
-
-       # Workaround a leak under Perl 5.16.3 when combined with
-       # Plack::Middleware::Deflater:
-       $wcb = undef;
 }
 
 sub psgi_return_start { # may run later, much later...